| Message ID | 1302669534-28926-1-git-send-email-tushar.behera@linaro.org |
|---|---|
| State | Rejected |
| Headers | show |
Tushar Behera wrote: > > On Exynos4210 SOC, of all the HSMMC controllers only HSMMC2 can > be used as a boot media. Hence the default SD/MMC card should be > connected to HSMMC2. The secondary card is connected to HSMMC0. > > If HSMMC0 is registered before HSMMC2, the device node for default > MMC card changes depending on whether secondary card is connected > or not. It creates problem in mounting the file-system present in > default SD/MMC card. Hence HSMMC2 should be registered before HSMMC0. > > Signed-off-by: Tushar Behera <tushar.behera@linaro.org> > --- > arch/arm/mach-exynos4/mach-smdkv310.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach- > exynos4/mach-smdkv310.c > index f6b1c7e..4f34d43 100644 > --- a/arch/arm/mach-exynos4/mach-smdkv310.c > +++ b/arch/arm/mach-exynos4/mach-smdkv310.c > @@ -168,9 +168,9 @@ static struct i2c_board_info i2c_devs1[] __initdata = { > }; > > static struct platform_device *smdkv310_devices[] __initdata = { > + &s3c_device_hsmmc2, > &s3c_device_hsmmc0, > &s3c_device_hsmmc1, > - &s3c_device_hsmmc2, > &s3c_device_hsmmc3, > &s3c_device_i2c1, > &s3c_device_rtc, > -- > 1.7.1 Hmm...I can understand your pointing out and situation. But as you know, channel 4 also can be used for boot media when eMMC booting and SMDKV310 can support it by jumper setting. I mean it can be modified according to each board's situation for mass production and we don't need this for SMDK in mainline now. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
diff --git a/arch/arm/mach-exynos4/mach-smdkv310.c b/arch/arm/mach-exynos4/mach-smdkv310.c index f6b1c7e..4f34d43 100644 --- a/arch/arm/mach-exynos4/mach-smdkv310.c +++ b/arch/arm/mach-exynos4/mach-smdkv310.c @@ -168,9 +168,9 @@ static struct i2c_board_info i2c_devs1[] __initdata = { }; static struct platform_device *smdkv310_devices[] __initdata = { + &s3c_device_hsmmc2, &s3c_device_hsmmc0, &s3c_device_hsmmc1, - &s3c_device_hsmmc2, &s3c_device_hsmmc3, &s3c_device_i2c1, &s3c_device_rtc,
On Exynos4210 SOC, of all the HSMMC controllers only HSMMC2 can be used as a boot media. Hence the default SD/MMC card should be connected to HSMMC2. The secondary card is connected to HSMMC0. If HSMMC0 is registered before HSMMC2, the device node for default MMC card changes depending on whether secondary card is connected or not. It creates problem in mounting the file-system present in default SD/MMC card. Hence HSMMC2 should be registered before HSMMC0. Signed-off-by: Tushar Behera <tushar.behera@linaro.org> --- arch/arm/mach-exynos4/mach-smdkv310.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)