diff mbox

EXYNOS: Fix USB compiler warning

Message ID 1341898474-14729-1-git-send-email-rajeshwari.s@samsung.com
State Accepted
Commit 30704dae469c092766c346b3bef7ac001fa45511
Headers show

Commit Message

Rajeshwari Shinde July 10, 2012, 5:34 a.m. UTC
Fixed the compiler warning message.

Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
---
 arch/arm/cpu/armv7/exynos/system.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Marek Vasut July 10, 2012, 5:37 a.m. UTC | #1
Dear Rajeshwari Shinde,

> Fixed the compiler warning message.

Acked-by: Marek Vasut <marex@denx.de>

> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/system.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/exynos/system.c
> b/arch/arm/cpu/armv7/exynos/system.c index cc6ee03..4426611 100644
> --- a/arch/arm/cpu/armv7/exynos/system.c
> +++ b/arch/arm/cpu/armv7/exynos/system.c
> @@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
>  {
>  	struct exynos5_sysreg *sysreg =
>  		(struct exynos5_sysreg *)samsung_get_base_sysreg();
> -	unsigned int phy_cfg;
> 
>  	/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
>  	if (mode == USB20_PHY_CFG_HOST_LINK_EN) {

Best regards,
Marek Vasut
Jaehoon Chung July 10, 2012, 5:48 a.m. UTC | #2
Hi Rajeshwari,

How do you think about fixing other warning messages?
If you are inconvenience, i will fix it.

pinmux.c: In function 'exynos_pinmux_config':
pinmux.c:100:20: warning: 'gpio_func' may be used uninitialized in this function [-Wuninitialized]
pinmux.c:69:16: note: 'gpio_func' was declared here
pinmux.c:99:31: warning: 'start' may be used uninitialized in this function [-Wuninitialized]
pinmux.c:69:9: note: 'start' was declared here

Best Regards,
Jaehoon Chung

On 07/10/2012 02:34 PM, Rajeshwari Shinde wrote:

> Fixed the compiler warning message.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/system.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c
> index cc6ee03..4426611 100644
> --- a/arch/arm/cpu/armv7/exynos/system.c
> +++ b/arch/arm/cpu/armv7/exynos/system.c
> @@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
>  {
>  	struct exynos5_sysreg *sysreg =
>  		(struct exynos5_sysreg *)samsung_get_base_sysreg();
> -	unsigned int phy_cfg;
>  
>  	/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
>  	if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
Rajeshwari Birje July 10, 2012, 5:56 a.m. UTC | #3
Hi Jaehoon Chung,

I just fixed the waning messages i saw on u-boot-usb.
Did not find these warning messages in that tree.
Will fix these. Sorry for inconvenience.

Regards,
Rajeshwari Shinde.

On Tue, Jul 10, 2012 at 11:18 AM, Jaehoon Chung <jh80.chung@samsung.com> wrote:
> Hi Rajeshwari,
>
> How do you think about fixing other warning messages?
> If you are inconvenience, i will fix it.
>
> pinmux.c: In function 'exynos_pinmux_config':
> pinmux.c:100:20: warning: 'gpio_func' may be used uninitialized in this function [-Wuninitialized]
> pinmux.c:69:16: note: 'gpio_func' was declared here
> pinmux.c:99:31: warning: 'start' may be used uninitialized in this function [-Wuninitialized]
> pinmux.c:69:9: note: 'start' was declared here
>
> Best Regards,
> Jaehoon Chung
>
> On 07/10/2012 02:34 PM, Rajeshwari Shinde wrote:
>
>> Fixed the compiler warning message.
>>
>> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
>> ---
>>  arch/arm/cpu/armv7/exynos/system.c |    1 -
>>  1 files changed, 0 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c
>> index cc6ee03..4426611 100644
>> --- a/arch/arm/cpu/armv7/exynos/system.c
>> +++ b/arch/arm/cpu/armv7/exynos/system.c
>> @@ -29,7 +29,6 @@ static void exynos5_set_usbhost_mode(unsigned int mode)
>>  {
>>       struct exynos5_sysreg *sysreg =
>>               (struct exynos5_sysreg *)samsung_get_base_sysreg();
>> -     unsigned int phy_cfg;
>>
>>       /* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
>>       if (mode == USB20_PHY_CFG_HOST_LINK_EN) {
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Wolfgang Denk July 10, 2012, 6:50 a.m. UTC | #4
Dear Rajeshwari Shinde,

In message <1341898474-14729-1-git-send-email-rajeshwari.s@samsung.com> you wrote:
> Fixed the compiler warning message.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s@samsung.com>
> ---
>  arch/arm/cpu/armv7/exynos/system.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/exynos/system.c b/arch/arm/cpu/armv7/exynos/system.c
index cc6ee03..4426611 100644
--- a/arch/arm/cpu/armv7/exynos/system.c
+++ b/arch/arm/cpu/armv7/exynos/system.c
@@ -29,7 +29,6 @@  static void exynos5_set_usbhost_mode(unsigned int mode)
 {
 	struct exynos5_sysreg *sysreg =
 		(struct exynos5_sysreg *)samsung_get_base_sysreg();
-	unsigned int phy_cfg;
 
 	/* Setting USB20PHY_CONFIG register to USB 2.0 HOST link */
 	if (mode == USB20_PHY_CFG_HOST_LINK_EN) {