misc: pci_endpoint_test: select CONFIG_CRC32

Message ID 20170511121357.3548228-1-arnd@arndb.de
State New
Headers show

Commit Message

Arnd Bergmann May 11, 2017, 12:13 p.m.
Without CRC32, we get this link error:

pci_endpoint_test.c:(.text+0x2509e): undefined reference to `crc32_le'

Fixes: 58c89c8aa0e8 ("misc: Add host side PCI driver for PCI test function device")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 drivers/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.9.0

Comments

Greg KH May 16, 2017, 9:02 p.m. | #1
On Thu, May 11, 2017 at 02:13:33PM +0200, Arnd Bergmann wrote:
> Without CRC32, we get this link error:

> 

> pci_endpoint_test.c:(.text+0x2509e): undefined reference to `crc32_le'

> 

> Fixes: 58c89c8aa0e8 ("misc: Add host side PCI driver for PCI test function device")


There is no such commit id :(

Also, I think someone else sent this a few days before you did...

thanks,

greg k-h
Arnd Bergmann May 17, 2017, 7:51 a.m. | #2
On Tue, May 16, 2017 at 11:02 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Thu, May 11, 2017 at 02:13:33PM +0200, Arnd Bergmann wrote:

>> Without CRC32, we get this link error:

>>

>> pci_endpoint_test.c:(.text+0x2509e): undefined reference to `crc32_le'

>>

>> Fixes: 58c89c8aa0e8 ("misc: Add host side PCI driver for PCI test function device")

>

> There is no such commit id :(


I checked what happened: 58c89c8aa0e8 was in linux-next when I prepared the
patch, but 2c156ac71c6b25 is the commit ID that was merged in the end
after Bjorn rebased the patch on Apr 28, but I had not sent out the fix at
that point yet.

> Also, I think someone else sent this a few days before you did...


Ok.

        Arnd

Patch hide | download patch | download mbox

diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index 2cba76e6fa3c..07bbd4cc1852 100644
--- a/drivers/misc/Kconfig
+++ b/drivers/misc/Kconfig
@@ -492,6 +492,7 @@  config ASPEED_LPC_CTRL
 
 config PCI_ENDPOINT_TEST
 	depends on PCI
+	select CRC32
 	tristate "PCI Endpoint Test driver"
 	---help---
            Enable this configuration option to enable the host side test driver