[v1,1/1] configure.ac: fix mcx16 vs clang check

Message ID 1494547205-26483-2-git-send-email-odpbot@yandex.ru
State New
Headers show
Series
  • [v1,1/1] configure.ac: fix mcx16 vs clang check
Related show

Commit Message

Github ODP bot May 12, 2017, midnight
From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>


Currently configure script outputs the following error on my sistem,
because the syntax is far from being standard. Use standard case/esac
instead.

./configure: line 23507: x86_64-pc-linux-gnu: command not found

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

---
/** Email created from pull request 29 (lumag:fix-mcx16)
 ** https://github.com/Linaro/odp/pull/29
 ** Patch: https://github.com/Linaro/odp/pull/29.patch
 ** Base sha: 91f92891554b9c335e9f51f8ef574b74a37a11fb
 ** Merge commit sha: 50284f7c8db50fd9e15d6d5e5e3d8f2d47fc6792
 **/
 configure.ac | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Maxim Uvarov May 12, 2017, 12:23 a.m. | #1
On 05/12/2017 03:00 AM, Github ODP bot wrote:
> From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

>

> Currently configure script outputs the following error on my sistem,

> because the syntax is far from being standard. Use standard case/esac

> instead.

>

> ./configure: line 23507: x86_64-pc-linux-gnu: command not found


yes, I also saw that some few days ago.

Maxim.

> Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

> ---

> /** Email created from pull request 29 (lumag:fix-mcx16)

>   ** https://github.com/Linaro/odp/pull/29

>   ** Patch: https://github.com/Linaro/odp/pull/29.patch

>   ** Base sha: 91f92891554b9c335e9f51f8ef574b74a37a11fb

>   ** Merge commit sha: 50284f7c8db50fd9e15d6d5e5e3d8f2d47fc6792

>   **/

>   configure.ac | 6 ++++--

>   1 file changed, 4 insertions(+), 2 deletions(-)

>

> diff --git a/configure.ac b/configure.ac

> index d364b8d..7569ebe 100644

> --- a/configure.ac

> +++ b/configure.ac

> @@ -306,7 +306,8 @@ ODP_CFLAGS="$ODP_CFLAGS $ODP_CFLAGS_EXTRA"

>   ##########################################################################

>   # Check if compiler supports cmpxchng16 on x86-based architectures

>   ##########################################################################

> -if "${host}" == i?86* -o "${host}" == x86*; then

> +case "${host}" in

> +  i?86? | x86*)

>     if test "${CC}" != "gcc" -o ${CC_VERSION_MAJOR} -ge 5; then

>        my_save_cflags="$CFLAGS"

>   

> @@ -319,7 +320,8 @@ if "${host}" == i?86* -o "${host}" == x86*; then

>     	    )

>        CFLAGS="$my_save_cflags"

>     fi

> -fi

> +  ;;

> +esac

>   

>   ##########################################################################

>   # Default include setup

>

Patch hide | download patch | download mbox

diff --git a/configure.ac b/configure.ac
index d364b8d..7569ebe 100644
--- a/configure.ac
+++ b/configure.ac
@@ -306,7 +306,8 @@  ODP_CFLAGS="$ODP_CFLAGS $ODP_CFLAGS_EXTRA"
 ##########################################################################
 # Check if compiler supports cmpxchng16 on x86-based architectures
 ##########################################################################
-if "${host}" == i?86* -o "${host}" == x86*; then
+case "${host}" in
+  i?86? | x86*)
   if test "${CC}" != "gcc" -o ${CC_VERSION_MAJOR} -ge 5; then
      my_save_cflags="$CFLAGS"
 
@@ -319,7 +320,8 @@  if "${host}" == i?86* -o "${host}" == x86*; then
   	    )
      CFLAGS="$my_save_cflags"
   fi
-fi
+  ;;
+esac
 
 ##########################################################################
 # Default include setup