[RFC,v1,3/7] iommu/arm-smmu-v3: Replace the device tree binding for hisilicon broken prefetch cmd with erratum id

Message ID 20170513094731.3676-4-shameerali.kolothum.thodi@huawei.com
State New
Headers show
Series
  • iommu/smmu-v3: Workaround for hisilicon 161010801 erratum(reserve HW MSI)
Related show

Commit Message

Shameerali Kolothum Thodi May 13, 2017, 9:47 a.m.
Signed-off-by: shameer <shameerali.kolothum.thodi@huawei.com>

---
 Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Rob Herring May 15, 2017, 3:23 p.m. | #1
On Sat, May 13, 2017 at 4:47 AM, shameer
<shameerali.kolothum.thodi@huawei.com> wrote:
> Signed-off-by: shameer <shameerali.kolothum.thodi@huawei.com>

> ---

>  Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> index be57550..bf48e92 100644

> --- a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> @@ -46,7 +46,7 @@ the PCIe specification.

>                          devicetree/bindings/interrupt-controller/msi.txt

>                        for a description of the msi-parent property.

>

> -- hisilicon,broken-prefetch-cmd

> +- hisilicon,erratum-161010701


Why? Your missing commit msg should answer that. This breaks
compatibility, so you are stuck with the old string.

I'd prefer that you start using the compatible string rather than
every vendor adding a property for every errata.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Shameerali Kolothum Thodi May 16, 2017, 10:15 a.m. | #2
> -----Original Message-----

> From: Rob Herring [mailto:robh@kernel.org]

> Sent: Monday, May 15, 2017 4:24 PM

> To: Shameerali Kolothum Thodi

> Cc: Will Deacon; Robin Murphy; Mark Rutland; Lorenzo Pieralisi; Hanjun Guo;

> Gabriele Paoloni; John Garry; Linux IOMMU; devicetree@vger.kernel.org;

> linux-arm-kernel@lists.infradead.org; linux-acpi@vger.kernel.org;

> devel@acpica.org; Linuxarm; Wangzhou (B); Guohanjun (Hanjun Guo)

> Subject: Re: [RFC v1 3/7] iommu/arm-smmu-v3: Replace the device tree

> binding for hisilicon broken prefetch cmd with erratum id

> 

> On Sat, May 13, 2017 at 4:47 AM, shameer

> <shameerali.kolothum.thodi@huawei.com> wrote:

> > Signed-off-by: shameer <shameerali.kolothum.thodi@huawei.com>

> > ---

> >  Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> > b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> > index be57550..bf48e92 100644

> > --- a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt

> > @@ -46,7 +46,7 @@ the PCIe specification.

> >                          devicetree/bindings/interrupt-controller/msi.txt

> >                        for a description of the msi-parent property.

> >

> > -- hisilicon,broken-prefetch-cmd

> > +- hisilicon,erratum-161010701

> 

> Why? Your missing commit msg should answer that. This breaks

> compatibility, so you are stuck with the old string.

> 

> I'd prefer that you start using the compatible string rather than every vendor

> adding a property for every errata.


Ok. I will wait for the review of other patches in this series and update it accordingly
in the next revision.

Thanks,
Shameer

Patch hide | download patch | download mbox

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt
index be57550..bf48e92 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt
@@ -46,7 +46,7 @@  the PCIe specification.
                         devicetree/bindings/interrupt-controller/msi.txt
                       for a description of the msi-parent property.
 
-- hisilicon,broken-prefetch-cmd
+- hisilicon,erratum-161010701
                     : Avoid sending CMD_PREFETCH_* commands to the SMMU.
 
 ** Example