diff mbox

kbuild: update DTC warning settings for bus and node/property name checks

Message ID 1494832053-2430-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Commit 50749d2ac30dd7af94d8c9ed64276f92d9d396f5
Headers show

Commit Message

Masahiro Yamada May 15, 2017, 7:07 a.m. UTC
Recent commits of DTC introduced new warnings checking PCI and simple
buses, unit address formatting, and stricter node and property name
checking.  Disable the new DTC warnings by default.  As before,
warnings are enabled with W=*.  The strict node and property name
checks are a bit subjective, so they are only enabled for W=2.
(This policy reflects the commit 8654cb8d0371 of Linux.)

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 scripts/Makefile.extrawarn | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Tom Rini May 15, 2017, 11:20 p.m. UTC | #1
On Mon, May 15, 2017 at 04:07:33PM +0900, Masahiro Yamada wrote:

> Recent commits of DTC introduced new warnings checking PCI and simple

> buses, unit address formatting, and stricter node and property name

> checking.  Disable the new DTC warnings by default.  As before,

> warnings are enabled with W=*.  The strict node and property name

> checks are a bit subjective, so they are only enabled for W=2.

> (This policy reflects the commit 8654cb8d0371 of Linux.)

> 

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>


Applied to u-boot/master, thanks!

-- 
Tom
Simon Glass May 16, 2017, 12:17 a.m. UTC | #2
On 15 May 2017 at 01:07, Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> Recent commits of DTC introduced new warnings checking PCI and simple
> buses, unit address formatting, and stricter node and property name
> checking.  Disable the new DTC warnings by default.  As before,
> warnings are enabled with W=*.  The strict node and property name
> checks are a bit subjective, so they are only enabled for W=2.
> (This policy reflects the commit 8654cb8d0371 of Linux.)
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  scripts/Makefile.extrawarn | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/scripts/Makefile.extrawarn b/scripts/Makefile.extrawarn
index 7b2cffc..90dc149 100644
--- a/scripts/Makefile.extrawarn
+++ b/scripts/Makefile.extrawarn
@@ -58,9 +58,23 @@  endif
 
 KBUILD_CFLAGS += $(warning)
 
+dtc-warning-2 += $(call dtc-option,-Wnode_name_chars_strict)
+dtc-warning-2 += $(call dtc-option,-Wproperty_name_chars_strict)
+
+dtc-warning := $(dtc-warning-$(findstring 1, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
+dtc-warning += $(dtc-warning-$(findstring 2, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
+dtc-warning += $(dtc-warning-$(findstring 3, $(KBUILD_ENABLE_EXTRA_GCC_CHECKS)))
+
+DTC_FLAGS += $(dtc-warning)
+
 else
 
 # Disable noisy checks by default
 DTC_FLAGS += $(call dtc-option,-Wno-unit_address_vs_reg)
+DTC_FLAGS += $(call dtc-option,-Wno-simple_bus_reg)
+DTC_FLAGS += $(call dtc-option,-Wno-unit_address_format)
+DTC_FLAGS += $(call dtc-option,-Wno-pci_bridge)
+DTC_FLAGS += $(call dtc-option,-Wno-pci_device_bus_num)
+DTC_FLAGS += $(call dtc-option,-Wno-pci_device_reg)
 
 endif