From patchwork Mon May 15 13:01:10 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Wiklander X-Patchwork-Id: 99812 Delivered-To: patches@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1535116qge; Mon, 15 May 2017 06:02:35 -0700 (PDT) X-Received: by 10.55.158.18 with SMTP id h18mr4658326qke.263.1494853355882; Mon, 15 May 2017 06:02:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494853355; cv=none; d=google.com; s=arc-20160816; b=fns91LNy83TVQJOfDq/hqdLLkROvjtvQCKKmRNgWpUtz5OcRSJlfyKEiqGdg5a4+0/ pKq4jOHXSDnBuIMR8ZemEPGZapEzbrL18lRyQaLRD+C5mNX49KDt5yX1df3byJixhFsM 6nFUU/C6+oX/lcpIoRv0GFQTWfUeAk+KI1Y/JOTd6scYOvSsIb43n0aFj9YjF6BHNNKR XURsQN3/Ap6You/iLQ6CZ3WJuxflIeqImZWwjjRStNiqD123Ht1cgQ3/TW1mi22sA9/b HR87gG0lffnwML1zbeSfQPDiNI8/iYKnrFhCe8uXBdcyndGgHENGBYv6r1TsEjW00eMT fm0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature :arc-authentication-results; bh=vodONn2mZwYAY3ZgC68hgiGQA5lRHl919eYfsP95iQQ=; b=Tp/9JlTMlZO6+xBGF2Lm2LZ2jb8kZ7+3yPFPGtLACZE+IYkxZbfDzVSzL2dr+8YN0H te7n8HhB3VmZivMGDxXDR6yXBI0grE/MfvAwR6aUqDT2lTQUMaXmzBDoFEWIi6rUzRdJ XwgQ+E5V7lmDZFZOMrvypa8zU6w/NB93JyS9n0BNnY7xJteZEKEQP8AWu8Ta/iwAd8Hf +J2n1z/WlnEtBFsYbQEb99IBKm02Sc02nCCPZr7wi3cNN6mEdICLeiIGZ/DSGG7rKyvx bGB8mEsb+leRwbQBWRICz066CRCLmE7jBg4obOZgiKPmsbxp93ZCgnl18gboLPAFNx4i cC/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 2607:f8b0:400d:c0d::22e as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from mail-qt0-x22e.google.com (mail-qt0-x22e.google.com. [2607:f8b0:400d:c0d::22e]) by mx.google.com with ESMTPS id t18si10588600qta.84.2017.05.15.06.02.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 May 2017 06:02:35 -0700 (PDT) Received-SPF: pass (google.com: domain of jens.wiklander@linaro.org designates 2607:f8b0:400d:c0d::22e as permitted sender) client-ip=2607:f8b0:400d:c0d::22e; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of jens.wiklander@linaro.org designates 2607:f8b0:400d:c0d::22e as permitted sender) smtp.mailfrom=jens.wiklander@linaro.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: by mail-qt0-x22e.google.com with SMTP id f55so43860689qta.3 for ; Mon, 15 May 2017 06:02:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=vodONn2mZwYAY3ZgC68hgiGQA5lRHl919eYfsP95iQQ=; b=HDF08VZJSrkP1HmIc8BAJa/5nGnhelUa6xbf6foQ5XEDhs1KcQAjjWmLg0Y01LsjPR eyW0wUwYxtFcSnmFUnS6w2lQmAaP9PdZQeVf+hOSinN7XTxrdfnx7dBrlMv/Sqm7ojGU ulfMVv+aHe3NUCcyC8K2kHTLbgjXvfGZ10zbs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vodONn2mZwYAY3ZgC68hgiGQA5lRHl919eYfsP95iQQ=; b=jgKNG1ML/32M4rHWDzDF8wtaRmmuyBYQM1zwSeafbSx0rjpoS5k8qhkty5TAZsQzUs BBLD7NcDF/e0v7VWcAHFTm7Le2rWDVQgU4rwzlXWwNxS+wxbkg9/5vlwWDdIdwV9dQTF HMviFDVMdRMvOl/ZHmHhMW5xhYNE6tGhMjoSt7fWjDNIPu2DoQnrjldFePB7Z0fdryU7 jd7j1tHBMvFgYxNJZtNN48B10KQEdwAK85r+nm/arhGE1pVKUevme1XxZEBhvwe/iLB4 UCCJdRmJlYzC2LPoq8JTdBvDcaNIupze2B5vENgwP/hqu1ZvEq7Zmi/AA4fQ+NqIh4FX 4Hiw== X-Gm-Message-State: AODbwcBMWaOB5HAFnGuferjYmBuHi52GcdeC0AEafftVOs4jgLYuC/Kz BpFpYBTWB5s3KMqrFUw= X-Received: by 10.46.82.151 with SMTP id n23mr1973313lje.2.1494853355437; Mon, 15 May 2017 06:02:35 -0700 (PDT) Return-Path: Received: from jax.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id h76sm1866026lji.10.2017.05.15.06.02.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 15 May 2017 06:02:34 -0700 (PDT) From: Jens Wiklander To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Arnd Bergmann , Dan Carpenter , Jens Wiklander Subject: [PATCH] tee: optee: fix uninitialized symbol 'parg' Date: Mon, 15 May 2017 15:01:10 +0200 Message-Id: <1494853270-22019-1-git-send-email-jens.wiklander@linaro.org> X-Mailer: git-send-email 2.7.4 Fixes the static checker warning in optee_release(). error: uninitialized symbol 'parg'. Reported-by: Dan Carpenter Signed-off-by: Jens Wiklander --- drivers/tee/optee/core.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.7.4 diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index 58169e519422..857141e29e80 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -224,13 +224,14 @@ static void optee_release(struct tee_context *ctx) if (!IS_ERR(shm)) { arg = tee_shm_get_va(shm, 0); /* - * If va2pa fails for some reason, we can't call - * optee_close_session(), only free the memory. Secure OS - * will leak sessions and finally refuse more sessions, but - * we will at least let normal world reclaim its memory. + * If va2pa fails for some reason, we can't call into + * secure world, only free the memory. Secure OS will leak + * sessions and finally refuse more sessions, but we will + * at least let normal world reclaim its memory. */ if (!IS_ERR(arg)) - tee_shm_va2pa(shm, arg, &parg); + if (tee_shm_va2pa(shm, arg, &parg)) + arg = NULL; /* prevent usage of parg below */ } list_for_each_entry_safe(sess, sess_tmp, &ctxdata->sess_list,