[v2,3/6] scripts/qemu-gdb/tcg: new helper to dump tcg state

Message ID 20170517145259.28979-4-alex.bennee@linaro.org
State New
Headers show
Series
  • gdb updates and cputlb traces
Related show

Commit Message

Alex Bennée May 17, 2017, 2:52 p.m.
This adds a simple helper to dump lock state within TCG.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 scripts/qemu-gdb.py    |  3 ++-
 scripts/qemugdb/tcg.py | 46 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+), 1 deletion(-)
 create mode 100644 scripts/qemugdb/tcg.py

-- 
2.11.0

Comments

Philippe Mathieu-Daudé May 31, 2017, 1:41 a.m. | #1
On 05/17/2017 11:52 AM, Alex Bennée wrote:
> This adds a simple helper to dump lock state within TCG.

>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


> ---

>  scripts/qemu-gdb.py    |  3 ++-

>  scripts/qemugdb/tcg.py | 46 ++++++++++++++++++++++++++++++++++++++++++++++

>  2 files changed, 48 insertions(+), 1 deletion(-)

>  create mode 100644 scripts/qemugdb/tcg.py

>

> diff --git a/scripts/qemu-gdb.py b/scripts/qemu-gdb.py

> index 3e7adb87dc..91e928f6af 100644

> --- a/scripts/qemu-gdb.py

> +++ b/scripts/qemu-gdb.py

> @@ -26,7 +26,7 @@ import os, sys

>

>  sys.path.append(os.path.dirname(__file__))

>

> -from qemugdb import aio, mtree, coroutine, timers

> +from qemugdb import aio, mtree, coroutine, timers, tcg

>

>  class QemuCommand(gdb.Command):

>      '''Prefix for QEMU debug support commands'''

> @@ -39,6 +39,7 @@ coroutine.CoroutineCommand()

>  mtree.MtreeCommand()

>  aio.HandlersCommand()

>  timers.TimersCommand()

> +tcg.TCGLockStatusCommand()

>

>  coroutine.CoroutineSPFunction()

>  coroutine.CoroutinePCFunction()

> diff --git a/scripts/qemugdb/tcg.py b/scripts/qemugdb/tcg.py

> new file mode 100644

> index 0000000000..8c7f1d7454

> --- /dev/null

> +++ b/scripts/qemugdb/tcg.py

> @@ -0,0 +1,46 @@

> +#!/usr/bin/python

> +# -*- coding: utf-8 -*-

> +#

> +# GDB debugging support, TCG status

> +#

> +# Copyright 2016 Linaro Ltd

> +#

> +# Authors:

> +#  Alex Bennée <alex.bennee@linaro.org>

> +#

> +# This work is licensed under the terms of the GNU GPL, version 2.  See

> +# the COPYING file in the top-level directory.

> +#

> +# Contributions after 2012-01-13 are licensed under the terms of the

> +# GNU GPL, version 2 or (at your option) any later version.

> +

> +# 'qemu tcg-lock-status' -- display the TCG lock status across threads

> +

> +import gdb

> +

> +class TCGLockStatusCommand(gdb.Command):

> +    '''Display TCG Execution Status'''

> +    def __init__(self):

> +        gdb.Command.__init__(self, 'qemu tcg-lock-status', gdb.COMMAND_DATA,

> +                             gdb.COMPLETE_NONE)

> +

> +    def invoke(self, arg, from_tty):

> +        gdb.write("Thread, BQL (iothread_mutex), Replay, Blocked?\n")

> +        for thread in gdb.inferiors()[0].threads():

> +            thread.switch()

> +

> +            iothread = gdb.parse_and_eval("iothread_locked")

> +            replay = gdb.parse_and_eval("replay_locked")

> +

> +            frame = gdb.selected_frame()

> +            if frame.name() == "__lll_lock_wait":

> +                frame.older().select()

> +                mutex = gdb.parse_and_eval("mutex")

> +                owner = gdb.parse_and_eval("mutex->__data.__owner")

> +                blocked = ("__lll_lock_wait waiting on %s from %d" %

> +                           (mutex, owner))

> +            else:

> +                blocked = "not blocked"

> +

> +            gdb.write("%d/%d, %s, %s, %s\n" % (thread.num, thread.ptid[1],

> +                                               iothread, replay, blocked))

>

Patch hide | download patch | download mbox

diff --git a/scripts/qemu-gdb.py b/scripts/qemu-gdb.py
index 3e7adb87dc..91e928f6af 100644
--- a/scripts/qemu-gdb.py
+++ b/scripts/qemu-gdb.py
@@ -26,7 +26,7 @@  import os, sys
 
 sys.path.append(os.path.dirname(__file__))
 
-from qemugdb import aio, mtree, coroutine, timers
+from qemugdb import aio, mtree, coroutine, timers, tcg
 
 class QemuCommand(gdb.Command):
     '''Prefix for QEMU debug support commands'''
@@ -39,6 +39,7 @@  coroutine.CoroutineCommand()
 mtree.MtreeCommand()
 aio.HandlersCommand()
 timers.TimersCommand()
+tcg.TCGLockStatusCommand()
 
 coroutine.CoroutineSPFunction()
 coroutine.CoroutinePCFunction()
diff --git a/scripts/qemugdb/tcg.py b/scripts/qemugdb/tcg.py
new file mode 100644
index 0000000000..8c7f1d7454
--- /dev/null
+++ b/scripts/qemugdb/tcg.py
@@ -0,0 +1,46 @@ 
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+#
+# GDB debugging support, TCG status
+#
+# Copyright 2016 Linaro Ltd
+#
+# Authors:
+#  Alex Bennée <alex.bennee@linaro.org>
+#
+# This work is licensed under the terms of the GNU GPL, version 2.  See
+# the COPYING file in the top-level directory.
+#
+# Contributions after 2012-01-13 are licensed under the terms of the
+# GNU GPL, version 2 or (at your option) any later version.
+
+# 'qemu tcg-lock-status' -- display the TCG lock status across threads
+
+import gdb
+
+class TCGLockStatusCommand(gdb.Command):
+    '''Display TCG Execution Status'''
+    def __init__(self):
+        gdb.Command.__init__(self, 'qemu tcg-lock-status', gdb.COMMAND_DATA,
+                             gdb.COMPLETE_NONE)
+
+    def invoke(self, arg, from_tty):
+        gdb.write("Thread, BQL (iothread_mutex), Replay, Blocked?\n")
+        for thread in gdb.inferiors()[0].threads():
+            thread.switch()
+
+            iothread = gdb.parse_and_eval("iothread_locked")
+            replay = gdb.parse_and_eval("replay_locked")
+
+            frame = gdb.selected_frame()
+            if frame.name() == "__lll_lock_wait":
+                frame.older().select()
+                mutex = gdb.parse_and_eval("mutex")
+                owner = gdb.parse_and_eval("mutex->__data.__owner")
+                blocked = ("__lll_lock_wait waiting on %s from %d" %
+                           (mutex, owner))
+            else:
+                blocked = "not blocked"
+
+            gdb.write("%d/%d, %s, %s, %s\n" % (thread.num, thread.ptid[1],
+                                               iothread, replay, blocked))