mbox series

[Xen-devel,v3,00/15] xen/x86: Clean-up the PoD code

Message ID 20171002125941.11274-1-julien.grall@arm.com
Headers show
Series xen/x86: Clean-up the PoD code | expand

Message

Julien Grall Oct. 2, 2017, 12:59 p.m. UTC
Hi all,

I have been attempting to use the PoD code on Arm (it will be sent in a
separate series) and spent sometimes to clean-up and switch to typesafe gfn
the current code.

The PoD code has been tested on Arm (the version is slightly different,
mostly renaming) and the x86 part has only been built test it.

Cheers,

Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>
Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: Tamas K Lengyel <tamas@tklengyel.com>

Julien Grall (15):
  xen/x86: p2m-pod: Clean-up includes
  xen/x86: p2m-pod: Remove trailing whitespaces
  xen/x86: p2m-pod: Fix coding style for comments
  xen/x86: p2m-pod: Fix coding style
  xen/x86: p2m-pod: Avoid redundant assignments in
    p2m_pod_demand_populate
  xen/x86: p2m-pod: Clean-up use of typesafe MFN
  xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_decrease_reservation
  xen/x86: p2m: Use typesafe gfn for the P2M callbacks get_entry and
    set_entry
  xen/x86: p2m: Use typesafe GFN in p2m_set_entry
  xen/x86: p2m-pod: Use typesafe GFN in pod_eager_record
  xen/x86: p2m-pod: Clean-up p2m_pod_zero_check
  xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_zero_check
  xen/x86: p2m-pod: Use typesafe gfn in p2m_pod_demand_populate
  xen/x86: p2m-pod: Use typesafe gfn for the fields reclaim_single and
    max_guest
  xen/x86: p2m-pod: Rework prototype of p2m_pod_demand_populate

 xen/arch/arm/p2m.c               |   3 +-
 xen/arch/x86/hvm/hvm.c           |   2 +-
 xen/arch/x86/mm/hap/nested_hap.c |   2 +-
 xen/arch/x86/mm/mem_access.c     |  19 +-
 xen/arch/x86/mm/mem_sharing.c    |   7 +-
 xen/arch/x86/mm/p2m-ept.c        |  11 +-
 xen/arch/x86/mm/p2m-pod.c        | 435 +++++++++++++++++++++------------------
 xen/arch/x86/mm/p2m-pt.c         |  12 +-
 xen/arch/x86/mm/p2m.c            | 139 +++++++------
 xen/common/memory.c              |   3 +-
 xen/include/asm-arm/p2m.h        |  13 --
 xen/include/asm-x86/p2m.h        |  23 +--
 xen/include/xen/p2m-common.h     |  13 ++
 13 files changed, 370 insertions(+), 312 deletions(-)

Comments

George Dunlap Oct. 2, 2017, 4:30 p.m. UTC | #1
On 10/02/2017 01:59 PM, Julien Grall wrote:
> Hi all,
> 
> I have been attempting to use the PoD code on Arm (it will be sent in a
> separate series) and spent sometimes to clean-up and switch to typesafe gfn
> the current code.
> 
> The PoD code has been tested on Arm (the version is slightly different,
> mostly renaming) and the x86 part has only been built test it.

At the end of this series there are still an awful lot of duplicate
"gfn_l" and "gfn" variables in p2m.c.  Are you planning on working to
remove them in the future?

 -George
Julien Grall Oct. 2, 2017, 5:23 p.m. UTC | #2
Hi George,

On 10/02/2017 05:30 PM, George Dunlap wrote:
> On 10/02/2017 01:59 PM, Julien Grall wrote:
>> Hi all,
>>
>> I have been attempting to use the PoD code on Arm (it will be sent in a
>> separate series) and spent sometimes to clean-up and switch to typesafe gfn
>> the current code.
>>
>> The PoD code has been tested on Arm (the version is slightly different,
>> mostly renaming) and the x86 part has only been built test it.
> 
> At the end of this series there are still an awful lot of duplicate
> "gfn_l" and "gfn" variables in p2m.c.  Are you planning on working to
> remove them in the future?

It is not in my plan for now. I was mostly doing to get some prototypes 
inline with the Arm code (more prototype are using typesafe), and I was 
hoping someone could step up to push further down the unboxing.

Cheers,