From patchwork Tue Mar 25 16:55:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27061 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 49EBD20A25 for ; Tue, 25 Mar 2014 16:57:46 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id n16sf2890046oag.5 for ; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=wLt7JEfjZ3evj38mxyN9iioBJQE8tOG14J2ZI4BiUFo=; b=iftdQkKJETQ7XQFowDkmw/Jg5onLh3xTz7Sii3lXD3AvP99XSKu+3Qaai/9fJA6+tF LGb+XidQteYdt5WAGxuusbAxzCT65i9m0LUUAgL4X3d9+1jSpClvOihBaDdtPIwNkfNY pKkJ6yagtBarguVs1PKSL2hhRa4paK0O+L3M9YppyaIau6kl6tJZ9dlGgVIsuPOVEIfy 6wddzPqRKnvJGnKy3e0j9efHvg5SdO3K5islcHoEVHWgjCGd4AgVzEMDBpb6ThQCDof8 dXZZSf9k3WCy6ajlj7s7HnMeUl5svDgZWBJOIszG6ftub2mutAoue+sz/m5eIXbllcoA TxYQ== X-Gm-Message-State: ALoCoQlxsFMX2kmG/s7/ur7wXj65p/MKpXfn21G4qXxhJzA1MFnow9vBQyaoVWRjE3v24nYQXpjN X-Received: by 10.42.230.79 with SMTP id jl15mr24909480icb.7.1395766665835; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.43.134 with SMTP id e6ls166722qga.17.gmail; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) X-Received: by 10.58.161.101 with SMTP id xr5mr901949veb.36.1395766665749; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id pe7si3865044vec.47.2014.03.25.09.57.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 09:57:45 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id oy12so875542veb.18 for ; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) X-Received: by 10.58.57.42 with SMTP id f10mr56566114veq.1.1395766665661; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp320353vck; Tue, 25 Mar 2014 09:57:45 -0700 (PDT) X-Received: by 10.52.65.132 with SMTP id x4mr986198vds.36.1395766664463; Tue, 25 Mar 2014 09:57:44 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id sq9si3948896vdc.215.2014.03.25.09.57.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 25 Mar 2014 09:57:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSUeG-00009I-3D; Tue, 25 Mar 2014 16:56:24 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSUeF-00005f-10 for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 16:56:23 +0000 Received: from [85.158.137.68:27201] by server-2.bemta-3.messagelabs.com id 29/55-23530-435B1335; Tue, 25 Mar 2014 16:56:20 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-13.tower-31.messagelabs.com!1395766570!2910862!1 X-Originating-IP: [74.125.83.49] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17790 invoked from network); 25 Mar 2014 16:56:10 -0000 Received: from mail-ee0-f49.google.com (HELO mail-ee0-f49.google.com) (74.125.83.49) by server-13.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 25 Mar 2014 16:56:10 -0000 Received: by mail-ee0-f49.google.com with SMTP id c41so685351eek.36 for ; Tue, 25 Mar 2014 09:56:10 -0700 (PDT) X-Received: by 10.15.49.65 with SMTP id i41mr2563505eew.87.1395766570405; Tue, 25 Mar 2014 09:56:10 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id h47sm33377501eey.13.2014.03.25.09.56.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Mar 2014 09:56:09 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 25 Mar 2014 16:55:18 +0000 Message-Id: <1395766541-23979-12-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH 11/34] xen/arm: Introduce __builtin_stack_pointer X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Clang doesn't support named register. Introduce __builtin_stack_pointer to be able to use named register with gcc. In file included from arm32/asm-offsets.c:10: In file included from xen/xen/include/xen/sched.h:18: In file included from xen/xen/include/xen/smp.h:4: In file included from xen/xen/include/asm/smp.h:8: xen/xen/include/asm/current.h:31:33: error: variable 'sp' is uninitialized when used here [-Werror,-Wuninitialized] return (struct cpu_info *)((sp & ~(STACK_SIZE - 1)) + STACK_SIZE - sizeof(struct cpu_info)); ^~ xen/xen/include/asm/current.h:30:30: note: initialize the variable 'sp' to silence this warning register unsigned long sp asm ("sp"); ^ = 0 Signed-off-by: Julien Grall Cc: Ian Campbell Cc: Stefano Stabellini Cc: Tim Deegan --- xen/include/asm-arm/current.h | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/xen/include/asm-arm/current.h b/xen/include/asm-arm/current.h index 65c0cdf..0d4a8c0 100644 --- a/xen/include/asm-arm/current.h +++ b/xen/include/asm-arm/current.h @@ -25,10 +25,23 @@ struct cpu_info { unsigned int pad; }; +#ifdef __clang__ +#define __builtin_stack_pointer() ({ \ + unsigned long current_sp; \ + asm ("mov %0, sp" : "=r" (current_sp)); \ + current_sp; \ +}) +#else +#define __builtin_stack_pointer() ({ \ + register unsigned long current_sp asm ("sp"); \ + current_sp; \ +}) +#endif + static inline struct cpu_info *get_cpu_info(void) { - register unsigned long sp asm ("sp"); - return (struct cpu_info *)((sp & ~(STACK_SIZE - 1)) + STACK_SIZE - sizeof(struct cpu_info)); + return (struct cpu_info *)((__builtin_stack_pointer() & ~(STACK_SIZE - 1)) + + STACK_SIZE - sizeof(struct cpu_info)); } #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs)