From patchwork Tue Mar 25 16:55:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27074 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CE5D420539 for ; Tue, 25 Mar 2014 16:58:52 +0000 (UTC) Received: by mail-pa0-f72.google.com with SMTP id bj1sf1804653pad.11 for ; Tue, 25 Mar 2014 09:58:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=BuaEb3pD1QTOTZFOUO5PhrPDetyIAMGBvyUJXECZ/Zw=; b=cDfEG8+OrWYDQktrmIaV3XJMMZ38xdJPxjsDhVDxXQmDKSPztSe0dkIna0TbF/+I/k g/2+dQNFmzoUK+/D6brpRS975VxZPJD9C0G+AElhDbJjLpmBoqxhQMFumxqjprBmZWO5 B1KUMDYEnfVkX6E0sM7OhCy95oK83k4lQ7DJGbtPuRpOqhhqppD7FqrnEvysnxhtI9WC PRhpetqLKFEbpu6KgIOJgtQaAupT/X2WkQEyNgA7qKZULz+B5sDWAWj8CRsaYQygFs4F q8S+AGgJAwDLy5MzoWJfJ8ylZ+PSoChKCYTHs/1CqSzzQC41aQuQIkqiT4SID/1Yunje gvSw== X-Gm-Message-State: ALoCoQmMNjUKyYE6rPNtphdN4BmKtznQIZXV6p4M8R5PhmNtDv/z5UKe4jnTsdwq5t4T4lBz6s1Z X-Received: by 10.68.230.193 with SMTP id ta1mr29203643pbc.6.1395766732042; Tue, 25 Mar 2014 09:58:52 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.36.45 with SMTP id o42ls305294qgo.7.gmail; Tue, 25 Mar 2014 09:58:51 -0700 (PDT) X-Received: by 10.220.249.6 with SMTP id mi6mr846648vcb.33.1395766731944; Tue, 25 Mar 2014 09:58:51 -0700 (PDT) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx.google.com with ESMTPS id 2si3818704vcd.95.2014.03.25.09.58.51 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 09:58:51 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.182; Received: by mail-vc0-f182.google.com with SMTP id ks9so933169vcb.27 for ; Tue, 25 Mar 2014 09:58:51 -0700 (PDT) X-Received: by 10.52.243.167 with SMTP id wz7mr423450vdc.47.1395766731873; Tue, 25 Mar 2014 09:58:51 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp320443vck; Tue, 25 Mar 2014 09:58:51 -0700 (PDT) X-Received: by 10.224.131.67 with SMTP id w3mr16113010qas.32.1395766731265; Tue, 25 Mar 2014 09:58:51 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id n3si8765562qga.22.2014.03.25.09.58.50 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 25 Mar 2014 09:58:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSUeq-000177-V6; Tue, 25 Mar 2014 16:57:00 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSUen-0000zV-RC for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 16:56:58 +0000 Received: from [85.158.143.35:9955] by server-1.bemta-4.messagelabs.com id CE/EF-09853-955B1335; Tue, 25 Mar 2014 16:56:57 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-15.tower-21.messagelabs.com!1395766616!3925227!1 X-Originating-IP: [74.125.83.52] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 32447 invoked from network); 25 Mar 2014 16:56:56 -0000 Received: from mail-ee0-f52.google.com (HELO mail-ee0-f52.google.com) (74.125.83.52) by server-15.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 25 Mar 2014 16:56:56 -0000 Received: by mail-ee0-f52.google.com with SMTP id e49so687472eek.11 for ; Tue, 25 Mar 2014 09:56:56 -0700 (PDT) X-Received: by 10.15.44.3 with SMTP id y3mr3885478eev.58.1395766615945; Tue, 25 Mar 2014 09:56:55 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id h47sm33377501eey.13.2014.03.25.09.56.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Mar 2014 09:56:54 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 25 Mar 2014 16:55:39 +0000 Message-Id: <1395766541-23979-33-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> Cc: ian.campbell@citrix.com, Stefano Stabellini , tim@xen.org, Julien Grall , Ian Jackson , stefano.stabellini@citrix.com Subject: [Xen-devel] [PATCH 32/34] tools/libxl: list_domains: shutdown is typed unsigned X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Don't need to check if shutdown is positive. Fix compilation with clang 3.5: xl_cmdimpl.c:3350:34: error: comparison of unsigned expression >= 0 is always true [-Werror,-Wtautological-compare] (shutdown_reason >= 0 && ~~~~~~~~~~~~~~~ ^ ~ Signed-off-by: Julien Grall Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Acked-by: Ian Campbell --- tools/libxl/xl_cmdimpl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 8389468..e82620d 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -3324,8 +3324,7 @@ static void list_domains(int verbose, int context, int claim, int numa, info[i].blocked ? 'b' : '-', info[i].paused ? 'p' : '-', info[i].shutdown ? 's' : '-', - (shutdown_reason >= 0 && - shutdown_reason < sizeof(shutdown_reason_letters)-1 + (shutdown_reason < sizeof(shutdown_reason_letters)-1 ? shutdown_reason_letters[shutdown_reason] : '?'), info[i].dying ? 'd' : '-', ((float)info[i].cpu_time / 1e9));