From patchwork Mon Jun 16 16:17:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 31990 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A8CD920E7A for ; Mon, 16 Jun 2014 16:20:11 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id j17sf33729704oag.0 for ; Mon, 16 Jun 2014 09:20:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=Iike5MCSNfl9XM4PD6jFQ8Qwd1ShOU4LYU7pAtBxHLs=; b=YR/XltRc4CTQaL19rc23rLxf3MRO6NsEd4QvxbLMJ3LwoRZ0HWI0h4zTnNRkEcXV60 hcsb0TSUooVruRo0Qk42+G0JjybQCtApa3xNaCT8EZrAvSDxuJsqVDmyq/yqnVVw15fA Ka8knUxidGiahSGPhQ9ggaUNn/7hYsqDBc+kF5SiEEZ/OPoRf1g2XpW7NZ25ty1ujkM+ m5ZDVImsHSgbEYdRsujumJ7pY2+NsYeUHr/AxIe6/AZNB4dns6L3OTcw2R5nt+9Fixpi IO1CQwxgvLzRLMf3Cy1qHNDxh5sOGskz2/pQ2jhPAhsJ18GBlCMwsIzFW6++73Vw7D12 6XcQ== X-Gm-Message-State: ALoCoQmwmrbKbX4TxcTfzXgsaTp7OmobNt0LTav7N9jDuctTPOyi+R855RpPVtH/TdjFUljY7Itr X-Received: by 10.42.85.142 with SMTP id q14mr1013474icl.16.1402935611347; Mon, 16 Jun 2014 09:20:11 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.26.183 with SMTP id 52ls4414641qgv.15.gmail; Mon, 16 Jun 2014 09:20:11 -0700 (PDT) X-Received: by 10.58.133.6 with SMTP id oy6mr5635731veb.25.1402935611250; Mon, 16 Jun 2014 09:20:11 -0700 (PDT) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id cd10si4286252vcb.54.2014.06.16.09.20.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 16 Jun 2014 09:20:11 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id jz11so6282616veb.17 for ; Mon, 16 Jun 2014 09:20:11 -0700 (PDT) X-Received: by 10.58.195.234 with SMTP id ih10mr1672310vec.41.1402935611172; Mon, 16 Jun 2014 09:20:11 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp146186vcb; Mon, 16 Jun 2014 09:20:10 -0700 (PDT) X-Received: by 10.52.164.70 with SMTP id yo6mr748734vdb.67.1402935609486; Mon, 16 Jun 2014 09:20:09 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id s5si4291722vcu.2.2014.06.16.09.20.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 16 Jun 2014 09:20:09 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwZbv-0006hI-Ei; Mon, 16 Jun 2014 16:18:19 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwZbt-0006h1-EL for xen-devel@lists.xenproject.org; Mon, 16 Jun 2014 16:18:17 +0000 Received: from [193.109.254.147:25643] by server-10.bemta-14.messagelabs.com id 34/7B-04546-8C81F935; Mon, 16 Jun 2014 16:18:16 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-14.tower-27.messagelabs.com!1402935495!11597455!1 X-Originating-IP: [74.125.82.44] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4125 invoked from network); 16 Jun 2014 16:18:15 -0000 Received: from mail-wg0-f44.google.com (HELO mail-wg0-f44.google.com) (74.125.82.44) by server-14.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 16 Jun 2014 16:18:15 -0000 Received: by mail-wg0-f44.google.com with SMTP id x13so5877540wgg.27 for ; Mon, 16 Jun 2014 09:18:15 -0700 (PDT) X-Received: by 10.194.63.46 with SMTP id d14mr30195324wjs.24.1402935495437; Mon, 16 Jun 2014 09:18:15 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id l45sm34836161eep.25.2014.06.16.09.18.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Jun 2014 09:18:14 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 16 Jun 2014 17:17:48 +0100 Message-Id: <1402935486-29136-2-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> References: <1402935486-29136-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [RFC 01/19] xen/arm: guest_physmap_remove_page: Print a warning if we fail to unmap the page X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.172 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: The function guest_physmap_remove_page does't have a return value. With the change "arch/arm: add consistency check to REMOVE p2m changes", apply_p2m_changes can unlikely fail. Warn the user in this case. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- xen/arch/arm/p2m.c | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index f93f99a..51f9225 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -607,10 +607,16 @@ void guest_physmap_remove_page(struct domain *d, unsigned long gpfn, unsigned long mfn, unsigned int page_order) { - apply_p2m_changes(d, REMOVE, - pfn_to_paddr(gpfn), - pfn_to_paddr(gpfn + (1<domain_id, gpfn, gpfn + (1 << page_order), mfn); } int p2m_alloc_table(struct domain *d)