From patchwork Fri Sep 5 10:09:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: wangyijing X-Patchwork-Id: 36805 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oi0-f72.google.com (mail-oi0-f72.google.com [209.85.218.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 49CBB202E4 for ; Fri, 5 Sep 2014 09:55:01 +0000 (UTC) Received: by mail-oi0-f72.google.com with SMTP id a3sf3433010oib.7 for ; Fri, 05 Sep 2014 02:55:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=7tz6guhtSVI/hJtHJAt8HjGfFlk1sV6vQ0dtGzrhP6A=; b=Sj1y+AGvljbgesM81KXII8UaFe7mxjGt6wAFO1T2R7aektp0SlXiqGxtWUe4436mF6 FHb5RT84uSlLtv+V+g51NCd/Iz8Dp/w/shuq6iPlFa6Y03eetaD/2+KsTnMr46Avnfe5 3snY3U6iCaFv1wC4tgC8ZkOUsJ8QmQF1fMMEDf7CqmDitsnMxgw9O7H4P1hjUQ+usIfw usqdPxXki1Wan7n3KqZCzInyxBMqJmKVUVppt/C4inXI+05AiR55O161OHKhGbq3VBG/ AYITKY8j3cbANSQ7z5HtE2OzA0fovnUUDSAyXp5SfGLn71pJeS/zSy6mYXv0uNa2SMkK j3Dg== X-Gm-Message-State: ALoCoQls6z8vQRhP9u+Q4a1tmz3pPEb+ucOTuIRJK4Gv8IhCR9yNkuXvUIVXjotDweAgR73C1qT3 X-Received: by 10.182.18.8 with SMTP id s8mr5835983obd.21.1409910900926; Fri, 05 Sep 2014 02:55:00 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.117 with SMTP id k108ls653190qgf.3.gmail; Fri, 05 Sep 2014 02:55:00 -0700 (PDT) X-Received: by 10.220.247.3 with SMTP id ma3mr9237292vcb.29.1409910900857; Fri, 05 Sep 2014 02:55:00 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id lh7si814348vdb.98.2014.09.05.02.55.00 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Sep 2014 02:55:00 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id im17so11991943vcb.4 for ; Fri, 05 Sep 2014 02:55:00 -0700 (PDT) X-Received: by 10.221.6.201 with SMTP id ol9mr9418361vcb.2.1409910900760; Fri, 05 Sep 2014 02:55:00 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp57258vcb; Fri, 5 Sep 2014 02:55:00 -0700 (PDT) X-Received: by 10.224.5.1 with SMTP id 1mr16794577qat.30.1409910899391; Fri, 05 Sep 2014 02:54:59 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id a7si904411qam.51.2014.09.05.02.54.59 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 05 Sep 2014 02:54:59 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XPqD0-0007GL-4c; Fri, 05 Sep 2014 09:53:34 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XPqCx-0007DE-Tw for xen-devel@lists.xenproject.org; Fri, 05 Sep 2014 09:53:32 +0000 Received: from [85.158.137.68:11269] by server-9.bemta-3.messagelabs.com id 21/A0-30790-B1889045; Fri, 05 Sep 2014 09:53:31 +0000 X-Env-Sender: wangyijing@huawei.com X-Msg-Ref: server-7.tower-31.messagelabs.com!1409910806!12671953!1 X-Originating-IP: [119.145.14.65] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTE5LjE0NS4xNC42NSA9PiA3NzQ2Mw==\n X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17810 invoked from network); 5 Sep 2014 09:53:30 -0000 Received: from szxga02-in.huawei.com (HELO szxga02-in.huawei.com) (119.145.14.65) by server-7.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 5 Sep 2014 09:53:30 -0000 Received: from 172.24.2.119 (EHLO szxeml419-hub.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id BZB92846; Fri, 05 Sep 2014 17:46:00 +0800 (CST) Received: from localhost.localdomain (10.175.100.166) by szxeml419-hub.china.huawei.com (10.82.67.158) with Microsoft SMTP Server id 14.3.158.1; Fri, 5 Sep 2014 17:45:46 +0800 From: Yijing Wang To: Bjorn Helgaas Date: Fri, 5 Sep 2014 18:09:57 +0800 Message-ID: <1409911806-10519-13-git-send-email-wangyijing@huawei.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.166] X-CFilter-Loop: Reflected Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Bharat.Bhushan@freescale.com, Yijing Wang , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Chris Metcalf , Yijing Wang , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Xinwei Hu , Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Subject: [Xen-devel] [PATCH v1 12/21] MIPS/Xlp: Remove the dead function destroy_irq() to fix build error X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: wangyijing@huawei.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Commit 465665f78a7 ("mips: Kill pointless destroy_irq()") removed the destroy_irq(). So remove the leftover one in xlp_setup_msix() to fix build error. arch/mips/pci/msi-xlp.c: In function 'xlp_setup_msix': arch/mips/pci/msi-xlp.c:447:3: error: implicit declaration of function 'destroy_irq'.. cc1: some warnings being treated as errors make[1]: *** [arch/mips/pci/msi-xlp.o] Error 1 make: *** [arch/mips/pci/] Error 2 Signed-off-by: Yijing Wang Cc: Thomas Gleixner --- arch/mips/pci/msi-xlp.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/arch/mips/pci/msi-xlp.c b/arch/mips/pci/msi-xlp.c index fa374fe..e469dc7 100644 --- a/arch/mips/pci/msi-xlp.c +++ b/arch/mips/pci/msi-xlp.c @@ -443,10 +443,8 @@ static int xlp_setup_msix(uint64_t lnkbase, int node, int link, msg.data = 0xc00 | msixvec; ret = irq_set_msi_desc(xirq, desc); - if (ret < 0) { - destroy_irq(xirq); + if (ret < 0) return ret; - } write_msi_msg(xirq, &msg); return 0;