From patchwork Thu Nov 20 17:36:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 41256 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C0973241C9 for ; Thu, 20 Nov 2014 17:38:22 +0000 (UTC) Received: by mail-lb0-f198.google.com with SMTP id p9sf1237154lbv.5 for ; Thu, 20 Nov 2014 09:38:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-post:list-help :list-subscribe:mime-version:content-type:content-transfer-encoding :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=kq+yzyfOK1PLODJBfBjp/hFnrDqgF5YLpYpBEkwc728=; b=geVYS3k/Ffz9MBlww/sh2nCpU4GHaS/zewvdO2n/TRHAru0Tnl6SvAt+zRbOlHdWoa CyXPAFI3IenZ8HANE8dwH5XrA0r1cT2E+4qjxZiEUci1fXCO8FFowz1dz6C3fg428KZc FJvQoAJq5Xo9SViZl6JX55rKef/RhjEXQvWOQeVOlSHQhixOjwHr/9JmPkVnfSl6hhMc RN//pvlvlQlJtplhgplwC4T2jdMcFL1gJZGwg+mWXjO9c2ZRnqWS/A5TGbPdUhIAYiW6 NSWK8o2nUCkUhiwdBEaJAWP/U8/n3GyljmLPWhbmqWxGtmr1qGjDTSNxkaxWCVUrXiwp M6kQ== X-Gm-Message-State: ALoCoQkkfwzwoc369p1kwv7dK4ghEgR0QrN3bWh5qong6TJ1sdpW1ETkxDoMsdzjzKxO+UYHmGYK X-Received: by 10.112.204.71 with SMTP id kw7mr2952244lbc.13.1416505101678; Thu, 20 Nov 2014 09:38:21 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.29.5 with SMTP id f5ls94154lah.62.gmail; Thu, 20 Nov 2014 09:38:21 -0800 (PST) X-Received: by 10.112.159.129 with SMTP id xc1mr49766968lbb.24.1416505101523; Thu, 20 Nov 2014 09:38:21 -0800 (PST) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id i7si2655848lbs.116.2014.11.20.09.38.21 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Nov 2014 09:38:21 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by mail-la0-f43.google.com with SMTP id q1so2832519lam.2 for ; Thu, 20 Nov 2014 09:38:21 -0800 (PST) X-Received: by 10.112.62.166 with SMTP id z6mr4121168lbr.74.1416505101407; Thu, 20 Nov 2014 09:38:21 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp305023lbc; Thu, 20 Nov 2014 09:38:20 -0800 (PST) X-Received: by 10.220.178.134 with SMTP id bm6mr2461518vcb.56.1416505100036; Thu, 20 Nov 2014 09:38:20 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id sh5si1177928vcb.12.2014.11.20.09.38.19 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 20 Nov 2014 09:38:20 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XrVeM-0004nc-KS; Thu, 20 Nov 2014 17:36:10 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XrVeL-0004nX-DT for xen-devel@lists.xenproject.org; Thu, 20 Nov 2014 17:36:09 +0000 Received: from [193.109.254.147] by server-11.bemta-14.messagelabs.com id E7/5D-02696-8862E645; Thu, 20 Nov 2014 17:36:08 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-5.tower-27.messagelabs.com!1416504967!9187177!1 X-Originating-IP: [74.125.82.47] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.12.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 9303 invoked from network); 20 Nov 2014 17:36:08 -0000 Received: from mail-wg0-f47.google.com (HELO mail-wg0-f47.google.com) (74.125.82.47) by server-5.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 20 Nov 2014 17:36:08 -0000 Received: by mail-wg0-f47.google.com with SMTP id n12so4390060wgh.20 for ; Thu, 20 Nov 2014 09:36:07 -0800 (PST) X-Received: by 10.180.77.79 with SMTP id q15mr72183wiw.8.1416504967653; Thu, 20 Nov 2014 09:36:07 -0800 (PST) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id ry19sm4332037wjb.3.2014.11.20.09.36.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Nov 2014 09:36:06 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 20 Nov 2014 17:36:03 +0000 Message-Id: <1416504963-4830-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 Cc: Julien Grall , ian.jackson@eu.citrix.com, ian.campbell@citrix.com, Don Slutz Subject: [Xen-devel] [PATCH v2 for 4.5] scripts/get_maintainer.pl: Correctly CC the maintainers X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: The current script is setting $email_remove_duplicates to 1 by default, on complex patch (see [1]), this will result to ommitting randomly some maintainers. This is because, the script will: 1) Get the list of maintainers of the file (incidentally all the maintainers in "THE REST" role are added). If the email address already exists in the global list, skip it. => The role will be lost 2) Filter the list to remove the entry with "THE REST" role So if a maintainers is marked with "THE REST" role on the first file and actually be an x86 maintainers on the script, the script will only retain the "THE REST" role. During the filtering step, this maintainers will therefore be dropped. This patch fixes this by setting $email_remove_duplicates to 0 by default. The new behavior of the script will be: 1) Append the list of maintainers for every file 2) Filter the list to remove the entry with "THE REST" role 3) Remove duplicated email address Example: Patch: https://patches.linaro.org/41083/ Before the patch: Daniel De Graaf Ian Jackson Stefano Stabellini Ian Campbell Wei Liu George Dunlap xen-devel@lists.xen.org After the patch: Daniel De Graaf Ian Jackson Stefano Stabellini Ian Campbell Wei Liu Stefano Stabellini Tim Deegan Keir Fraser Jan Beulich George Dunlap xen-devel@lists.xen.org [1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html Signed-off-by: Julien Grall CC: Don Slutz --- Changes in v2: - Rework the commit message to explain the problem and the solution more clearly I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first time the script has been introduced). Developpers using this script won't ommitted to cc some maintainers, and it will avoid maintainers complaining about miss CC. The only drawbacks I can see is if the maintainers is referenced twice in the file MAINTAINERS with different email, the script won't notice it's duplicated and list 2 times. Though, for this one it could be fixed by modifying the MAINTAINERS file. Is it worth for Xen 4.5? For know, it seems to only happen with Stefano. --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index df920e2..cc445cd 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -35,7 +35,7 @@ my $email_git_min_percent = 5; my $email_git_since = "1-year-ago"; my $email_hg_since = "-365"; my $interactive = 0; -my $email_remove_duplicates = 1; +my $email_remove_duplicates = 0; my $email_use_mailmap = 1; my $email_drop_the_rest_supporter_if_supporter_found = 1; my $output_multiline = 1;