From patchwork Thu Jan 29 18:25:42 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 43966 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 80EC424128 for ; Thu, 29 Jan 2015 18:28:24 +0000 (UTC) Received: by mail-lb0-f197.google.com with SMTP id b6sf23092644lbj.0 for ; Thu, 29 Jan 2015 10:28:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=k7qFdT3M/dArQaVgnKMC3d1n7Qb6+6fhSvIzcDnF+RE=; b=Ov5ZHYvZCCAV9iI2tyD/V6+E34R3xMjBgClSfAbD/hYO7E4Ye1q4MGZBnbg6m1AwiZ VJ/llW2F6I0xY9zjbyYQc1S/uO7mZaTsHzgOJ6w6tt+dqkNfVamqPmdZDRMhYq0mXUPp ifrXtl040EKaftimhva3roKIBB8h5/vO9UuAtj4WcmtPAx6Vsu5nG05gj1ctwxf8Vshs /8soRIxsRzwBsGM9b1Lyi0Kj/f4rG0GXHbMMZuA0R8h2anYzVFRQcRVWdnLM5gt09qu/ mHY47zgPxorZEWfX1v9GK9eePHAwe5aClvfIdcBon8QkiSorBlfrR3ucRJLS6e5jgT4V H2vg== X-Gm-Message-State: ALoCoQmBVGhRPkqcQKCSRmg0DuTPBpu9eS0Qakw+YG8ar8d0k2+Qu1fQfzn3ApWgLXdQxkky6e7i X-Received: by 10.152.219.136 with SMTP id po8mr312753lac.4.1422556103553; Thu, 29 Jan 2015 10:28:23 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.204.2 with SMTP id ku2ls309207lac.64.gmail; Thu, 29 Jan 2015 10:28:23 -0800 (PST) X-Received: by 10.152.234.69 with SMTP id uc5mr2633462lac.16.1422556103202; Thu, 29 Jan 2015 10:28:23 -0800 (PST) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com. [209.85.217.171]) by mx.google.com with ESMTPS id uh1si5099235lac.123.2015.01.29.10.28.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 29 Jan 2015 10:28:23 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) client-ip=209.85.217.171; Received: by mail-lb0-f171.google.com with SMTP id u14so31127567lbd.2 for ; Thu, 29 Jan 2015 10:28:23 -0800 (PST) X-Received: by 10.152.197.5 with SMTP id iq5mr2682788lac.6.1422556102996; Thu, 29 Jan 2015 10:28:22 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp34282lbj; Thu, 29 Jan 2015 10:28:22 -0800 (PST) X-Received: by 10.152.5.72 with SMTP id q8mr2432259laq.57.1422556097689; Thu, 29 Jan 2015 10:28:17 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id x9si16332827wje.31.2015.01.29.10.28.16 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 29 Jan 2015 10:28:17 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGtnn-0004eM-3D; Thu, 29 Jan 2015 18:26:51 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YGtnk-0004cq-Lh for xen-devel@lists.xenproject.org; Thu, 29 Jan 2015 18:26:49 +0000 Received: from [85.158.143.35] by server-3.bemta-4.messagelabs.com id 31/7C-02754-86B7AC45; Thu, 29 Jan 2015 18:26:48 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-6.tower-21.messagelabs.com!1422556007!13276796!1 X-Originating-IP: [209.85.212.173] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 6.12.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 16587 invoked from network); 29 Jan 2015 18:26:47 -0000 Received: from mail-wi0-f173.google.com (HELO mail-wi0-f173.google.com) (209.85.212.173) by server-6.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 29 Jan 2015 18:26:47 -0000 Received: by mail-wi0-f173.google.com with SMTP id r20so30238370wiv.0 for ; Thu, 29 Jan 2015 10:26:47 -0800 (PST) X-Received: by 10.194.24.68 with SMTP id s4mr3779768wjf.98.1422556007102; Thu, 29 Jan 2015 10:26:47 -0800 (PST) Received: from chilopoda.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id x18sm3518503wia.12.2015.01.29.10.26.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 29 Jan 2015 10:26:45 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 29 Jan 2015 18:25:42 +0000 Message-Id: <1422555950-31821-8-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1422555950-31821-1-git-send-email-julien.grall@linaro.org> References: <1422555950-31821-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Vijaya.Kumar@caviumnetworks.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v2 07/15] xen/arm: vgic-v3: Use a struct to describe contiguous rdist regions X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Also update the different comment to make clear that we register one MMIO region per contiguous regions and not per re-distributor. Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/arch/arm/gic-v3.c | 20 ++++++++++---------- xen/arch/arm/vgic-v3.c | 11 ++++++----- xen/include/asm-arm/domain.h | 11 +++++++---- 3 files changed, 23 insertions(+), 19 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 7b33ff7..fdfda0b 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -909,10 +909,10 @@ static int gicv_v3_init(struct domain *d) for ( i = 0; i < gicv3.rdist_count; i++ ) { - d->arch.vgic.rbase[i] = gicv3.rdist_regions[i].base; - d->arch.vgic.rbase_size[i] = gicv3.rdist_regions[i].size; + d->arch.vgic.rdist_regions[i].base = gicv3.rdist_regions[i].base; + d->arch.vgic.rdist_regions[i].size = gicv3.rdist_regions[i].size; } - d->arch.vgic.rdist_count = gicv3.rdist_count; + d->arch.vgic.nr_regions = gicv3.rdist_count; } else { @@ -922,13 +922,13 @@ static int gicv_v3_init(struct domain *d) /* XXX: Only one Re-distributor region mapped for the guest */ BUILD_BUG_ON(GUEST_GICV3_RDIST_REGIONS != 1); - d->arch.vgic.rdist_count = GUEST_GICV3_RDIST_REGIONS; + d->arch.vgic.nr_regions = GUEST_GICV3_RDIST_REGIONS; d->arch.vgic.rdist_stride = GUEST_GICV3_RDIST_STRIDE; /* The first redistributor should contain enough space for all CPUs */ BUILD_BUG_ON((GUEST_GICV3_GICR0_SIZE / GUEST_GICV3_RDIST_STRIDE) < MAX_VIRT_CPUS); - d->arch.vgic.rbase[0] = GUEST_GICV3_GICR0_BASE; - d->arch.vgic.rbase_size[0] = GUEST_GICV3_GICR0_SIZE; + d->arch.vgic.rdist_regions[0].base = GUEST_GICV3_GICR0_BASE; + d->arch.vgic.rdist_regions[0].size = GUEST_GICV3_GICR0_SIZE; } return 0; @@ -1107,7 +1107,7 @@ static int gicv3_make_dt_node(const struct domain *d, * CPU interface and virtual cpu interfaces accessesed as System registers * So cells are created only for Distributor and rdist regions */ - len = len * (d->arch.vgic.rdist_count + 1); + len = len * (d->arch.vgic.nr_regions + 1); new_cells = xzalloc_bytes(len); if ( new_cells == NULL ) return -FDT_ERR_XEN(ENOMEM); @@ -1116,9 +1116,9 @@ static int gicv3_make_dt_node(const struct domain *d, dt_set_range(&tmp, node, d->arch.vgic.dbase, d->arch.vgic.dbase_size); - for ( i = 0; i < d->arch.vgic.rdist_count; i++ ) - dt_set_range(&tmp, node, d->arch.vgic.rbase[i], - d->arch.vgic.rbase_size[i]); + for ( i = 0; i < d->arch.vgic.nr_regions; i++ ) + dt_set_range(&tmp, node, d->arch.vgic.rdist_regions[i].base, + d->arch.vgic.rdist_regions[i].size); res = fdt_property(fdt, "reg", new_cells, len); xfree(new_cells); diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index db6b514..13481ac 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -1112,13 +1112,14 @@ static int vgic_v3_domain_init(struct domain *d) d->arch.vgic.dbase_size); /* - * Register mmio handler per redistributor region but not for - * every sgi rdist region which is per core. - * The redistributor region encompasses per core sgi region. + * Register mmio handler per contiguous region occupied by the + * redistributors. The handler will take care to choose which + * redistributor is targeted. */ - for ( i = 0; i < d->arch.vgic.rdist_count; i++ ) + for ( i = 0; i < d->arch.vgic.nr_regions; i++ ) register_mmio_handler(d, &vgic_rdistr_mmio_handler, - d->arch.vgic.rbase[i], d->arch.vgic.rbase_size[i]); + d->arch.vgic.rdist_regions[i].base, + d->arch.vgic.rdist_regions[i].size); d->arch.vgic.ctlr = VGICD_CTLR_DEFAULT; diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h index 9018c6a..3eaa7f0 100644 --- a/xen/include/asm-arm/domain.h +++ b/xen/include/asm-arm/domain.h @@ -102,10 +102,13 @@ struct arch_domain #ifdef CONFIG_ARM_64 /* GIC V3 addressing */ paddr_t dbase_size; /* Distributor base size */ - paddr_t rbase[MAX_RDIST_COUNT]; /* Re-Distributor base address */ - paddr_t rbase_size[MAX_RDIST_COUNT]; /* Re-Distributor size */ - uint32_t rdist_stride; /* Re-Distributor stride */ - int rdist_count; /* No. of Re-Distributors */ + /* List of contiguous occupied by the redistributors */ + struct vgic_rdist_region { + paddr_t base; /* Base address */ + paddr_t size; /* Size */ + } rdist_regions[MAX_RDIST_COUNT]; + int nr_regions; /* Number of rdist regions */ + uint32_t rdist_stride; /* Re-Distributor stride */ #endif } vgic;