From patchwork Mon Jun 19 16:57:45 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 105890 Delivered-To: patch@linaro.org Received: by 10.182.29.35 with SMTP id g3csp942411obh; Mon, 19 Jun 2017 09:59:51 -0700 (PDT) X-Received: by 10.107.33.140 with SMTP id h134mr9294593ioh.57.1497891591141; Mon, 19 Jun 2017 09:59:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1497891591; cv=none; d=google.com; s=arc-20160816; b=FDoC1yZLsVUdmevy4BU8SJjIF3irbLiitZx/LG+RBcmGKdLrq/ScY2thjENm3TlriQ d+vfPRODijLrYHpyST/muuvkR0nUHO8DDThtEVhDig6W9KYoK85Ix+CrHqRE59z7n7CB wDM8Ai9IuD1modV0u/GkZOYfo+BuhWtMFVvakhk1EU7jshw7l5bcFamWka6V6+/gVZNr DnubZ62OZfxKqrMHuq0FF9lWBvceQSSztr+k8qIQZvajr0sMELx1JsL9yterMHRg6iNU VGPqb7+CHygRoTta2B3m/FzQdOjsmE9+g3H1JvZQT/3QQkjmZL/+UH77Er31r25LwtmF MDNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:references:in-reply-to:message-id:date:to :from:arc-authentication-results; bh=qOD4e0s3zlILYDM64kk1QRdOPPrZIJvoFAdy0DZtP6Q=; b=yB6lyI4c4q894i1xZXPYnmFQp513kq14IeR2sSTwNB16RY48L9ovw9O7N9psEMUFEf OFW6Cfi+nqBv59AvK6dFQIqVdN8/8tosBEUx1qmqwI0zjmx3EnjuM3DSXvlMAS0uf7Uq WUAEUbjT2sES0fgSgEE7tNKcWm8TONEIK55SLQTTPuibq29h0qpYSdpoSaR7isVA157X Uj620Qdu5QmHp30SJ3gVfWlTectDbqVo/2ZrrVKX7qsMu3E3NWS9t//s0BRqurJCquuy +BtMWUq93wWoCn3j3U5eWRRkziRnMAy3SWEWxeIi4vKvAaeubL9Leyb9P2kgbNtxmD2X vMtA== ARC-Authentication-Results: i=1; mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id y7si7197870itd.62.2017.06.19.09.59.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Jun 2017 09:59:51 -0700 (PDT) Received-SPF: neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=neutral (google.com: 192.237.175.120 is neither permitted nor denied by best guess record for domain of xen-devel-bounces@lists.xen.org) smtp.mailfrom=xen-devel-bounces@lists.xen.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN00F-0003sA-IW; Mon, 19 Jun 2017 16:58:15 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dN00D-0003pE-VE for xen-devel@lists.xen.org; Mon, 19 Jun 2017 16:58:14 +0000 Received: from [85.158.139.211] by server-5.bemta-5.messagelabs.com id E0/B5-02183-5A208495; Mon, 19 Jun 2017 16:58:13 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRWlGSWpSXmKPExsVysyfVTXchk0e kweS56hZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8bVLr2CY1wVB3f1sTUwvuboYuTiEBLYzChx c8tdVgjnNKPEoh0rWLoYOTnYBDQl7nz+xARiiwhIS1z7fJmxi5GDg1lgHqPElkiQsLBAmMSKr 5/YQGwWAVWJW9fPgNm8ApYSp69+ZQSxJQTkJXa1XWQFsTkFrCS+z78GFhcCqjn+5BbbBEbuBY wMqxg1ilOLylKLdI3M9JKKMtMzSnITM3N0DQ1M9XJTi4sT01NzEpOK9ZLzczcxAr1bz8DAuIP x9mS/Q4ySHExKoryz/rtHCvEl5adUZiQWZ8QXleakFh9ilOHgUJLgVWX0iBQSLEpNT61Iy8wB hhlMWoKDR0mEt+Y3UCtvcUFibnFmOkTqFKOilDivAkifAEgiozQPrg0W2pcYZaWEeRkZGBiEe ApSi3IzS1DlXzGKczAqCfN2gVzGk5lXAjf9FdBiJqDFzGdcQBaXJCKkpBoYmZet/NvLf2b7sz kbX6S8C9ytFOT46IWo2VKzzx/u7NkUcMfqofS3M9KMXnckAtoW+/3vvdYwf+HJFouWwKBb3zk 3e947/vJUn/AFrc6whRNF2WKO/za+sWTzPFV/6b4Nk/VLHifEHzsxS3TK85zen52Hj+pZi28/ Mz9f4OLjO/5cz26qs6Ro2imxFGckGmoxFxUnAgAgiEr6aAIAAA== X-Env-Sender: julien.grall@arm.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1497891489!100528609!1 X-Originating-IP: [217.140.101.70] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 9.4.19; banners=-,-,- X-VirusChecked: Checked Received: (qmail 33380 invoked from network); 19 Jun 2017 16:58:09 -0000 Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by server-3.tower-206.messagelabs.com with SMTP; 19 Jun 2017 16:58:09 -0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D43E115BE; Mon, 19 Jun 2017 09:58:08 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.206.53]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA9B23F41F; Mon, 19 Jun 2017 09:58:07 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xen.org Date: Mon, 19 Jun 2017 17:57:45 +0100 Message-Id: <20170619165753.25049-9-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170619165753.25049-1-julien.grall@arm.com> References: <20170619165753.25049-1-julien.grall@arm.com> Cc: Ross Lagerwall , Julien Grall , sstabellini@kernel.org Subject: [Xen-devel] [PATCH v2 08/16] xen/arm: livepatch: Redefine virt_to_mfn to support typesafe X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" The file xen/arch/arm/livepatch.c is using typesafe MFN in most of the place. The only caller to virt_to_mfn is using with _mfn(...). To avoid extra _mfn(...), re-define virt_to_mfn within xen/arch/arm/livepatch.c to handle typesafe MFN. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini Acked-by: Konrad Rzeszutek Wilk --- Cc: Ross Lagerwall Cc: Konrad Rzeszutek Wilk Changes in v2: - Add Stefano's reviewed-by - Still missing an ack from Konrad and/or Ross. --- xen/arch/arm/livepatch.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c index de95e54744..3e53524365 100644 --- a/xen/arch/arm/livepatch.c +++ b/xen/arch/arm/livepatch.c @@ -12,6 +12,10 @@ #include #include +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef virt_to_mfn +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) + void *vmap_of_xen_text; int arch_livepatch_quiesce(void) @@ -22,7 +26,7 @@ int arch_livepatch_quiesce(void) if ( vmap_of_xen_text ) return -EINVAL; - text_mfn = _mfn(virt_to_mfn(_start)); + text_mfn = virt_to_mfn(_start); text_order = get_order_from_bytes(_end - _start); /*