From patchwork Wed Jan 24 18:26:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 125700 Delivered-To: patch@linaro.org Received: by 10.46.66.141 with SMTP id h13csp588046ljf; Wed, 24 Jan 2018 10:29:04 -0800 (PST) X-Google-Smtp-Source: AH8x224NWEIjOrvBvDTaiRJcPHoacO3CIsaWQRrZ4ZQws4TZZpUPhDL05fSzjw7QjHHxw2S9B8kQ X-Received: by 10.107.79.25 with SMTP id d25mr9036598iob.270.1516818543987; Wed, 24 Jan 2018 10:29:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1516818543; cv=none; d=google.com; s=arc-20160816; b=rTb5ARd1F41hLygzaVsGc3PqYX6u0mhrBICVMdXVElUvCMH+LUoFXGC8G/Tgj72dHV VyGWakiIWe4lRil7EXfGCVHmOrwGS8ybLZhamu57yMb8w80rK0nMoL7OKKKo8IIz1jW4 U1mx5It4/nbez79nzBQiD0M/AxUntrtAGVD/wGDFyr4jdriwngbwbINt4R4/v18Ah/y4 hkA4CqA2Yw/MmZCSvGDpcFLojqs3o/7Y+a/vh4HhBVMKUr4x30To1rM2ygGPZfxvZuNs NTXVXGfsVqt99As3Posj3ILrH9ry98vSzfQ1qAPx5l5fYr6DCVPPI015m2WENVGcQjUh TosA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:cc:references:in-reply-to:message-id:date:to :from:dkim-signature:arc-authentication-results; bh=QGjp2lmYICNFLGyh3zSXxUftoXisVeZJErsjPWhFsA4=; b=0IzxIgOwXtZ/iu7OQiFwRtWkr6PngYhoafvrJx/loMM2f53f5vdGgcz8hKdDrMuGOh otzfVSKKt9fX0+IMn7z9o+xT5z5KwXDNf3lpAQhJ21Qytud21CEaqOOCND2NnHoTpq7u ydVNRS7cRucRDB8/3BPw9KXYoj3TAGa6GYi+vPTac4fsb5Oc9hi/7tc+HgJucTKsjrxX C2N45mmYUczWHbGfgg0IKdwFosljkRlwI4G6M9DBg0Jh/nCJ6nhBIbRSOa9EcWCvFglQ x5EjsnfAhYbcus6dxDD3qgv+p8Dv8gPmQhCtsD+51felW35GtH37PddVyaW++317PBrq u9kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BZeKy8FV; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id j7si631519itj.111.2018.01.24.10.29.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 10:29:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=BZeKy8FV; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eePkf-0000Ys-F3; Wed, 24 Jan 2018 18:26:25 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eePke-0000YW-BX for xen-devel@lists.xen.org; Wed, 24 Jan 2018 18:26:24 +0000 X-Inumbo-ID: 118d8336-0134-11e8-ba59-bc764e045a96 Received: from mail-wr0-x244.google.com (unknown [2a00:1450:400c:c0c::244]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTPS id 118d8336-0134-11e8-ba59-bc764e045a96; Wed, 24 Jan 2018 19:26:18 +0100 (CET) Received: by mail-wr0-x244.google.com with SMTP id 100so5043971wrb.7 for ; Wed, 24 Jan 2018 10:26:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tt2co0RRpjeQXAhRNzj3W2MDTpX4xnPonjfR6QQq14M=; b=BZeKy8FV1MzotsKm//4OoNogpxksb4mxm9ZP2SD1QaxxMuZXp8oOfeBqsEyd00VsSV 2nq4y5IE5UF6nY3E4/+YRnNeVaTfN3+VQCt2uqt6DJf50GwTI55qB9WR/+jEx7iyrAJP IpoG8cLBTbaC1bt67GO4+OOEMqpuGmcjBq5uE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tt2co0RRpjeQXAhRNzj3W2MDTpX4xnPonjfR6QQq14M=; b=h5kV/vJV315W/C48OTvC/mh76zQtomVO5H43yGr8JIMHP6ULrXKcXmcrLzgkQGHyg0 gQozukcdsVnRx51aPHiMMa/aMMtrS+LXs6mqonfeU+xaaXmBaAmp07uvf/PM6DHAvkf+ 7myi1EBjmPITHnzh/4kCd/zzopDnxA7oT7ZX0H8cXBdsL8/4Sd6bK31JnAlJjXJ8mm9g LYuZDPiGHdx9sotcpvR7TDiv0fEy8SLqClyPBc6QEPYvreA80cwL1ddGu9zuC1lH5WC+ P+GSibfcxgB9uewBvkhz34NB1uMM8+e5vfCuqgVaaMS4ab1jIA8pwanHyeu6kFM8HCGe QPSQ== X-Gm-Message-State: AKwxytdt218c05tcNNDbbCE5fzexpDfRRD6zgxGdb48Urq53/xsCWuWe /R/taIfPGHHCnIgTj1sTJpJXT8kwBDQ= X-Received: by 10.223.197.72 with SMTP id s8mr6859950wrf.96.1516818381130; Wed, 24 Jan 2018 10:26:21 -0800 (PST) Received: from e108454-lin.cambridge.arm.com ([2001:41d0:1:6c23::1]) by smtp.gmail.com with ESMTPSA id k35sm6523047wrc.2.2018.01.24.10.26.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 24 Jan 2018 10:26:20 -0800 (PST) From: Julien Grall To: xen-devel@lists.xen.org Date: Wed, 24 Jan 2018 18:26:16 +0000 Message-Id: <20180124182616.3384-3-julien.grall@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180124182616.3384-1-julien.grall@linaro.org> References: <20180124182616.3384-1-julien.grall@linaro.org> Cc: sstabellini@kernel.org, Julien Grall , andre.przywara@linaro.org Subject: [Xen-devel] [PATCH v2 2/2] xen/arm: GICv3: Only initialize ITS when the distributor supports LPIs. X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There are firmware tables out describing the ITS but does not support LPIs. This will result to a data abort when trying to initialize ITS. While this can be consider a bug in the Device-Tree, same configuration boots on Linux. So gate the ITS initialization with the support of LPIs in the distributor. Signed-off-by: Julien Grall Reviewed-by: Stefano Stabellini --- xen/arch/arm/gic-v3.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/gic-v3.c b/xen/arch/arm/gic-v3.c index 9f9cf59f82..730450e34b 100644 --- a/xen/arch/arm/gic-v3.c +++ b/xen/arch/arm/gic-v3.c @@ -1637,6 +1637,11 @@ static unsigned long gicv3_get_hwdom_extra_madt_size(const struct domain *d) } #endif +static bool gic_dist_supports_lpis(void) +{ + return (readl_relaxed(GICD + GICD_TYPER) & GICD_TYPE_LPIS); +} + /* Set up the GIC */ static int __init gicv3_init(void) { @@ -1699,9 +1704,12 @@ static int __init gicv3_init(void) gicv3_dist_init(); - res = gicv3_its_init(); - if ( res ) - panic("GICv3: ITS: initialization failed: %d\n", res); + if ( gic_dist_supports_lpis() ) + { + res = gicv3_its_init(); + if ( res ) + panic("GICv3: ITS: initialization failed: %d\n", res); + } res = gicv3_cpu_init(); if ( res )