| Message ID | 1640147751-4777-1-git-send-email-spujar@nvidia.com |
|---|---|
| Headers | show |
| Series | Fix Tegra194 HDA regression | expand |
On 12/23/2021 12:46 PM, Greg KH wrote: > On Thu, Dec 23, 2021 at 10:04:19AM +0530, Sameer Pujar wrote: >> >> On 12/23/2021 12:10 AM, Dmitry Osipenko wrote: >>> 22.12.2021 07:35, Sameer Pujar пишет: >>>> HDA regression is recently reported on Tegra194 based platforms. >>>> This happens because "hda2codec_2x" reset does not really exist >>>> in Tegra194 and it causes probe failure. All the HDA based audio >>>> tests fail at the moment. This underlying issue is exposed by >>>> commit c045ceb5a145 ("reset: tegra-bpmp: Handle errors in BPMP >>>> response") which now checks return code of BPMP command response. >>>> Fix this issue by skipping unavailable reset on Tegra194. >>>> >>>> Signed-off-by: Sameer Pujar <spujar@nvidia.com> >>>> Cc: stable@vger.kernel.org >>>> Depends-on: 87f0e46e7559 ("ALSA: hda/tegra: Reset hardware") >>> Is "Depends-on" a valid tag? I can't find it in Documentation/. >> I do find the usage of the tag in many commits though there is no reference >> of this in doc. I always thought it would act as a reference when commits >> get pulled to other branches. If this is not true and it does not mean >> anything, I will drop this. > It is not true at all, please read: > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html > for how to do this properly. Thanks Greg for the pointer. I will drop above tag in v4.
HDA probe failure is observed on Tegra194 based platforms and this happens due to reset failure. This series fixes the problem by skipping the failing reset and DT bindings are updated accordingly. Changelog ========= v2 -> v3: --------- * Use reset bulk APIs in HDA driver as suggested by Dmitry. v1 -> v2: --------- * Updated HDA driver patch to skip the failing reset instead of skipping resets in general for BPMP devices as per comment from Dmitry. * Used a better strucure name for SoC data as per comment from Thierry. * Dropped 'Fixes' tag in binding doc patch as per comment from Dmitry. Sameer Pujar (3): ALSA: hda/tegra: Fix Tegra194 HDA reset failure dt-bindings: sound: tegra: Update HDA resets arm64: tegra: Remove non existent Tegra194 reset .../bindings/sound/nvidia,tegra30-hda.yaml | 13 +++++-- arch/arm64/boot/dts/nvidia/tegra194.dtsi | 5 +-- sound/pci/hda/hda_tegra.c | 45 +++++++++++++++++----- 3 files changed, 47 insertions(+), 16 deletions(-)