mbox series

[v4,0/3] Convert soundwire bindings to DT schema

Message ID 1667830844-31566-1-git-send-email-quic_srivasam@quicinc.com
Headers show
Series Convert soundwire bindings to DT schema | expand

Message

Srinivasa Rao Mandadapu Nov. 7, 2022, 2:20 p.m. UTC 
Convert soundwire bindings text file to DT schema and update
device tree entries to follow strict dt-bindings.
Changes Since V3:
  -- Remove subnode description and add appropriate pattern properties.
  -- Add interrput names in example.
  -- update some properties description.
  -- Revert minIteams change in previous version.
  -- Rebase to latest code base.
  -- Update dtsi node names,
  -- Remove redundant property in soundwire node.

Srinivasa Rao Mandadapu (3):
  arm64: dts: qcom: Update soundwire slave node names
  arm64: dts: qcom: Remove redundant soundwire property
  dt-bindings: soundwire: Convert text bindings to DT Schema

 .../devicetree/bindings/soundwire/qcom,sdw.txt     | 215 ------------------
 .../bindings/soundwire/qcom,soundwire.yaml         | 241 +++++++++++++++++++++
 arch/arm64/boot/dts/qcom/qrb5165-rb5.dts           |   4 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi               |   1 -
 arch/arm64/boot/dts/qcom/sdm845-db845c.dts         |   4 +-
 .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts      |   4 +-
 arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts   |   4 +-
 arch/arm64/boot/dts/qcom/sm8250-mtp.dts            |   4 +-
 arch/arm64/boot/dts/qcom/sm8250.dtsi               |   1 -
 9 files changed, 251 insertions(+), 227 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/soundwire/qcom,sdw.txt
 create mode 100644 Documentation/devicetree/bindings/soundwire/qcom,soundwire.yaml

Comments

Krzysztof Kozlowski Nov. 7, 2022, 3:02 p.m. UTC | #1 
On 07/11/2022 15:20, Srinivasa Rao Mandadapu wrote:
> Update soundwire slave nodes of WSA speaker to match with
> dt-bindings pattern properties regular expression.
> 
> This modifiction is required to avoid dtbs-check errors
> occurred with qcom,soundwire.yaml.
> 
> Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
> Co-developed-by: Ratna Deepthi Kudaravalli <quic_rkudarav@quicinc.com>
> Signed-off-by: Ratna Deepthi Kudaravalli <quic_rkudarav@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts             | 4 ++--
>  arch/arm64/boot/dts/qcom/sdm845-db845c.dts           | 4 ++--
>  arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 4 ++--
>  arch/arm64/boot/dts/qcom/sdm850-samsung-w737.dts     | 4 ++--
>  arch/arm64/boot/dts/qcom/sm8250-mtp.dts              | 4 ++--
>  5 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index 2c08500..983e8a9 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1007,7 +1007,7 @@
>  };
>  
>  &swr0 {
> -	left_spkr: wsa8810-left {
> +	left_spkr: wsa8810@0,3 {

While changing it, make the node names generic, so:

speaker@0,3

https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

>  		compatible = "sdw10217211000";
>  		reg = <0 3>;
>  		powerdown-gpios = <&tlmm 130 GPIO_ACTIVE_HIGH>;
> @@ -1016,7 +1016,7 @@
>  		#sound-dai-cells = <0>;
>  	};
>  
> -	right_spkr: wsa8810-right {
> +	right_spkr: wsa8810@0,4 {

speaker@0,4

and so on...

Best regards,
Krzysztof