mbox series

[0/3] ASoC: Kill tasklet usage

Message ID 20200903104749.21435-1-tiwai@suse.de
Headers show
Series ASoC: Kill tasklet usage | expand

Message

Takashi Iwai Sept. 3, 2020, 10:47 a.m. UTC 
Hi,

this is another series of patches to kill tasklet usages in sound
tree, at this time, applied to ASoC drivers.
The patches are applied on top the tasklet API conversion patches,
found in topic/tasklet-convert branch of sound git tree, which will be
included in 5.9-rc4.


Takashi

===

Takashi Iwai (3):
  ASoC: fsl: Replace tasklet with work
  ASoC: sh: Replace tasklet with work
  ASoC: txx9: Replace tasklet with work

 sound/soc/fsl/fsl_esai.c  | 14 +++++++-------
 sound/soc/sh/siu.h        |  2 +-
 sound/soc/sh/siu_pcm.c    | 21 +++++++++++----------
 sound/soc/txx9/txx9aclc.c | 11 ++++++-----
 sound/soc/txx9/txx9aclc.h |  2 +-
 5 files changed, 26 insertions(+), 24 deletions(-)

Comments

Takashi Iwai Sept. 9, 2020, 2:21 p.m. UTC | #1 
On Wed, 09 Sep 2020 16:16:59 +0200,
Mark Brown wrote:
> 
> On Thu, Sep 03, 2020 at 12:47:47PM +0200, Takashi Iwai wrote:
> > The tasklet is an old API that should be deprecated, usually can be
> > converted to another decent API.  In ASoC FSL ESAI CPU DAI driver, a
> > tasklet is still used for offloading the hardware reset function.
> > It can be achieved gracefully with a work queued, too.
> 
> This doesn't apply against current code, please check and resend.

Did you merge either Linus tree (v5.9-rc4) or my topic/tasklet-convert
branch into yours beforehand?  There are tasklet API conversions
landed in 5.9-rc4, and these patches are based on it.


Takashi
Mark Brown Sept. 9, 2020, 2:48 p.m. UTC | #2 
On Wed, Sep 09, 2020 at 04:21:35PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:

> > This doesn't apply against current code, please check and resend.

> Did you merge either Linus tree (v5.9-rc4) or my topic/tasklet-convert
> branch into yours beforehand?  There are tasklet API conversions
> landed in 5.9-rc4, and these patches are based on it.

Yeah, since sending this I think I got your branch - I'd misread the
cover as saying it worked with that not that it was a dependency.