| Message ID | 20201227211232.117801-1-hdegoede@redhat.com |
|---|---|
| Headers | show |
| Series | MFD/extcon/ASoC: Add support for Intel Bay Trail boards with WM5102 codec | expand |
On Sun, Dec 27, 2020 at 11:15 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi All, > > This patch series adds support for Intel Bay Trail based device which use > a WM5102 codec for audio output/input. This was developed and tested on a > Lenovo Yoga Tablet 1051L. > > This series consists of 3 parts: > 1. Arizona MFD drv patches for ACPI bindings, better jack-detect support > and misc. fixes > 2. extcon-arizona driver fixes and improved jack reporting (this depends > on the MFD changes) > 3. ASoC patches in the form of a quirk for BYTCR detecting, a new > machine driver for BYT + WM5102 and jack-detect support for the new > machine driver (which again depends on the MFD changes). > > Given that 2. and 3. depend on the MFD changes I believe that it is best > if all patches in this series are merged through the MFD tree (once > reviewed and acked) and then Lee can provide a immutable branch for > the ASoC and extcon maintainers to merge into their trees. > > I have a patch with matching UCM profile changes available here: > https://github.com/jwrdegoede/alsa-ucm-conf/commit/316109e7814926ba984322c1d9190575fab9021c > > This series + the UCM profile has been tested with both the SST and > SOF ASoC drivers for BYT devices. Thanks for fixing this! I found the series pretty much in a good shape (only two patches I think need a bit of work), FWIW Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> after addressing comments. > BugLink: https://github.com/thesofproject/linux/issues/2485 Shouldn't this be somewhere in the "main" fix? (Yes, I understand that it may sound silly and should be copied to almost half of the series, but if there is a good place it would be nice to have in the Git history)
Hi, On 12/28/20 3:19 PM, Andy Shevchenko wrote: > On Sun, Dec 27, 2020 at 11:15 PM Hans de Goede <hdegoede@redhat.com> wrote: >> >> Hi All, >> >> This patch series adds support for Intel Bay Trail based device which use >> a WM5102 codec for audio output/input. This was developed and tested on a >> Lenovo Yoga Tablet 1051L. >> >> This series consists of 3 parts: >> 1. Arizona MFD drv patches for ACPI bindings, better jack-detect support >> and misc. fixes >> 2. extcon-arizona driver fixes and improved jack reporting (this depends >> on the MFD changes) >> 3. ASoC patches in the form of a quirk for BYTCR detecting, a new >> machine driver for BYT + WM5102 and jack-detect support for the new >> machine driver (which again depends on the MFD changes). >> >> Given that 2. and 3. depend on the MFD changes I believe that it is best >> if all patches in this series are merged through the MFD tree (once >> reviewed and acked) and then Lee can provide a immutable branch for >> the ASoC and extcon maintainers to merge into their trees. >> >> I have a patch with matching UCM profile changes available here: >> https://github.com/jwrdegoede/alsa-ucm-conf/commit/316109e7814926ba984322c1d9190575fab9021c >> >> This series + the UCM profile has been tested with both the SST and >> SOF ASoC drivers for BYT devices. > > Thanks for fixing this! > I found the series pretty much in a good shape (only two patches I > think need a bit of work), FWIW > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > after addressing comments. Thank you, because of the jack-handling discussion I've extensively reworked this series (and I'm going to split it into 2 series for v2). I've kept your Reviewed-by: for the patches which are >= 99% unchanged from v1. I've not added it to a whole bunch of new patches (and some other patches were dropped). >> BugLink: https://github.com/thesofproject/linux/issues/2485 > > Shouldn't this be somewhere in the "main" fix? (Yes, I understand that > it may sound silly and should be copied to almost half of the series, > but if there is a good place it would be nice to have in the Git > history) Ack. I've added this to the: "ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102" patches' commit msg now. Regards, Hans