| Message ID | 20210112125834.21545-1-digetx@gmail.com |
|---|---|
| Headers | show |
| Series | Clock and reset improvements for Tegra ALSA drivers | expand |
On Tue, 12 Jan 2021 13:58:29 +0100, Dmitry Osipenko wrote: > > This series improves the handling of clock and reset controls of > NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling > resets properly, which needs to be fixed in order to unblock other patches > related to fixes on the reset controller driver since HDA/AHUB are bound > to fail once reset controller driver will be corrected. In particular ALSA > drivers are relying on implicit de-assertion of resets which is done by the > tegra-clk driver. It's not the business of the clk driver to touch resets > and we need to fix this because it breaks reset/clk programming sequences > of other Tegra drivers. > > Dmitry Osipenko (5): > ALSA: hda/tegra: Use clk_bulk helpers > ALSA: hda/tegra: Reset hardware > ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive() > ASoC: tegra: ahub: Use clk_bulk helpers > ASoC: tegra: ahub: Reset hardware properly Thierry, Jonathan, Sameer, could you guys check those please? thanks, Takashi > > sound/pci/hda/hda_tegra.c | 86 +++++++++------------------ > sound/soc/tegra/tegra30_ahub.c | 103 ++++++--------------------------- > sound/soc/tegra/tegra30_ahub.h | 6 +- > 3 files changed, 49 insertions(+), 146 deletions(-) > > -- > 2.29.2 >
On 12/01/2021 12:58, Dmitry Osipenko wrote: > This series improves the handling of clock and reset controls of > NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling > resets properly, which needs to be fixed in order to unblock other patches > related to fixes on the reset controller driver since HDA/AHUB are bound > to fail once reset controller driver will be corrected. In particular ALSA > drivers are relying on implicit de-assertion of resets which is done by the > tegra-clk driver. It's not the business of the clk driver to touch resets > and we need to fix this because it breaks reset/clk programming sequences > of other Tegra drivers. > > Dmitry Osipenko (5): > ALSA: hda/tegra: Use clk_bulk helpers > ALSA: hda/tegra: Reset hardware > ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive() > ASoC: tegra: ahub: Use clk_bulk helpers > ASoC: tegra: ahub: Reset hardware properly > > sound/pci/hda/hda_tegra.c | 86 +++++++++------------------ > sound/soc/tegra/tegra30_ahub.c | 103 ++++++--------------------------- > sound/soc/tegra/tegra30_ahub.h | 6 +- > 3 files changed, 49 insertions(+), 146 deletions(-) I wonder if this will help with the issues we saw when the tegra is the i2s clock slave.
15.01.2021 13:52, Ben Dooks пишет: > On 12/01/2021 12:58, Dmitry Osipenko wrote: >> This series improves the handling of clock and reset controls of >> NVIDA Tegra ALSA drivers. Tegra HDA and AHUB drivers aren't handling >> resets properly, which needs to be fixed in order to unblock other >> patches >> related to fixes on the reset controller driver since HDA/AHUB are bound >> to fail once reset controller driver will be corrected. In particular >> ALSA >> drivers are relying on implicit de-assertion of resets which is done >> by the >> tegra-clk driver. It's not the business of the clk driver to touch resets >> and we need to fix this because it breaks reset/clk programming sequences >> of other Tegra drivers. >> >> Dmitry Osipenko (5): >> ALSA: hda/tegra: Use clk_bulk helpers >> ALSA: hda/tegra: Reset hardware >> ASoC: tegra: ahub: Use of_reset_control_array_get_exclusive() >> ASoC: tegra: ahub: Use clk_bulk helpers >> ASoC: tegra: ahub: Reset hardware properly >> >> sound/pci/hda/hda_tegra.c | 86 +++++++++------------------ >> sound/soc/tegra/tegra30_ahub.c | 103 ++++++--------------------------- >> sound/soc/tegra/tegra30_ahub.h | 6 +- >> 3 files changed, 49 insertions(+), 146 deletions(-) > > I wonder if this will help with the issues we saw when the tegra is > the i2s clock slave. Probably no, this series shouldn't fix any of the current problems. I will be surprised if it does.