mbox series

[0/2] ASoC: SOF: Intel: hda: Enable DMI L1 for power savings

Message ID 20210126015130.1023840-1-ranjani.sridharan@linux.intel.com
Headers show
Series ASoC: SOF: Intel: hda: Enable DMI L1 for power savings | expand

Message

Ranjani Sridharan Jan. 26, 2021, 1:51 a.m. UTC 
This series includes 2 patches that enable DMI L1 for D0I3-compatible
streams and trace DMA stream to maximise power savings on Intel
HDA platforms.

Ranjani Sridharan (2):
  ASoC: SOF: Intel: hda: enable DMI L1 for D0i3-compatible streams
  ASoC: SOF: Intel: hda: Enable DMI L1 for trace

 sound/soc/sof/intel/hda-compress.c |  2 +-
 sound/soc/sof/intel/hda-loader.c   |  2 +-
 sound/soc/sof/intel/hda-pcm.c      | 16 ++++++++++++-
 sound/soc/sof/intel/hda-stream.c   | 38 +++++++++++++++++-------------
 sound/soc/sof/intel/hda-trace.c    |  4 ++--
 sound/soc/sof/intel/hda.h          |  6 ++++-
 6 files changed, 46 insertions(+), 22 deletions(-)

Comments

Ranjani Sridharan Jan. 27, 2021, 1:45 a.m. UTC | #1 
On Mon, 2021-01-25 at 17:51 -0800, Ranjani Sridharan wrote:
> DMI L1 entry is currently disabled whenever any capture stream is
> opened to prevent xruns during pause/release. But, in
> order to maximise power savings for the wake-on-voice usecase,
> DMI L1 entry should be enabled for D0i3-compatible capture streams.
> Introduce a new field, flags in struct sof_intel_hda_stream
> that stores whether a stream is dmi_l1_compatible. All playback
> streams,
> and D0i3-compatible capture streams are DMI L1 compatible.
> 
> Reviewed-by: Pierre-Louis Bossart <
> pierre-louis.bossart@linux.intel.com>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
> ---
>  sound/soc/sof/intel/hda-compress.c |  2 +-
>  sound/soc/sof/intel/hda-loader.c   |  2 +-
>  sound/soc/sof/intel/hda-pcm.c      | 16 ++++++++++++-
>  sound/soc/sof/intel/hda-stream.c   | 38 +++++++++++++++++-----------
> --
>  sound/soc/sof/intel/hda-trace.c    |  3 +--
>  sound/soc/sof/intel/hda.h          |  6 ++++-
>  6 files changed, 45 insertions(+), 22 deletions(-)
> 
> diff --git a/sound/soc/sof/intel/hda-compress.c
> b/sound/soc/sof/intel/hda-compress.c
> index 53c08034fa22..7899004df8d1 100644
> --- a/sound/soc/sof/intel/hda-compress.c
> +++ b/sound/soc/sof/intel/hda-compress.c
> @@ -25,7 +25,7 @@ int hda_probe_compr_assign(struct snd_sof_dev
> *sdev,
>  {
>  	struct hdac_ext_stream *stream;
>  
> -	stream = hda_dsp_stream_get(sdev, cstream->direction);
> +	stream = hda_dsp_stream_get(sdev, cstream->direction, 0)
Hi Mark,

Sorry, this wont build with the probes feature enabled in Kconfig
because of the missing semicolon. I will post v2 soon.

Thanks,
Ranjani