| Message ID | 20220712125734.30512-1-peter.ujfalusi@linux.intel.com |
|---|---|
| Headers | show |
| Series | ASoC: SOF: Intel: hda: Correct Firmware State Register use | expand |
On Tue, 12 Jul 2022 15:57:31 +0300, Peter Ujfalusi wrote: > The FSR (Firmware State Register) holds the ROM state information, it does not > contain error information. > The FSR itself is a bit more complicated as well as the state depends on the > module currently in use. > > The error code from ROM or the status code from the firmware is located at the > next register. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/3] ASoC: SOF: Intel: hda: Correct the ROM/FW state reporting code (no commit info) [2/3] ASoC: SOF: Intel: hda-loader: Use the FSR state definitions during bootup commit: 43a03d247091e1fcd3065dae3407b959e8921c16 [3/3] ASoC: SOF: Intel: hda: Drop no longer used ROM state definitions commit: 8613753a681e7a5c63313dea9b04bf103d601368 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
Hi, The FSR (Firmware State Register) holds the ROM state information, it does not contain error information. The FSR itself is a bit more complicated as well as the state depends on the module currently in use. The error code from ROM or the status code from the firmware is located at the next register. Fix the handling of the FSR in order to provide usable and human readable (in most cases) report on the status and error. Regards, Peter --- Peter Ujfalusi (3): ASoC: SOF: Intel: hda: Correct the ROM/FW state reporting code ASoC: SOF: Intel: hda-loader: Use the FSR state definitions during bootup ASoC: SOF: Intel: hda: Drop no longer used ROM state definitions sound/soc/sof/intel/hda-loader.c | 10 +-- sound/soc/sof/intel/hda.c | 147 ++++++++++++++++++++++++++----- sound/soc/sof/intel/hda.h | 69 +++++++++++++-- 3 files changed, 194 insertions(+), 32 deletions(-)