mbox series

[v2,0/5] ASoC: Intel: Balance ACPI device refcount

Message ID 20230112112852.67714-1-andriy.shevchenko@linux.intel.com
Headers show
Series ASoC: Intel: Balance ACPI device refcount | expand

Message

Andy Shevchenko Jan. 12, 2023, 11:28 a.m. UTC
While looking for the open coded put_device(&adev->dev) cases, where
adev stands for ACPI device, I noticed that in a few ASoC Intel driver,
among others, the refcount is not balanced properly in some cases.

This series fixes that issue and converts to use acpi_dev_put().

Changelog v2:
- split Intel drivers out from others (Pierre)
- sent with cover letter (Mark)

Andy Shevchenko (5):
  ASoC: Intel: bytcht_es8316: Drop reference count of ACPI device after
    use
  ASoC: Intel: bytcr_rt5651: Drop reference count of ACPI device after
    use
  ASoC: Intel: bytcr_rt5640: Drop reference count of ACPI device after
    use
  ASoC: Intel: bytcr_wm5102: Drop reference count of ACPI device after
    use
  ASoC: Intel: sof_es8336: Drop reference count of ACPI device after use

 sound/soc/intel/boards/bytcht_es8316.c | 20 ++++++++++++--------
 sound/soc/intel/boards/bytcr_rt5640.c  | 12 ++++++------
 sound/soc/intel/boards/bytcr_rt5651.c  |  2 +-
 sound/soc/intel/boards/bytcr_wm5102.c  |  2 +-
 sound/soc/intel/boards/sof_es8336.c    | 14 ++++++++------
 5 files changed, 28 insertions(+), 22 deletions(-)

Comments

Pierre-Louis Bossart Jan. 12, 2023, 2:56 p.m. UTC | #1
On 1/12/23 05:28, Andy Shevchenko wrote:
> While looking for the open coded put_device(&adev->dev) cases, where
> adev stands for ACPI device, I noticed that in a few ASoC Intel driver,
> among others, the refcount is not balanced properly in some cases.
> 
> This series fixes that issue and converts to use acpi_dev_put().

Thanks Andy!

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
> Changelog v2:
> - split Intel drivers out from others (Pierre)
> - sent with cover letter (Mark)
> 
> Andy Shevchenko (5):
>   ASoC: Intel: bytcht_es8316: Drop reference count of ACPI device after
>     use
>   ASoC: Intel: bytcr_rt5651: Drop reference count of ACPI device after
>     use
>   ASoC: Intel: bytcr_rt5640: Drop reference count of ACPI device after
>     use
>   ASoC: Intel: bytcr_wm5102: Drop reference count of ACPI device after
>     use
>   ASoC: Intel: sof_es8336: Drop reference count of ACPI device after use
> 
>  sound/soc/intel/boards/bytcht_es8316.c | 20 ++++++++++++--------
>  sound/soc/intel/boards/bytcr_rt5640.c  | 12 ++++++------
>  sound/soc/intel/boards/bytcr_rt5651.c  |  2 +-
>  sound/soc/intel/boards/bytcr_wm5102.c  |  2 +-
>  sound/soc/intel/boards/sof_es8336.c    | 14 ++++++++------
>  5 files changed, 28 insertions(+), 22 deletions(-)
>
Mark Brown Jan. 12, 2023, 6:23 p.m. UTC | #2
On Thu, 12 Jan 2023 13:28:47 +0200, Andy Shevchenko wrote:
> While looking for the open coded put_device(&adev->dev) cases, where
> adev stands for ACPI device, I noticed that in a few ASoC Intel driver,
> among others, the refcount is not balanced properly in some cases.
> 
> This series fixes that issue and converts to use acpi_dev_put().
> 
> Changelog v2:
> - split Intel drivers out from others (Pierre)
> - sent with cover letter (Mark)
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/5] ASoC: Intel: bytcht_es8316: Drop reference count of ACPI device after use
      commit: 6b1c0bd6fdefbf3c3d75680c2708f5423ef72e46
[2/5] ASoC: Intel: bytcr_rt5651: Drop reference count of ACPI device after use
      commit: 721858823d7cdc8f2a897579b040e935989f6f02
[3/5] ASoC: Intel: bytcr_rt5640: Drop reference count of ACPI device after use
      commit: cbf87bcf46e399e9a5288430d940efbad3551c68
[4/5] ASoC: Intel: bytcr_wm5102: Drop reference count of ACPI device after use
      commit: c8aa49abdeda2ab587aadb083e670f6aa0236f93
[5/5] ASoC: Intel: sof_es8336: Drop reference count of ACPI device after use
      commit: 64e57b2195725c1ae2246a8a2ce224abb60620ac

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark