mbox series

[v1,0/3] ASoC: rt5677: Refactor to use device_get_match_data()

Message ID 20230629104603.88612-1-andriy.shevchenko@linux.intel.com
Headers show
Series ASoC: rt5677: Refactor to use device_get_match_data() | expand

Message

Andy Shevchenko June 29, 2023, 10:46 a.m. UTC 
The code can be simplified with device_get_match_data().
Besides that couple of additional changes, one for maintenance (patch 3)
and one for making IRQ domain agnostic (not pinned to OF).

Andy Shevchenko (3):
  ASoC: rt5677: Use agnostic irq_domain_create_linear()
  ASoC: rt5677: Use device_get_match_data()
  ASoC: rt5677: Sort headers alphabetically

 sound/soc/codecs/rt5677.c | 41 +++++++++++++--------------------------
 sound/soc/codecs/rt5677.h |  4 ++--
 2 files changed, 16 insertions(+), 29 deletions(-)

Comments

Mark Brown June 29, 2023, 10:56 a.m. UTC | #1 
On Thu, Jun 29, 2023 at 01:46:02PM +0300, Andy Shevchenko wrote:

> +	rt5677->type = (enum rt5677_type)(uintptr_t)device_get_match_data(dev);

Double casts, always a sign of a successful simplification! :P

> +	if (rt5677->type == 0)
>  		return -EINVAL;
> -	}
>  
>  	rt5677_read_device_properties(rt5677, &i2c->dev);
>  
> @@ -5702,7 +5689,7 @@ static struct i2c_driver rt5677_i2c_driver = {
>  	.driver = {
>  		.name = RT5677_DRV_NAME,
>  		.of_match_table = rt5677_of_match,
> -		.acpi_match_table = ACPI_PTR(rt5677_acpi_match),
> +		.acpi_match_table = rt5677_acpi_match,
>  	},
>  	.probe    = rt5677_i2c_probe,
>  	.remove   = rt5677_i2c_remove,
> diff --git a/sound/soc/codecs/rt5677.h b/sound/soc/codecs/rt5677.h
> index 944ae02aafc2..5ccdf1ba613a 100644
> --- a/sound/soc/codecs/rt5677.h
> +++ b/sound/soc/codecs/rt5677.h
> @@ -1753,8 +1753,8 @@ enum {
>  };
>  
>  enum rt5677_type {
> -	RT5677,
> -	RT5676,
> +	RT5677 = 1,
> +	RT5676 = 2,
>  };
>  
>  /* ASRC clock source selection */
> -- 
> 2.40.0.1.gaa8946217a0b
>