| Message ID | 20230710154932.68377-1-andriy.shevchenko@linux.intel.com |
|---|---|
| Headers | show |
| Series | spi: Header and core clean up and refactoring | expand |
On Tue, Jul 11, 2023 at 03:14:54PM +0100, Mark Brown wrote: > On Tue, Jul 11, 2023 at 02:01:13PM +0300, Andy Shevchenko wrote: > > On Mon, Jul 10, 2023 at 06:30:32PM +0100, Mark Brown wrote: > > > On Mon, Jul 10, 2023 at 06:49:21PM +0300, Andy Shevchenko wrote: > > > > > + * Assume speed to be 100 kHz if it's not defined at the time of invocation. > > > > You didn't mention this bit in the changelog, and I'm not 100% convinced > > > it was the best idea in the first place. It's going to result in some > > > very big timeouts if it goes off, and we really should be doing > > > validation much earlier in the process. > > > Okay, let's drop this change. > > Like I say we *should* be fine with the refactoring without this, or at > least if it's an issue we should improve the validation. For the speeds < 1000 Hz, this change will lead to the div by 0 crash. It seems that the current code which this one removes is better than the spi_controller_xfer_timeout() provides. If anything, the spi_controller_xfer_timeout() should be improved first. So, for now I drop this for sure. Maybe in the future we can come back to it.
On Mon, 10 Jul 2023 18:49:17 +0300, Andy Shevchenko wrote: > Various cleanups and refactorings of the SPI header and core parts > united in a single series. It also touches drivers under SPI subsystem > folder on the pure renaming purposes of some constants. > > No functional change intended. > > Changelog v2: > - added new patches 3,4,5,10,13,14 > - massaged comment and kernel doc in patch 9 > - split used to be patch 4 to patches 11,12 > - covered a few things in SPI core in patch 15 > - amended commit message for above (Mark) > - reshuffled patches in the series for better logical grouping > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [01/15] spi: Remove unneeded OF node NULL checks commit: fbab5b2c09060e8034fee6ec2df69a62594fb7db [02/15] spi: Drop duplicate IDR allocation code in spi_register_controller() commit: 440c47331bdb889e24128c75387c695ca81d9b9b [03/15] spi: Replace if-else-if by bitops and multiplications commit: 2b308e7176e366a52a07a49868e3b1a295e56785 [06/15] spi: Use sysfs_emit() to instead of s*printf() commit: f2daa4667fda1aa951b91da0ae9675a5da9d7716 [07/15] spi: Sort headers alphabetically commit: edf6a864c996f9a9f5299a3b3e574a37e64000c5 [08/15] spi: Clean up headers (no commit info) [11/15] spi: Get rid of old SPI_MASTER_NO_TX & SPI_MASTER_NO_RX commit: c397f09e5498994790503a64486213ef85e58db9 [12/15] spi: Get rid of old SPI_MASTER_MUST_TX & SPI_MASTER_MUST_RX commit: 90366cd60133a9f5b6a2f31360367c658585e125 [13/15] spi: Rename SPI_MASTER_GPIO_SS to SPI_CONTROLLER_GPIO_SS commit: 82238d2cbd99ebd09dda48fb7c1c8802097da6a2 [14/15] spi: Convert to SPI_CONTROLLER_HALF_DUPLEX commit: 7a2b552c8e0e5bb280558f6c120140f5f06323bc [15/15] spi: Fix spelling typos and acronyms capitalization commit: 702ca0269ed56e2d8dae7874a4d8af268e2a382e All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark