mbox series

[0/7] ASoC: SOF: Intel: remove circular dependency for SoundWire BPT

Message ID 20240503135221.229202-1-pierre-louis.bossart@linux.intel.com
Headers show
Series ASoC: SOF: Intel: remove circular dependency for SoundWire BPT | expand

Message

Pierre-Louis Bossart May 3, 2024, 1:52 p.m. UTC
The SoundWire BPT support will rely on the HDaudio DMA. This exposes a
circular dependency module dependency which has to be resolved by
splitting common parts used by HDaudio and SoundWire parts, and
'generic' parts used by HDaudio only.

This patchset does not change any functionality, it just moves code
around, exposes symbols that are used in the new module. The code has
been in use for more than one kernel cycle already so it really
shouldn't break any existing platforms.

The main issue with such code moves is that it makes backports or
fixes more complicated. That's the main reason why we held back these
patches until we were reasonably confident on the maturity of MTL and
LNL drivers.

Pierre-Louis Bossart (7):
  ASoC: SOF: Intel: hda-stream: export stream_get_position() helper
  ASoC: SOF: Intel: regroup all SoundWire/Intel functions in hda.c
  ASoC: SOF: Intel: start splitting top-level from common parts
  ASoC: SOF: Intel: move common code from hda.c
  ASoC: SOF: Intel: move tracepoint creation
  ASoC: SOF: Intel: remove circular dependency on
    hda_sdw_process_wakeen()
  ASoC: SOF: Intel: move hda.c to different module

 sound/soc/sof/intel/Kconfig          |  25 +-
 sound/soc/sof/intel/Makefile         |  23 +-
 sound/soc/sof/intel/apl.c            |   3 -
 sound/soc/sof/intel/cnl.c            |  15 +-
 sound/soc/sof/intel/hda-bus.c        |   2 +
 sound/soc/sof/intel/hda-common-ops.c |   1 +
 sound/soc/sof/intel/hda-ctrl.c       |  10 +
 sound/soc/sof/intel/hda-dai.c        |   6 +
 sound/soc/sof/intel/hda-dsp.c        | 502 ++++++++++++++++++++++
 sound/soc/sof/intel/hda-ipc.c        | 115 +++++
 sound/soc/sof/intel/hda-loader.c     |  45 +-
 sound/soc/sof/intel/hda-pcm.c        |   6 +
 sound/soc/sof/intel/hda-probes.c     |   2 +
 sound/soc/sof/intel/hda-stream.c     |  13 +
 sound/soc/sof/intel/hda-trace.c      |   3 +
 sound/soc/sof/intel/hda.c            | 605 +++------------------------
 sound/soc/sof/intel/hda.h            |  15 +
 sound/soc/sof/intel/icl.c            |   4 +-
 sound/soc/sof/intel/lnl.c            |   4 +-
 sound/soc/sof/intel/mtl.c            |  21 +-
 sound/soc/sof/intel/pci-apl.c        |   1 +
 sound/soc/sof/intel/pci-cnl.c        |   1 +
 sound/soc/sof/intel/pci-icl.c        |   2 +
 sound/soc/sof/intel/pci-lnl.c        |   3 +
 sound/soc/sof/intel/pci-mtl.c        |   1 +
 sound/soc/sof/intel/pci-skl.c        |   1 +
 sound/soc/sof/intel/pci-tgl.c        |   2 +
 sound/soc/sof/intel/shim.h           |   1 +
 sound/soc/sof/intel/telemetry.c      |   1 +
 sound/soc/sof/intel/tgl.c            |  10 +-
 sound/soc/sof/intel/tracepoints.c    |   5 +
 31 files changed, 811 insertions(+), 637 deletions(-)
 create mode 100644 sound/soc/sof/intel/tracepoints.c

Comments

Mark Brown May 7, 2024, 1:35 a.m. UTC | #1
On Fri, 03 May 2024 08:52:14 -0500, Pierre-Louis Bossart wrote:
> The SoundWire BPT support will rely on the HDaudio DMA. This exposes a
> circular dependency module dependency which has to be resolved by
> splitting common parts used by HDaudio and SoundWire parts, and
> 'generic' parts used by HDaudio only.
> 
> This patchset does not change any functionality, it just moves code
> around, exposes symbols that are used in the new module. The code has
> been in use for more than one kernel cycle already so it really
> shouldn't break any existing platforms.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/7] ASoC: SOF: Intel: hda-stream: export stream_get_position() helper
      commit: 9e7fd21ab03e6fadc4856f4c06e642daa9ccf7c6
[2/7] ASoC: SOF: Intel: regroup all SoundWire/Intel functions in hda.c
      commit: e4c6eba86d9618d99ba9892bc5d6e47715038530
[3/7] ASoC: SOF: Intel: start splitting top-level from common parts
      commit: 456644cbeab14394fff1308ffdaf87d4e0e6fb01
[4/7] ASoC: SOF: Intel: move common code from hda.c
      commit: 0bfbe91a2dbba31d41add146ab173721dee85ab3
[5/7] ASoC: SOF: Intel: move tracepoint creation
      commit: 136b37369cc4f044139b886133f3b9a721ecacd1
[6/7] ASoC: SOF: Intel: remove circular dependency on hda_sdw_process_wakeen()
      commit: 3b7bd0c139849e95981961525b7f6dd20097a563
[7/7] ASoC: SOF: Intel: move hda.c to different module
      commit: 6fe61f31eab1ec84c385786cd052415d966e5235

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark