mbox series

[0/3] ASoC: ti: Use of_device_get_match_data

Message ID cover.1628972198.git.aakashhemadri123@gmail.com
Headers show
Series ASoC: ti: Use of_device_get_match_data | expand

Message

Aakash Hemadri Aug. 14, 2021, 8:19 p.m. UTC 
Hi,
	This patch series will apply cleanly on for-next
Prefer `of_device_get_match_data` over `of_match_device`.

Aakash Hemadri (3):
  ASoC: ti: davinci-mcasp: Use of_device_get_match_data
  ASoC: ti: omap-mcbsp: Use of_device_get_match_data
  ASoC: ti: davinci-evm: Use of_device_get_match_data

 sound/soc/ti/davinci-evm.c   | 2 +-
 sound/soc/ti/davinci-mcasp.c | 2 +-
 sound/soc/ti/omap-mcbsp.c    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Péter Ujfalusi Aug. 16, 2021, 6:33 p.m. UTC | #1 
On 14/08/2021 23:19, Aakash Hemadri wrote:
> Prefer `of_device_get_match_data` over `of_match_device`
> 
> Retrieve OF match data using `of_device_get_match_data`, this is cleaner
> and better expresses intent.
> 
> Signed-off-by: Aakash Hemadri <aakashhemadri123@gmail.com>
> ---
>  sound/soc/ti/davinci-mcasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c
> index 56a19eeec5c7..b26e8d324078 100644
> --- a/sound/soc/ti/davinci-mcasp.c
> +++ b/sound/soc/ti/davinci-mcasp.c
> @@ -1881,7 +1881,7 @@ static bool davinci_mcasp_have_gpiochip(struct davinci_mcasp *mcasp)
>  static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp,
>  				    struct platform_device *pdev)
>  {
> -	const struct of_device_id *match = of_match_device(mcasp_dt_ids, &pdev->dev);
> +	const struct of_device_id *match = of_device_get_match_data(&pdev->dev);

No.
of_device_get_match_data() returns the match->data

>  	struct device_node *np = pdev->dev.of_node;
>  	struct davinci_mcasp_pdata *pdata = NULL;
>  	const u32 *of_serial_dir32;
>