| Message ID | 20210326215927.936377-12-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | 54f78aebe803b12e06d49988be88d87823ca16ab |
| Headers | show |
| Series | ASoC: remove cppcheck warnings for multiple SOCs | expand |
On Fri, Mar 26, 2021 at 04:59:21PM -0500, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/sunxi/sun8i-codec.c:488:28: style: Clarify calculation > precedence for '%' and '?'. [clarifyCalculation] > return sample_rate % 4000 ? 22579200 : 24576000; > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Acked-by: Maxime Ripard <maxime@cerno.tech> Thanks! Maxime
diff --git a/sound/soc/sunxi/sun8i-codec.c b/sound/soc/sunxi/sun8i-codec.c index 460924fc173f..518bfb724a5b 100644 --- a/sound/soc/sunxi/sun8i-codec.c +++ b/sound/soc/sunxi/sun8i-codec.c @@ -485,7 +485,7 @@ static int sun8i_codec_get_lrck_div_order(unsigned int slots, static unsigned int sun8i_codec_get_sysclk_rate(unsigned int sample_rate) { - return sample_rate % 4000 ? 22579200 : 24576000; + return (sample_rate % 4000) ? 22579200 : 24576000; } static int sun8i_codec_hw_params(struct snd_pcm_substream *substream,
cppcheck warning: sound/soc/sunxi/sun8i-codec.c:488:28: style: Clarify calculation precedence for '%' and '?'. [clarifyCalculation] return sample_rate % 4000 ? 22579200 : 24576000; ^ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> --- sound/soc/sunxi/sun8i-codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)