From patchwork Tue Dec 14 02:08:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 523689 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F23D4C433EF for ; Tue, 14 Dec 2021 02:15:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 458891EFD; Tue, 14 Dec 2021 03:14:56 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 458891EFD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1639448146; bh=sKblV5eTzNMbrV8+n6vDt1bRP8aKO7Na92dspOY3hHk=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qAN3E2PpvTe3QKgoTY07E3HCndiQEBRvMANLUDLzNGJdRAPWqnbGTQ+v56O/ECOHP Et/uO7PUIvUaLSWRXp0KQFNh4kSa8aKVCjChyuNjQETM3FVmFqlS3gfkdoeH2bUrsR aG1LdymRWQjgXvw/79d2pXTOj+KvauK8L+tBGfIk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DFE2BF80557; Tue, 14 Dec 2021 03:10:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2585AF80589; Tue, 14 Dec 2021 03:10:02 +0100 (CET) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 2921DF8053E for ; Tue, 14 Dec 2021 03:09:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 2921DF8053E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gflC/poU" Received: by mail-pg1-x531.google.com with SMTP id 133so16099447pgc.12 for ; Mon, 13 Dec 2021 18:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6u6FkCPCfv4J7pdg4Ybljstse/ix+a86moRRp7mRqHM=; b=gflC/poUt+2r7cA9Q5zzWqPY8DRXaTP5MRDsuAQXZiUILJxP5ELCxq6TEKRuP7gi5e tjkaWbVFlIXFuxWZRrzv1amRPpBaPUUHHz5/YCxBuyt+yNfO8fVuryrTEWKLN7tXu/e2 NJ38CrTYOPE/k4ZjQz2EZ8kSXfU40hAZIgnoqb/yp5JWOK8BvaNvVRlrMK9I4OyDmctx oHInFeWTtW0QSfrvv2v3a5iWz9GuZUxaePkKHFG9nBB3utZP3m6b3JDlO3oUfuf5WTuz Rbb7PFY34SYuv9DY4YdnNhspQaoY8S5jkkYkmJ5AjdYOluPyhswU/i3O3X26Qf734uIY sQ6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=6u6FkCPCfv4J7pdg4Ybljstse/ix+a86moRRp7mRqHM=; b=due9Q76a2VgKTPl6f02YEpuFOmfIQaE3x9x6eKfHlp/o4EaYi+ld+rZ4qceLRhVX5X fSFpyihu+KEczNEqt+oYsXoxnDd5xPiPcmXgI29CaR5pW+P8AfDt2FyiJDWgCOpxr/2A yYYACz+Rh0Hyemh0DESSJLFuontEGpADtqqBAs9jIQbu/IlXj75KLi7BW6JYmUMD7rqu ny+BjmuNDKmRf0Ua2PR9E/UdpiLYb9xKNVhgwdJ1DhJxocB3mf7MyM1/JrUwhqzt/h3o A9478pMAZyw256PvDfplBPQ4lAbuB1MLwEKqbrbPnVV6WEqouxI7Im5jOQ4PlZououZA bZFw== X-Gm-Message-State: AOAM533xtezJx1bSF57ycCnpDBIbp7HJSMjARdCcfcxkz53Sp87EproI oEy07uw/4FtohWXgSI3/RDE= X-Google-Smtp-Source: ABdhPJzSVH3Mnxdpn9YFOt4CPLgiUCSLVVw9mCHtXX79l7AP11X9GIpLmL8ENtNUOcz8kBIX8vxTNg== X-Received: by 2002:a63:191d:: with SMTP id z29mr1743341pgl.358.1639447788205; Mon, 13 Dec 2021 18:09:48 -0800 (PST) Received: from localhost.localdomain ([126.249.140.249]) by smtp.gmail.com with ESMTPSA id b2sm14622296pfv.198.2021.12.13.18.09.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 18:09:47 -0800 (PST) From: Kuninori Morimoto To: Mark Brown Subject: [PATCH 18/22] ASoC: qcom: Use dev_err_probe() helper Date: Tue, 14 Dec 2021 11:08:39 +0900 Message-Id: <20211214020843.2225831-19-kuninori.morimoto.gx@renesas.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211214020843.2225831-1-kuninori.morimoto.gx@renesas.com> References: <20211214020843.2225831-1-kuninori.morimoto.gx@renesas.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Kuninori Morimoto X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Kuninori Morimoto Use the dev_err_probe() helper, instead of open-coding the same operation. Signed-off-by: Kuninori Morimoto --- sound/soc/qcom/common.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c index 2e1c618f7529..e1bf04d00625 100644 --- a/sound/soc/qcom/common.c +++ b/sound/soc/qcom/common.c @@ -94,9 +94,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card) ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name); if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(card->dev, "%s: error getting cpu dai name: %d\n", - link->name, ret); + dev_err_probe(card->dev, ret, + "%s: error getting cpu dai name\n", link->name); goto err; } @@ -116,9 +115,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card) if (codec) { ret = snd_soc_of_get_dai_link_codecs(dev, codec, link); if (ret < 0) { - if (ret != -EPROBE_DEFER) - dev_err(card->dev, "%s: codec dai not found: %d\n", - link->name, ret); + dev_err_probe(card->dev, ret, + "%s: codec dai not found\n", link->name); goto err; }