From patchwork Mon Oct 24 16:53:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 617907 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7AB7FA3744 for ; Mon, 24 Oct 2022 16:56:07 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D0B4D6FB3; Mon, 24 Oct 2022 18:55:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D0B4D6FB3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666630565; bh=qmjhZyi70p2iPcs+iHIxnVjUb/ktUC2fx19Ez2zQMwA=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Z64MPuwT34UrxJW3XL0ogCtwfWq/ai1aZASCTME4VRpJFkxKpQ9Dtx8Srm4JsOP7h 8EbcdLLl7bZXsy5PyC7cL0GrvqY3e98jfpFz3sAmNItosRUWOtJF1R3hsqRzvZ0jd0 72A2IIx0uT7OKfHXa2+t1LP7ptqR+o1gI+KpdSyw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2587FF8054A; Mon, 24 Oct 2022 18:53:43 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF88DF8057D; Mon, 24 Oct 2022 18:53:38 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DB66DF8052F for ; Mon, 24 Oct 2022 18:53:32 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DB66DF8052F Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IqkxFCj3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666630414; x=1698166414; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qmjhZyi70p2iPcs+iHIxnVjUb/ktUC2fx19Ez2zQMwA=; b=IqkxFCj3CYgRANeyN6deetXTQINBIOZNeCbbAPDsrStcJy/KwFlI0PXn oN8OC68+fxW2VwNL3BuhbvPhcCCQThYf+UN0v7DGvS1lv35J3BQk2Mbqb B+U1Hqtu0c0VmNou/d8FlJeiAvQJ7fvD2GV14wfId6CY15Ae+zTUdMFap BH8S0rlrmcfp7Gbn4U7KOuVsdSKeQmkOnyBvZXSHoYNEZ+g3ZwMn5xIq/ ZjuMA+3TfKAQxAXDEf0RxtfWzEOV/E7Boaidh4AyaEPYueo49D7t8e9LL cWmW3Q9h2z7s7b/kjy1iptpb8jJ3lRRCarpoI93xGQSErdWztgk6ogNT/ w==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="287868647" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="287868647" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 09:53:29 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="609263067" X-IronPort-AV: E=Sophos;i="5.95,209,1661842800"; d="scan'208";a="609263067" Received: from tdsilva-mobl1.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.213.186.236]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 09:53:28 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH 09/16] ASoC: SOF: Intel: hda-ctrl: remove useless sleep Date: Mon, 24 Oct 2022 11:53:03 -0500 Message-Id: <20221024165310.246183-10-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024165310.246183-1-pierre-louis.bossart@linux.intel.com> References: <20221024165310.246183-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Cc: tiwai@suse.de, broonie@kernel.org, Bard Liao , Pierre-Louis Bossart , Ranjani Sridharan X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The hda_dsp_ctrl_link_reset() already performs a usleep and a check that GCTL has been modified, there's no point in waiting more. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Ranjani Sridharan --- sound/soc/sof/intel/hda-ctrl.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/sof/intel/hda-ctrl.c b/sound/soc/sof/intel/hda-ctrl.c index 0c29bb196e593..7f387ad5ef6f4 100644 --- a/sound/soc/sof/intel/hda-ctrl.c +++ b/sound/soc/sof/intel/hda-ctrl.c @@ -207,16 +207,12 @@ int hda_dsp_ctrl_init_chip(struct snd_sof_dev *sdev, bool full_reset) goto err; } - usleep_range(500, 1000); - /* exit HDA controller reset */ ret = hda_dsp_ctrl_link_reset(sdev, false); if (ret < 0) { dev_err(sdev->dev, "error: failed to exit HDA controller reset\n"); goto err; } - - usleep_range(1000, 1200); } #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)