From patchwork Tue Nov 15 12:02:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 625106 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2573C4332F for ; Tue, 15 Nov 2022 12:04:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 08A5E1699; Tue, 15 Nov 2022 13:03:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 08A5E1699 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1668513879; bh=pNqnYc7LPCO16eaETGeyhK87xkQ1+Etz1AAwSjTZj88=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DDvJf8+IUPLBBvIUKsg0EkCVEBXHe+g2gwQ9a7tRZ/LOFHoQx/1j/QH+jqUbNksTd 8XB9oIWoBrm0T85JLzsqqHCLYq+RMMm+OeaiV8rHDtgEY52t2+2gyyyh3x2I6Q/Kr+ D68jYj9/mYVV9WSy/dAaefmFbnkrj/b/BLCBUXJk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 9627AF80566; Tue, 15 Nov 2022 13:02:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AEC91F80563; Tue, 15 Nov 2022 13:02:57 +0100 (CET) Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 24976F80171 for ; Tue, 15 Nov 2022 13:02:49 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 24976F80171 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JPZ0fHXe" Received: by mail-lf1-x136.google.com with SMTP id r12so24081829lfp.1 for ; Tue, 15 Nov 2022 04:02:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R0wP3pJrxOd4FjAX8XSZyGxgmfCQJkYV5Ck9FfoWKRI=; b=JPZ0fHXec/ZF/rA3HkGmGyehGPHZM9rbEoGqsffUFGeQMmXp3Ney2ECVlRBTTvF/y8 +pNosN+QkbcBiSkN0rrBSyQm1+/aZ/Br74oxuIc7jpzoJmYpYifSyt/yRKa6+Scl9S3i l7+N7WnlJjjGqEHO10JkXKCo/o6X92wzYX2FRxZLf2O7+DlaOHsLUHWA+XoD+Jqtd69k lmmhz9hfz0Wee5smnR1Hgk8N78hQymSXnzbFfPWPBpOiQDlBbbOmHW2icdjsB1TKw11B 9eBeKB8IweOHAVAbbV9NJm2Vr3/BUddEON8gInLRZY8EeFhhlIb87NLlPU4v7HnQivBF mw5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R0wP3pJrxOd4FjAX8XSZyGxgmfCQJkYV5Ck9FfoWKRI=; b=tqrTdhuNv8sZc4OZzEWixEYXSHusP5t4bzrLOcMu4AVCLrLCrigK67ch75M1pH4frW cSEvDHfa3V04htLQODtENkgYPJCRQ/kYfcssHUzqH4v+zioedjKcxzgj85EjZuJEz5FB DzOrXf/8GhiDFKWu5YZuze9GxFHxth18ymL+2SLXqg+I1WnS6h2wbWXH/QcZ2p+ep6he ROZKYepqqzJTD9vc5Eoog0FNnt2gfw0bp1baWIYAjLSg9KP5oPfavJALxDkiaabP6S8F /Q7BT/D2NkgkhfQuH2Rth2/OQSYfEvHoWOocOmsymEjyBAt9NJ5T/y4RJ3nxPs5Bq1dD tKQw== X-Gm-Message-State: ANoB5plEsLJkUoGSciD/wgfLz/WTh8aLszgR9N5ZgcqJQQ9iFC3IXXpr 1xor+gtmf3xLj6pfdO7LfaVe/w== X-Google-Smtp-Source: AA0mqf5UI7DsIxp+KqIgTlBJuKyeNzWpW0asfBEJr2NReqjc3Tg+JWNZjnnWBNyOhqneIvVMq6Raig== X-Received: by 2002:ac2:58d5:0:b0:4a6:4e24:b2dc with SMTP id u21-20020ac258d5000000b004a64e24b2dcmr6403652lfo.456.1668513767694; Tue, 15 Nov 2022 04:02:47 -0800 (PST) Received: from krzk-bin.NAT.warszawa.vectranet.pl (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id i13-20020ac25d2d000000b004b0b2212315sm2176233lfb.121.2022.11.15.04.02.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Nov 2022 04:02:47 -0800 (PST) From: Krzysztof Kozlowski To: Srinivas Kandagatla , Banajit Goswami , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 03/11] ASoC: dt-bindings: qcom, apr: Correct and extend example Date: Tue, 15 Nov 2022 13:02:27 +0100 Message-Id: <20221115120235.167812-4-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221115120235.167812-1-krzysztof.kozlowski@linaro.org> References: <20221115120235.167812-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Cc: quic_plai@quicinc.com, Krzysztof Kozlowski , quic_srivasam@quicinc.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Correct the APR/GPR example: 1. Use consistent 4-space indentation, 2. Add required properties to services nodes, so the binding check passes once schema for these services is improved, 3. Add few other properties as APR/GPR is part of a GLINK edge: qcom,glink-channels and qcom,intents. 4. Drop unnecessary services, to make the example compact. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Rob Herring --- Changes since v1: 1. New patch. Cc: quic_srivasam@quicinc.com Cc: quic_plai@quicinc.com --- .../bindings/soc/qcom/qcom,apr.yaml | 61 ++++++++++++------- 1 file changed, 39 insertions(+), 22 deletions(-) diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml index 1fab1d9a2dad..4209c6314996 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml @@ -142,31 +142,35 @@ examples: apr { compatible = "qcom,apr-v2"; qcom,domain = ; + qcom,glink-channels = "apr_audio_svc"; + qcom,intents = <512 20>; #address-cells = <1>; #size-cells = <0>; q6core: service@3 { - compatible = "qcom,q6core"; - reg = ; - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + compatible = "qcom,q6core"; + reg = ; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; }; - q6afe: service@4 { - compatible = "qcom,q6afe"; - reg = ; - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; - }; - - q6asm: service@7 { - compatible = "qcom,q6asm"; - reg = ; - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; - }; - - q6adm: service@8 { - compatible = "qcom,q6adm"; - reg = ; - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + service@4 { + compatible = "qcom,q6afe"; + reg = ; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + + clock-controller { + compatible = "qcom,q6afe-clocks"; + #clock-cells = <2>; + }; + + dais { + compatible = "qcom,q6afe-dais"; + #address-cells = <1>; + #size-cells = <0>; + #sound-dai-cells = <1>; + /* ... */ + }; + /* ... */ }; }; @@ -175,12 +179,25 @@ examples: gpr { compatible = "qcom,gpr"; qcom,domain = ; + qcom,glink-channels = "adsp_apps"; + qcom,intents = <512 20>; #address-cells = <1>; #size-cells = <0>; service@1 { - compatible = "qcom,q6apm"; - reg = ; - qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + compatible = "qcom,q6apm"; + reg = ; + #sound-dai-cells = <0>; + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd"; + + dais { + compatible = "qcom,q6apm-dais"; + iommus = <&apps_smmu 0x1801 0x0>; + }; + + bedais { + compatible = "qcom,q6apm-lpass-dais"; + #sound-dai-cells = <1>; + }; }; };