From patchwork Wed Mar 15 15:06:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 663396 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44CE7C61DA4 for ; Wed, 15 Mar 2023 15:54:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 28C03155A; Wed, 15 Mar 2023 16:54:01 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 28C03155A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1678895691; bh=zLxnf1jUFU7w0MTv+EbqAy7vb5dDXijHl5zIUv9JeqA=; h=From:To:Subject:Date:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=ofirqqRr3KDF3ihnlwLZdYoUSirBytBeOcQeGR/wGWuDCnXRrodhg4FbHeFFbQ3KY 4/W7X5YqSEVHQv/XMSsTe/BypLz9buw2b+yOiIUc6lx1pGDress2TqwT6c6eL8yIlX WZ/bC/FVDsFCFHDF75uPtQgAusX+3SH5cUyzO6IU= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id E24BBF8972F; Wed, 15 Mar 2023 16:18:10 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CF0F2F8059F; Wed, 15 Mar 2023 16:11:04 +0100 (CET) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CF3F7F805AB for ; Wed, 15 Mar 2023 16:09:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CF3F7F805AB Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjn-0008Ij-JE; Wed, 15 Mar 2023 16:08:23 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjj-004KbR-UW; Wed, 15 Mar 2023 16:08:19 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjj-0057iH-00; Wed, 15 Mar 2023 16:08:19 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , Gongjun Song , Shuming Fan , Yong Zhi Subject: [PATCH 101/173] ASoC: Intel: sof_sdw: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:06:33 +0100 Message-Id: <20230315150745.67084-102-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1554; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zLxnf1jUFU7w0MTv+EbqAy7vb5dDXijHl5zIUv9JeqA=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd5dK73QSFMe1md0vSdRz2fUVGnuIHNz5Frco YaWRK79ZgmJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHeXQAKCRDB/BR4rcrs CQo3B/4vq0sSCwqYFGsWGx1LQYD8MlvHN761N4y+a7uZy4AHgCShey7GJv2pqk87IDv3nn+Mfi5 4BT1SwPg588I4iNX3Si5LUR9HFXwX8t3tH0/mlWKh7u/6xGZIzTBhnSyUlMAF+S+6SFOBJMzSjv WQgsYqezeHUg8xYzjusJKBP0WZweud97q1ZDK+wGivRoYjV6BY8PZbFijGB3FA31vjjo8LvR7zw +8bOXSndpl6u+urW/azK5FTPXyoa/0lfy0xlojGY3Nvw5fOGmZny8QBZ3uKhQfalaW+fJXx3TcE raqxRHACKZeU4yDew6U5DAXSn6psotdZClih2NRKgpLmOu61 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: alsa-devel@alsa-project.org Message-ID-Hash: 7ZQXTNDKEPQCKRTGW2O2ORLNCJ4LAE6L X-Message-ID-Hash: 7ZQXTNDKEPQCKRTGW2O2ORLNCJ4LAE6L X-MailFrom: ukl@pengutronix.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, kernel@pengutronix.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/soc/intel/boards/sof_sdw.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/intel/boards/sof_sdw.c b/sound/soc/intel/boards/sof_sdw.c index d2ed807abde9..4ea69197791c 100644 --- a/sound/soc/intel/boards/sof_sdw.c +++ b/sound/soc/intel/boards/sof_sdw.c @@ -1602,13 +1602,11 @@ static int mc_probe(struct platform_device *pdev) return ret; } -static int mc_remove(struct platform_device *pdev) +static void mc_remove(struct platform_device *pdev) { struct snd_soc_card *card = platform_get_drvdata(pdev); mc_dailink_exit_loop(card); - - return 0; } static struct platform_driver sof_sdw_driver = { @@ -1617,7 +1615,7 @@ static struct platform_driver sof_sdw_driver = { .pm = &snd_soc_pm_ops, }, .probe = mc_probe, - .remove = mc_remove, + .remove_new = mc_remove, }; module_platform_driver(sof_sdw_driver);