From patchwork Mon Jun 17 07:28:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijendar Mukunda X-Patchwork-Id: 806775 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FE04C27C77 for ; Mon, 17 Jun 2024 07:33:08 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C64DAA4B; Mon, 17 Jun 2024 09:32:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C64DAA4B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1718609585; bh=ag9+cpmriUp5rqB9HVXP/zFzmxUzmX+ELNNavcFosuw=; h=From:To:CC:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=MxB+zTNuTmmU2RG7XxbxJqnjQvhEr4Z7a761j/o/XCsIWB/2HNV/s1lZWPYePFqTm GT74Isy877bK+yhTzSwLH7JFUj995toRn7Z3rjPR+BwCk5a6Ayjdg+OCf0dmQktVHp E0dbzVFQjh8rZ2B+4tlPEv9VaXAxmr8DnlPHlRik= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4187EF805E9; Mon, 17 Jun 2024 09:32:06 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5BEEBF805F3; Mon, 17 Jun 2024 09:32:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DF581F80266; Mon, 17 Jun 2024 09:29:13 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20600.outbound.protection.outlook.com [IPv6:2a01:111:f403:2415::600]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0823AF800ED for ; Mon, 17 Jun 2024 09:29:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0823AF800ED Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=qAV48hqQ ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L2ix8LpdDpGqM+ywbuhjJK8RG4sh9XGYXQCwmlkqSAVqYqBdjNXk+Nn5bMZtChEwnB7kjAILLFCF9NVAjAko7c36fVJOieR1EAZ1XOyIHSvPXe/56upn2G4PWdj9CIVz8BpQyIcA3pemMy52m5ynG4UDo2DtSRIv8tYEfswAQft+lls60sCU2N5V0qvQe6yD0oBXAgC8BvGuyxbcYQDkvkMoaB1GB30snZfQujmpRLwIoqoCHYKvXXFjlzZNoDiHtwm++RPLqdA5e1PsssD6cVyRJoHbgw9zfnLo4yd6rcWkozvbx/SJ2F+qPSL2ho2sO/svWa53/98ylLY6rJ3grg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zs3hEKcQKwvZr7AiQAv+IHIFyPBF7+j9KMX499DrjAE=; b=IZlpYxlbYs6J0L4e4UACc6DhjgE/ITa+gLQQT+Qf0N/OPtxwZyyUtfqeBdmnCeDPTUGRKJnkdTTbO6GUzWbPALoZ6AsNbl1ZJ3M/IKiJ6dPddfRRlfWEqkv01MY32kgK83QQOoKLjT7OcoH+j4LLL2OT0mahGHFiCyOpH3FCYpyzLq67Savwsg3POIuoSwWlrFanr2IyYyu0+Wod1+u41GcBhOHlFIuouOkuTv5t7izraSqYeApxOAeDzEnz4EbcIiKFapp5edgvJ7H1HI0Jy3IpBcsE563Ij1g2UqdPUT53dP4Yp0XPr9pv3TruGB8I6ySMFSfxQEfcJkVv9yqmHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=kernel.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zs3hEKcQKwvZr7AiQAv+IHIFyPBF7+j9KMX499DrjAE=; b=qAV48hqQDWSVJZiZDnThMiFFvnGYanYYuZBC86BTp/n3CTYsnCw0oFIUKlQl94MALx8+CzO7pZp4dP4GJTwGoXxnEAlqw0LBl9i5ZHl0FGrzHhAy10YwKCDwyxrUHyX4RnV5VHMNeBo4kBRALO2d0QwmCxWfKw5Bq6ZAAAO1SQA= Received: from PH7P220CA0055.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::8) by DM4PR12MB8476.namprd12.prod.outlook.com (2603:10b6:8:17e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.28; Mon, 17 Jun 2024 07:29:00 +0000 Received: from CY4PEPF0000EE3B.namprd03.prod.outlook.com (2603:10b6:510:32b:cafe::fd) by PH7P220CA0055.outlook.office365.com (2603:10b6:510:32b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30 via Frontend Transport; Mon, 17 Jun 2024 07:29:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000EE3B.mail.protection.outlook.com (10.167.242.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7677.15 via Frontend Transport; Mon, 17 Jun 2024 07:28:59 +0000 Received: from SATLEXMB05.amd.com (10.181.40.146) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Jun 2024 02:28:55 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB05.amd.com (10.181.40.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Mon, 17 Jun 2024 02:28:55 -0500 Received: from vijendar-X570-GAMING-X.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2507.39 via Frontend Transport; Mon, 17 Jun 2024 02:28:51 -0500 From: Vijendar Mukunda To: CC: , , , , "Vijendar Mukunda" , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , "Syed Saba Kareem" , Kuninori Morimoto , V sujith kumar Reddy , "open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: [PATCH 2/8] ASoC: amd: acp: remove i2s configuration check in acp_i2s_probe() Date: Mon, 17 Jun 2024 12:58:35 +0530 Message-ID: <20240617072844.871468-2-Vijendar.Mukunda@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240617072844.871468-1-Vijendar.Mukunda@amd.com> References: <20240617072844.871468-1-Vijendar.Mukunda@amd.com> MIME-Version: 1.0 Received-SPF: None (SATLEXMB05.amd.com: Vijendar.Mukunda@amd.com does not designate permitted sender hosts) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EE3B:EE_|DM4PR12MB8476:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b08c32e-b231-4824-1f64-08dc8e9f27cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230037|376011|36860700010|1800799021|82310400023; X-Microsoft-Antispam-Message-Info: a4AEZCuXVHFIyeH4bpUiRcpT790nQM1rohnuNb4CMXFowtBFv/BAN9r2Cgw5dR/P44bEfqsEoWhnb8zvd/zcNOGRKk+y8C6dKdLqQZ/NwbBavFThQY04ZyFDHYn3ViPd3K/HdunKQIEVatvBnj4XccUZPUkF4ysmlCHwlTqgRB9zvB5IMozYuLQUS9i5vP/RHE64LkVC59JNX6z20J6d0TZSVfox01lQ7ayFf74FRZzGnTmP0F71Ogm//21WMrr7InkmAI8NeSCc+eoOT9DLwvVhaeBqkAUx5Pn4dfviKxOFloUiLAsencvkfmxm/w4mi6PBF0d75SyxApvoOMpihJx3nM5QarVOJI7fQvcRU47YDUhqkjbkFTPu7xxRgkQEQ4B/XH4T0ftFfo0QLZGhzpbfE0ajLOjmGcBs+R6IUPNvxtRv1Y/ijNTFvD+6pXDTV2EaOQ2LQlq2U6AdASx7a8qTY8uxP6k7X1xcR/b8kJIhZlZ+8ebe/06iQJloQ4Efw/LQ48nx677HwCfCndAdqTw9tpeQiPss6RgEUdrhM42q4rcy1K9Ucf92zvExDuxhlK5tmS641Uml/oWm5NnpPt98thXl1nCJvn0BzVMI/7spJDEozQZ86S4U9tgC3QlFVmdYk5g0KAxtrauuWHro97PscaqlWmrTOKID3wr0TP5Y2rtKNnroFyWa/HNvNNWnADn8ioffrqrululgVLL6191UJ8NNEWm00HY1T+7B9WQcYVt0wPtbmyYo/yGEyJQuGhwLTpkkIx82i/c6ZPlP6a/VIQR5v3qz5weqhStQC11zOz7UNdHS0j35FT8n96v6VO82HqVHUA1BiR9IZE4haFlE1acysLYFPaCabfMcGJ9UIspliEXCFLzmJyU/Q1gtACjvRpWevQMwIeCZpEsIFfvp0W4yHRrWnnTI9GJ1kXYRIyTtB8xsc6u7GIvwHSNLJaiC7TnF8gVe5m5um96eI4eat7fVE2YDBwtSGMCBXnKfp6P0m7IgZt+h9K9gBueM4o0PoCLVIM1TP0TULBgt2pPCXHJ7unonkBU3Gor4mZLl1+5Ucnr5pCaJMTma/4d3RlGZdb8SD/2btWtHZPdEu+dNWRhyrkFI6OXNWuElyYC4GnLnA+5nYc9ZVktTcjyihRb+GSkwJdvy1xCSFnKIYZfWifMwXIqyYhx8T/dz97HmB8yy0zauTI77m3Kost5Or4nThJzyHatYt6P4Tz09rxXcMchuJVe4PN/0HkmJbjQqmxCvzRTrzwKDxtitHASG/yJoRfTuY1GqqSgVeityVJcVj3+yIWVcfo7wwWdXeswENNHnVSmmdbL8fJxnaJxeirne3v13/ZeSttDVfXOkUtrlJ8GHaC+JJ16RMg6ylKcu/kyB4t0NupBZyuTkMh3s/KraQ6F7VUjFJ/jwTNrruw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230037)(376011)(36860700010)(1800799021)(82310400023); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2024 07:28:59.7085 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b08c32e-b231-4824-1f64-08dc8e9f27cb X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EE3B.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB8476 Message-ID-Hash: PLUW47TABTYSI4EH2OYDSCU3FJNX5NMS X-Message-ID-Hash: PLUW47TABTYSI4EH2OYDSCU3FJNX5NMS X-MailFrom: Vijendar.Mukunda@amd.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ACP supports different pin configurations for I2S IO. Checking ACP pin configuration value against specific value breaks the functionality for other I2S pin configurations. This check is no longer required in i2s dai driver probe call as i2s configuration check will be verified during acp platform device creation sequence. Remove i2s_mode check in acp_i2s_probe() function. Fixes: b24484c18b10 ("ASoC: amd: acp: ACP code generic to support newer platforms") Signed-off-by: Vijendar Mukunda --- sound/soc/amd/acp/acp-i2s.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c index 60cbc881be6e..ef12f97ddc69 100644 --- a/sound/soc/amd/acp/acp-i2s.c +++ b/sound/soc/amd/acp/acp-i2s.c @@ -588,20 +588,12 @@ static int acp_i2s_probe(struct snd_soc_dai *dai) { struct device *dev = dai->component->dev; struct acp_dev_data *adata = dev_get_drvdata(dev); - struct acp_resource *rsrc = adata->rsrc; - unsigned int val; if (!adata->acp_base) { dev_err(dev, "I2S base is NULL\n"); return -EINVAL; } - val = readl(adata->acp_base + rsrc->i2s_pin_cfg_offset); - if (val != rsrc->i2s_mode) { - dev_err(dev, "I2S Mode not supported val %x\n", val); - return -EINVAL; - } - return 0; }