From patchwork Wed Jun 21 11:16:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 106067 Delivered-To: patch@linaro.org Received: by 10.140.91.2 with SMTP id y2csp1872252qgd; Wed, 21 Jun 2017 04:16:48 -0700 (PDT) X-Received: by 10.223.170.75 with SMTP id q11mr3048351wrd.72.1498043808432; Wed, 21 Jun 2017 04:16:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1498043808; cv=none; d=google.com; s=arc-20160816; b=gZLyJYPwAo9DxputKdDRzWvI2kb5NGkYPbqtN+lFONWIXVN0EsAmXUMIvSa4jiGYpb 9s6t1I7lYz4z/Y3Rir9Cbr/uOLqFUpxah/IAeqqr5D3vckfDDC6Stl2SswFcYs3L8Fse YaIDFumo2/uVocZCn02s9vx/7fH9DRkMx5b3unSeRowVqq/eMVtwOffNQTo5hGZ0O+ZR pi2HMDEcdRz2sDG7LbSHz+62g7oVoJiXtkMOij+USEuh/OgEeQVc0ChuLgmq7K0kKwLK TVltipuV1p60H2Vs/343GqHsk+VDZnaebaxn12sBuxFseUeZrt9o6Ij39r2rcCK2J33T pDjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=CJnqU1cHXH+lqsT3Df0EWQK8NiFKhYWlzLIFns1Dc3U=; b=Lkzic12rB+xbiWPXZUKWMuyrLRjK7PMEn8H0BREvMDZSeyEJSFSjkoD7si0wTk5P76 PUvuoyH50JCch36AT7wq3jPHPl2JiDp8J82+E6ghA3j7R0m5WzTpNuJLmm9rY+x4qNb9 opFxNu1bCLbkOwI9VVflxsISjzCi/Y8IQwgxjJquhV+Kb3qvjO2eppcC8z4i1I8BZUF9 9zUtoO1r7my7QMkhfIjHZAEXNGZt4HCTiI2TeyhSVbCo4/Z7ne0rhA6NHdpDRsFJEub/ XDcCIwJisvPuP2nb5M1cPnUqGaqD1HJXmimAol5Tv81x17AkymQETvvnA3NpLaU5t24e HPSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id b195si17289255wmf.110.2017.06.21.04.16.48; Wed, 21 Jun 2017 04:16:48 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id C9626266C2E; Wed, 21 Jun 2017 13:16:45 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 82E33266C31; Wed, 21 Jun 2017 13:16:44 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE, SPF_PASS, T_RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 9FB762668F0 for ; Wed, 21 Jun 2017 13:16:40 +0200 (CEST) Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dNdcb-0007Am-Hj; Wed, 21 Jun 2017 11:16:32 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1dNdcY-0004BP-GK; Wed, 21 Jun 2017 12:16:26 +0100 From: Mark Brown To: Kuninori Morimoto In-Reply-To: <87o9toiz2p.wl%kuninori.morimoto.gx@renesas.com> Message-Id: Date: Wed, 21 Jun 2017 12:16:26 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: linux-renesas-soc@vger.kernel.org, Julia Lawall , alsa-devel@alsa-project.org, Mark Brown , Simon Subject: [alsa-devel] Applied "ASoC: rsnd: fixup unsigned expression compared with zero: main_rate" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: rsnd: fixup unsigned expression compared with zero: main_rate has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 947f4eb58d2054b10a1d8146d0ab90b0e7fd3494 Mon Sep 17 00:00:00 2001 From: Kuninori Morimoto Date: Fri, 16 Jun 2017 00:02:59 +0000 Subject: [PATCH] ASoC: rsnd: fixup unsigned expression compared with zero: main_rate This patch fixes this WARNING sound/soc/sh/rcar/ssi.c:285:5-14: WARNING: Unsigned expression\ compared with zero: main_rate < 0 Signed-off-by: Kuninori Morimoto Signed-off-by: Mark Brown --- sound/soc/sh/rcar/core.c | 2 +- sound/soc/sh/rcar/rsnd.h | 2 +- sound/soc/sh/rcar/ssi.c | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) -- 2.11.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/sh/rcar/core.c b/sound/soc/sh/rcar/core.c index 4892c0a4b613..409bac331d27 100644 --- a/sound/soc/sh/rcar/core.c +++ b/sound/soc/sh/rcar/core.c @@ -763,7 +763,7 @@ static int rsnd_soc_hw_rule(struct rsnd_priv *priv, struct snd_interval *baseline, struct snd_interval *iv) { struct snd_interval p; - int rate; + unsigned int rate; int i; snd_interval_any(&p); diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h index 9428d4e288dd..99c57611df88 100644 --- a/sound/soc/sh/rcar/rsnd.h +++ b/sound/soc/sh/rcar/rsnd.h @@ -680,7 +680,7 @@ int __rsnd_ssi_is_pin_sharing(struct rsnd_mod *mod); void rsnd_parse_connect_ssi(struct rsnd_dai *rdai, struct device_node *playback, struct device_node *capture); -int rsnd_ssi_clk_query(struct rsnd_priv *priv, +unsigned int rsnd_ssi_clk_query(struct rsnd_priv *priv, int param1, int param2, int *idx); /* diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c index c8956c3484dd..46feddd78ee2 100644 --- a/sound/soc/sh/rcar/ssi.c +++ b/sound/soc/sh/rcar/ssi.c @@ -208,14 +208,14 @@ u32 rsnd_ssi_multi_slaves_runtime(struct rsnd_dai_stream *io) return 0; } -int rsnd_ssi_clk_query(struct rsnd_priv *priv, +unsigned int rsnd_ssi_clk_query(struct rsnd_priv *priv, int param1, int param2, int *idx) { int ssi_clk_mul_table[] = { 1, 2, 4, 8, 16, 6, 12, }; int j, ret; - int main_rate; + unsigned int main_rate; for (j = 0; j < ARRAY_SIZE(ssi_clk_mul_table); j++) { @@ -245,7 +245,7 @@ int rsnd_ssi_clk_query(struct rsnd_priv *priv, return main_rate; } - return -EINVAL; + return 0; } static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod, @@ -282,7 +282,7 @@ static int rsnd_ssi_master_clk_start(struct rsnd_mod *mod, } main_rate = rsnd_ssi_clk_query(priv, rate, chan, &idx); - if (main_rate < 0) { + if (!main_rate) { dev_err(dev, "unsupported clock rate\n"); return -EIO; }