From patchwork Mon Jul 17 16:06:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 108013 Delivered-To: patch@linaro.org Received: by 10.140.101.44 with SMTP id t41csp4711849qge; Mon, 17 Jul 2017 09:13:33 -0700 (PDT) X-Received: by 10.28.95.137 with SMTP id t131mr4652738wmb.102.1500308013811; Mon, 17 Jul 2017 09:13:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1500308013; cv=none; d=google.com; s=arc-20160816; b=YtBT03niCUwmHbgBFuwXtksTxRnEt3x5VHoT8w0mJKBehJ2Vk5H3dxa9LVFwU8BVtm wk11tbkWc4u+sk2QbjMDRACTDmsvfF9BqYdeKAtCUvcCq0+cXhz2t575rO+qm11yb8fv g53yKcNmfduCWBdQk4QlfH50SB1ZBoFtISPtPkcNxsAgtlNoga5qsK4ILpb7ZXFxGTJl yAuelvPa7XVDOaYYS989+gmRc/EC2UgfzwYSQqDTF2/gXUC6u4Exl+kaW5hK0Txs58pJ GPPQkhoMvhqSYcuepxGMFEo/uA/cto7hzdbB+flFMwEHTKUeBczjJwpIWs4t7c5GD/dX z8pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=sWN+hrtWtgS9yhJX3mNc9XcNUaDOVHxeIMInL63kK9k=; b=dVoTcHFe8zpHUxzmFnJPHeDIYbINCLn7c22ApoGyfRJKA6CJaMfWYkgWloY0LcK5s3 StyFLctsl2Wy4UOORNbuyVe0Y9gqH855V+SW2Zf2ISH50d727HZqLoWcoy5kK2HR7aew ASBJbdO2HDjSutUOaUhgan6yVn4dG5dmQ+q0/gJS8rDr22psbjcHAxr2Hi+cM+Ute75i MaNKV3PxAoIEdaVQuXa8pghk2kX9sVzqxnFHPPF3kRoXGNp7wxud3wfoerpnqaLyjWsb UBt/qteXl6FMg0SJh1uy0J8deq3IHAEZJ+JeL/2rxOWpbQdfHkK8tz9lKYCDFbr/3Qow jIaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id p64si10296296wma.190.2017.07.17.09.13.33; Mon, 17 Jul 2017 09:13:33 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 122D52674F8; Mon, 17 Jul 2017 18:07:24 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 86F0C2674E2; Mon, 17 Jul 2017 18:07:20 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 71D40267439 for ; Mon, 17 Jul 2017 18:06:12 +0200 (CEST) Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1dX8X9-0002su-7r; Mon, 17 Jul 2017 16:06:09 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1dX8X6-0004zQ-O2; Mon, 17 Jul 2017 17:06:04 +0100 From: Mark Brown To: Fabio Estevam In-Reply-To: <1500239473-14886-3-git-send-email-festevam@gmail.com> Message-Id: Date: Mon, 17 Jul 2017 17:06:04 +0100 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: alsa-devel@alsa-project.org, broonie@kernel.org Subject: [alsa-devel] Applied "ASoC: adau1977: Remove unneeded gpiod NULL check" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: adau1977: Remove unneeded gpiod NULL check has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 68feed90070e5133c0bfe26648410a39e092018d Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Sun, 16 Jul 2017 18:11:08 -0300 Subject: [PATCH] ASoC: adau1977: Remove unneeded gpiod NULL check The gpiod API checks for NULL descriptors, so there is no need to duplicate the check in the driver. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown --- sound/soc/codecs/adau1977.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.13.2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/adau1977.c b/sound/soc/codecs/adau1977.c index b319db6a69f8..ccc5cf0e4f80 100644 --- a/sound/soc/codecs/adau1977.c +++ b/sound/soc/codecs/adau1977.c @@ -388,8 +388,7 @@ static int adau1977_power_disable(struct adau1977 *adau1977) regcache_mark_dirty(adau1977->regmap); - if (adau1977->reset_gpio) - gpiod_set_value_cansleep(adau1977->reset_gpio, 0); + gpiod_set_value_cansleep(adau1977->reset_gpio, 0); regcache_cache_only(adau1977->regmap, true); @@ -420,8 +419,7 @@ static int adau1977_power_enable(struct adau1977 *adau1977) goto err_disable_avdd; } - if (adau1977->reset_gpio) - gpiod_set_value_cansleep(adau1977->reset_gpio, 1); + gpiod_set_value_cansleep(adau1977->reset_gpio, 1); regcache_cache_only(adau1977->regmap, false);