From patchwork Tue Sep 14 11:08:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Dobriyan X-Patchwork-Id: 510962 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D037BC433F5 for ; Tue, 14 Sep 2021 11:09:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3191260FC1 for ; Tue, 14 Sep 2021 11:09:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3191260FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C7A8176C; Tue, 14 Sep 2021 13:08:57 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C7A8176C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1631617787; bh=3y90Ii6/0rKNvYQVTGRMsBA0g6JHYMGWHr9qvqX6SHI=; h=Date:From:To:Subject:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=FQIxlGngnoXjjz2awq/iI2kiu3WrMD4eLjr1wsS0jYcEnbw1vZf6Zk+P1lzKnCPgJ w/abNoRO95+MlaDFjPmj+YYkPDw9m+Bjzcg4Sj44+8t+JuBPPJOXOIE9o4YEBNVzI2 lFEPvZ56Rh5x9qYLuOpbN6Kft4HgBodMurDj5OFE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 81BD8F8025A; Tue, 14 Sep 2021 13:08:56 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 54507F8025E; Tue, 14 Sep 2021 13:08:54 +0200 (CEST) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id D358EF80169 for ; Tue, 14 Sep 2021 13:08:49 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz D358EF80169 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a7zytFvy" Received: by mail-ej1-x629.google.com with SMTP id qq21so22105248ejb.10 for ; Tue, 14 Sep 2021 04:08:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=3aP8/NSGA13GglmYH3br7YEMqiCNqexuws33nLMuqlQ=; b=a7zytFvyTmVlXWm+vz6mNN6DOVexJtmZTQSZlkpfDCJbANURijLJsreLQTu+5yabZZ yNtr/8DSaFJY+RHv4FJNvnjSDw5jGGwi1cWesRvtPk74dps4egoGNLCgdWt/0JBn1KFF 8+ztvHY1xPOPtMM2SOg8Dihedk2TqgMdvopomeGKLwsVXPVRqO6GbIvycU0NZ8q7XUGm Je+Tq7OLlthROgBKytQwmRFw5gk8dYL4x9lVRHuIPqLbdvxjMITbEhTI5WGnOQxi0XWT Ym4Xd3F6PQebLlMeG0d5nl9WXUIeQKuXH08nm+opw60AlP5XGKDUu4mecOm8tID3nfYl YbBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=3aP8/NSGA13GglmYH3br7YEMqiCNqexuws33nLMuqlQ=; b=u7+Lu2tm+UprAHtr9DhYsHPLuLH/OfegwHRKklymaIm611BkCXd0OK+TM+bs9u542q eTKkcj5tD/9z5yBmMByT/wseV23BDzmLmdibNXIc1Br/FClV5K4Ss7U5DMOuhqviR6gd dU3YJFqd1rvivUfCAoxMeiOng1xl3JI0X4rbnGM1UGL1eHuzIEVqYZZxLlgybB2BQzrK 7ojb5iuMFo96zozwQQ9ar6VISrjh7DI+VN8iRZ0sSNpMWm3SyoxXhWjn4AWRy+Im+fA4 YmhEtieR8oGL5p1uMojradVtBiEXV5gFePbRpLo7pazIabmiYe/Jyi7g1Ln2psQ9/HrU YZgA== X-Gm-Message-State: AOAM531tna/vuO+38/nnjOXPzhGtwG34bHK1uN08+eaZ5YyJmraQwCW3 McrTjZEgbyDinKDg51hzveMIJgyqcA== X-Google-Smtp-Source: ABdhPJyn2/OvNrI4Dnn0d2Q6VIPy4QPZDExR9kxxZaXH8Cjn2hvwLvS8EI01fbNVwj2ZCEwJLtYk3A== X-Received: by 2002:a17:906:ae9b:: with SMTP id md27mr16870075ejb.380.1631617729338; Tue, 14 Sep 2021 04:08:49 -0700 (PDT) Received: from localhost.localdomain ([46.53.249.181]) by smtp.gmail.com with ESMTPSA id t24sm5085274edr.84.2021.09.14.04.08.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Sep 2021 04:08:48 -0700 (PDT) Date: Tue, 14 Sep 2021 14:08:47 +0300 From: Alexey Dobriyan To: tiwai@suse.de Subject: [PATCH] pcxhr: "fix" PCXHR_REG_TO_PORT definition Message-ID: MIME-Version: 1.0 Content-Disposition: inline Cc: alsa-devel@alsa-project.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The following preprocessor directive is non-compliant: #undef PCXHR_REG_TO_PORT(x) gcc warns about extra tokens but nobody sees them as they are under if branch which is never parsed. Make it an #error, it is not clear to me what the author meant. Signed-off-by: Alexey Dobriyan --- sound/pci/pcxhr/pcxhr_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/pci/pcxhr/pcxhr_core.c +++ b/sound/pci/pcxhr/pcxhr_core.c @@ -52,7 +52,7 @@ #define PCXHR_DSP 2 #if (PCXHR_DSP_OFFSET_MAX > PCXHR_PLX_OFFSET_MIN) -#undef PCXHR_REG_TO_PORT(x) +#error PCXHR_REG_TO_PORT(x) #else #define PCXHR_REG_TO_PORT(x) ((x)>PCXHR_DSP_OFFSET_MAX ? PCXHR_PLX : PCXHR_DSP) #endif