| Message ID | 20240823200819.532106-1-dhowells@redhat.com |
|---|---|
| Headers | show |
| Series | netfs, cifs: Combined repost of fixes for truncation, DIO read and read-retry | expand |
On Fri, 23 Aug 2024 21:08:08 +0100, David Howells wrote: > Firstly, there are some fixes for truncation, netfslib and afs that I > discovered whilst trying Pankaj Raghav's minimum folio order patchset: > > (1) Fix truncate to make it honour AS_RELEASE_ALWAYS in a couple of places > that got missed. > > (2) Fix duplicated editing of a partially invalidated folio in afs's > post-setattr edit phase. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/9] mm: Fix missing folio invalidation calls during truncation https://git.kernel.org/vfs/vfs/c/0aa2e1b2fb7a [2/9] afs: Fix post-setattr file edit to do truncation correctly https://git.kernel.org/vfs/vfs/c/a74ee0e878e2 [3/9] netfs: Fix netfs_release_folio() to say no if folio dirty https://git.kernel.org/vfs/vfs/c/7dfc8f0c6144 [4/9] netfs: Fix trimming of streaming-write folios in netfs_inval_folio() https://git.kernel.org/vfs/vfs/c/cce6bfa6ca0e [5/9] netfs: Fix missing iterator reset on retry of short read https://git.kernel.org/vfs/vfs/c/950b03d0f664 [10/10] netfs: Fix interaction of streaming writes with zero-point tracker https://git.kernel.org/vfs/vfs/c/e00e99ba6c6b
Hi Christian, Steve, Firstly, there are some fixes for truncation, netfslib and afs that I discovered whilst trying Pankaj Raghav's minimum folio order patchset: (1) Fix truncate to make it honour AS_RELEASE_ALWAYS in a couple of places that got missed. (2) Fix duplicated editing of a partially invalidated folio in afs's post-setattr edit phase. (3) Fix netfs_release_folio() to indicate that the folio is busy if the folio is dirty (as does iomap). (4) Fix the trimming of a folio that contain streaming-write data when truncation occurs into or past that folio Here's a patch to netfs for short reads: (5) Fix netfslib's short read retry to reset the buffer iterator otherwise the wrong part of the buffer may get written on. Here are a couple of fixes to DIO read handling and the retrying of reads, particularly in relation to cifs. They have both had some fixes to the fixes rolled in: (6) Fix the missing credit renegotiation in cifs on the retrying of reads. The credits we had ended with the original read (or the last retry) and to perform a new read we need more credits otherwise the server can reject our read with EINVAL. (7) Fix the handling of short DIO reads to avoid ENODATA when the read retry tries to access a portion of the file after the EOF. Here's a fix for hole punching in cifs: (8) Fix cifs FALLOC_FL_PUNCH_HOLE support as best I can. If it's going to punch a hole in dirty data in the pagecacne, invalidating that data may result in the EOF not being moved correctly. The set-zero and the eof-move RPC ops really need compounding to avoid third-party interference. And finally, here's an adjustment to debugging statements: (9) Adjust three debugging output statements. Not strictly a fix, so could be dropped. Including the subreq ID in some extra debug lines helps a bit, though. The patches can also be found here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=netfs-fixes They're on top of part of Christian's vfs.fixes tree, including the partial reversion of the commit to replace PG_fscache. Thanks, David David Howells (9): mm: Fix missing folio invalidation calls during truncation afs: Fix post-setattr file edit to do truncation correctly netfs: Fix netfs_release_folio() to say no if folio dirty netfs: Fix trimming of streaming-write folios in netfs_inval_folio() netfs: Fix missing iterator reset on retry of short read cifs: Fix lack of credit renegotiation on read retry netfs, cifs: Fix handling of short DIO read cifs: Fix FALLOC_FL_PUNCH_HOLE support netfs, cifs: Improve some debugging bits fs/afs/inode.c | 11 ++++++--- fs/netfs/io.c | 22 +++++++++++------ fs/netfs/misc.c | 53 ++++++++++++++++++++++++++++------------ fs/smb/client/cifsglob.h | 1 + fs/smb/client/file.c | 37 +++++++++++++++++++++++++--- fs/smb/client/smb2ops.c | 32 +++++++++++++++++++++--- fs/smb/client/smb2pdu.c | 41 +++++++++++++++++++------------ fs/smb/client/trace.h | 1 + include/linux/netfs.h | 1 + mm/truncate.c | 4 +-- 10 files changed, 153 insertions(+), 50 deletions(-)