From patchwork Mon Mar 21 03:42:16 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 690 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:44:43 -0000 Delivered-To: patches@linaro.org Received: by 10.220.28.198 with SMTP id n6cs113067vcc; Sun, 20 Mar 2011 20:39:41 -0700 (PDT) Received: by 10.231.83.82 with SMTP id e18mr3749058ibl.70.1300678780839; Sun, 20 Mar 2011 20:39:40 -0700 (PDT) Received: from mail-iy0-f178.google.com (mail-iy0-f178.google.com [209.85.210.178]) by mx.google.com with ESMTPS id 12si13304538ibo.100.2011.03.20.20.39.40 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Mar 2011 20:39:40 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.178 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) client-ip=209.85.210.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.178 is neither permitted nor denied by best guess record for domain of shawn.guo@linaro.org) smtp.mail=shawn.guo@linaro.org Received: by mail-iy0-f178.google.com with SMTP id 12so7491273iyi.37 for ; Sun, 20 Mar 2011 20:39:40 -0700 (PDT) Received: by 10.42.180.3 with SMTP id bs3mr5377749icb.134.1300678780076; Sun, 20 Mar 2011 20:39:40 -0700 (PDT) Received: from localhost.localdomain ([114.216.149.123]) by mx.google.com with ESMTPS id g17sm1130508ibb.40.2011.03.20.20.39.33 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 20 Mar 2011 20:39:39 -0700 (PDT) From: Shawn Guo To: devicetree-discuss@lists.ozlabs.org Cc: grant.likely@secretlab.ca, linaro-dev@lists.linaro.org, patches@linaro.org, Shawn Guo Subject: [PATCH 3/5] mmc: sdhci: make sdhci-dove driver self registered Date: Mon, 21 Mar 2011 11:42:16 +0800 Message-Id: <1300678938-8046-4-git-send-email-shawn.guo@linaro.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1300678938-8046-1-git-send-email-shawn.guo@linaro.org> References: <1300678938-8046-1-git-send-email-shawn.guo@linaro.org> The patch adds sdhci-dove its own .probe and .remove which in turn call into the common functions provided by sdhci-pltfm.c, so that sdhci-dove driver registers itself and keep all sdhci-dove specific things like sdhci_dove_pdata away from sdhci-pltfm.c which is common. Signed-off-by: Shawn Guo --- drivers/mmc/host/sdhci-dove.c | 70 ++++++++++++++++++++++++++++++++++++++- drivers/mmc/host/sdhci-pltfm.c | 3 -- drivers/mmc/host/sdhci-pltfm.h | 1 - 3 files changed, 68 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci-dove.c b/drivers/mmc/host/sdhci-dove.c index 2aeef4f..e985338 100644 --- a/drivers/mmc/host/sdhci-dove.c +++ b/drivers/mmc/host/sdhci-dove.c @@ -3,7 +3,7 @@ * * Author: Saeed Bishara * Mike Rapoport - * Based on sdhci-cns3xxx.c + * Based on sdhci-dove.c * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -61,10 +61,76 @@ static struct sdhci_ops sdhci_dove_ops = { .read_l = sdhci_dove_readl, }; -struct sdhci_pltfm_data sdhci_dove_pdata = { +static struct sdhci_pltfm_data sdhci_dove_pdata = { .ops = &sdhci_dove_ops, .quirks = SDHCI_QUIRK_NO_SIMULT_VDD_AND_POWER | SDHCI_QUIRK_NO_BUSY_IRQ | SDHCI_QUIRK_BROKEN_TIMEOUT_VAL | SDHCI_QUIRK_FORCE_DMA, }; + +static int __devinit sdhci_dove_probe(struct platform_device *pdev) +{ + struct sdhci_host *host; + int ret; + + host = sdhci_pltfm_init(pdev, &sdhci_dove_pdata); + if (!host) + return -ENOMEM; + + ret = sdhci_add_host(host); + if (ret) + goto err_add_host; + + return 0; + +err_add_host: + sdhci_pltfm_free(pdev); + return ret; +} + +static int __devexit sdhci_dove_remove(struct platform_device *pdev) +{ + struct sdhci_host *host = platform_get_drvdata(pdev); + int dead = 0; + u32 scratch; + + scratch = readl(host->ioaddr + SDHCI_INT_STATUS); + if (scratch == (u32)-1) + dead = 1; + + sdhci_remove_host(pdev, dead); + sdhci_pltfm_free(pdev); + + return 0; +} + +static struct platform_driver sdhci_dove_driver = { + .driver = { + .name = "sdhci-dove", + .owner = THIS_MODULE, + }, + .probe = sdhci_dove_probe, + .remove = __devexit_p(sdhci_dove_remove), +#ifdef CONFIG_PM + .suspend = sdhci_pltfm_suspend, + .resume = sdhci_pltfm_resume, +#endif +}; + +static int __init sdhci_dove_init(void) +{ + return platform_driver_register(&sdhci_dove_driver); +} + +static void __exit sdhci_dove_exit(void) +{ + platform_driver_unregister(&sdhci_dove_driver); +} + +module_init(sdhci_dove_init); +module_exit(sdhci_dove_exit); + +MODULE_DESCRIPTION("SDHCI driver for Dove"); +MODULE_AUTHOR("Saeed Bishara "); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c index b9a904d..c4bba33 100644 --- a/drivers/mmc/host/sdhci-pltfm.c +++ b/drivers/mmc/host/sdhci-pltfm.c @@ -272,9 +272,6 @@ static int __devexit sdhci_pltfm_remove(struct platform_device *pdev) static const struct platform_device_id sdhci_pltfm_ids[] = { { "sdhci", }, -#ifdef CONFIG_MMC_SDHCI_DOVE - { "sdhci-dove", (kernel_ulong_t)&sdhci_dove_pdata }, -#endif #ifdef CONFIG_MMC_SDHCI_TEGRA { "sdhci-tegra", (kernel_ulong_t)&sdhci_tegra_pdata }, #endif diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h index 493a8d0..d7267f0 100644 --- a/drivers/mmc/host/sdhci-pltfm.h +++ b/drivers/mmc/host/sdhci-pltfm.h @@ -21,7 +21,6 @@ struct sdhci_pltfm_host { u32 scratchpad; /* to handle quirks across io-accessor calls */ }; -extern struct sdhci_pltfm_data sdhci_dove_pdata; extern struct sdhci_pltfm_data sdhci_tegra_pdata; extern struct sdhci_pltfm_data sdhci_tegra_dt_pdata;