From patchwork Wed Dec 13 12:05:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 121739 Delivered-To: patch@linaro.org Received: by 10.140.22.227 with SMTP id 90csp5382247qgn; Wed, 13 Dec 2017 04:07:09 -0800 (PST) X-Google-Smtp-Source: ACJfBoux3Ku9VdveyW0NVj2NbAz22i1dYDopG7pWa43rcKxJbBv1xNN+5MW7Q9RfcH1Jw9ye+LQy X-Received: by 10.28.7.200 with SMTP id 191mr1666459wmh.4.1513166829088; Wed, 13 Dec 2017 04:07:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1513166829; cv=none; d=google.com; s=arc-20160816; b=Pfe5k4awgcxfGt2NIgW9WD5UqDrJYqT4KftAvVPrdOhVUjlPBabSjVzaE7qVW4d9J9 0aViyQsZ6ziKQ+Z1YK0mHoipkQmeNiXdOOvM7LnNy65BrMmhYNkF6jutkUQRAullrtDv OejgRmd8hoa4Kf1sl8x81Hz1GfAsA6ngbFDkTNn8vDnMf0txsUsV06DIUXQZ0NpbcaTm iULPAyZvTDPsnO7AjX5YE1zflZaH3j2CSUGaS8A6FRAagTKJD/4xPfw4aB0HroIz0Zap n/dcaHdMrqKRM5Tf19rIvVDYR6OR9llsJdihmKy9enbWQQMHKl0I5OaGuz/pEsp+hPN1 OVIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:arc-authentication-results; bh=1lwIoBpMo2uLqz5Kn2gV3M9xyFKwIqFF5SJEA1A+5eI=; b=WeuYJhnHjpM1D7z16nDpzHPpHQCEKQ+7wpI004TjluFsALMeVPOWd9W1XjM2mJgC86 aDa7yTtitR6TM1zrP/58efgjIRNgzy3BoYAmQ0uyJppUJ6TXFuuuztDyYHoZEj0JQPBX UziJCBVT+j7BYWJ+aqrEuLrvcn9YuN2gVMzQQai0Gm4o/sRTexboeBnZLHTf5HNUgaAQ B1fdFGRBI5KBDzl6iHdTMoXRUeyMAo2FnXliHX9N+s7LWJnUo0kuiiJTRNdM353ey3rA piyOqda20oU0ocf6rxvA+9Qzk5yA7eC2SA1iOAO6YzKxmB20Kj1mQ1IJLiNvAqUaNcJE w1dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id i6si1211581wmg.66.2017.12.13.04.07.08; Wed, 13 Dec 2017 04:07:09 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A447325B; Wed, 13 Dec 2017 13:07:03 +0100 (CET) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0050.outbound.protection.outlook.com [104.47.33.50]) by dpdk.org (Postfix) with ESMTP id 27D322030; Wed, 13 Dec 2017 13:07:00 +0100 (CET) Received: from BN3PR03CA0070.namprd03.prod.outlook.com (10.167.1.158) by CY4PR03MB2694.namprd03.prod.outlook.com (10.173.43.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.302.9; Wed, 13 Dec 2017 12:06:59 +0000 Received: from BY2FFO11FD046.protection.gbl (2a01:111:f400:7c0c::163) by BN3PR03CA0070.outlook.office365.com (2a01:111:e400:7a4d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.302.9 via Frontend Transport; Wed, 13 Dec 2017 12:06:59 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BY2FFO11FD046.mail.protection.outlook.com (10.1.15.170) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.282.5 via Frontend Transport; Wed, 13 Dec 2017 12:06:52 +0000 Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.134.28]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id vBDC6t9L008652; Wed, 13 Dec 2017 05:06:57 -0700 From: Hemant Agrawal To: CC: , Date: Wed, 13 Dec 2017 17:35:42 +0530 Message-ID: <1513166759-13466-2-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1513166759-13466-1-git-send-email-hemant.agrawal@nxp.com> References: <1513166759-13466-1-git-send-email-hemant.agrawal@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131576404127857712; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(336005)(7966004)(376002)(39860400002)(346002)(39380400002)(2980300002)(1109001)(1110001)(339900001)(199004)(189003)(4326008)(6916009)(8936002)(53936002)(76176011)(305945005)(2950100002)(68736007)(356003)(50226002)(81156014)(5660300001)(51416003)(6666003)(85426001)(81166006)(97736004)(77096006)(47776003)(105606002)(106466001)(86362001)(8676002)(54906003)(2906002)(2351001)(16586007)(498600001)(50466002)(36756003)(48376002)(104016004)(316002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2694; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD046; 1:ZM54NT3xEy/iIyAXsABzzs/41noiGdZKU7vpH1SnkPwtp7BdWLP57/9I/IhAOLepspQovlLl/+KAM1ssN1UvUNdR5CP1F36bqfL2DiOi002h6S5KSmeYngTJkQJkdTtI MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 40bef9e2-b075-49aa-3c30-08d54221ff54 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(4534020)(4628075)(201703131517081)(5600026)(4604075)(2017052603307); SRVR:CY4PR03MB2694; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 3:fHK3bucp3VFDL0GTiUwUaT9ahppVa8A4+txRcgkBaihfzVCE5LQXotaOqY9nJbPmf4GRa7tiLw97i2t1Swpbz7NhQQLV5GcAhFDJ2+m+r+h0ap9A5g4Z6Uz65mrRPTxBIIgw0FH5BCaFTqAwM1trlf+pra9uoDiW5D6PikyF6iEelawRnntHqLr/wk554Ja67i1VQB+Xy9mT+gJJUDsWBYlSwygUcTYTbWhJWfJOlwG5YzoA4/eBcqUk1/l9IyE30hHq5UkjF/PkJy5AWNZIvoopFFRkJlJCjF5C7//eA4jIjyvx4ytYjpAW7t8gfBIE13IwKlvc6Uoq0qfjc/PRKmKG2uI49jxaC6TbnX9RYcU=; 25:mNtdD8B4DDZcNJH8/F9/rj7ydgbe0V1n63HVbhKlEHl0pDBrqg5T6xRK6R5nfvDpO1PE0TWwKwwbBFaUUX0K+evmpzdTfI0bM85+Qshj8Dkp9pjbmcdJ+BHhxds6Ld/t9xMh6bp2J6D9WScCGwTU2FA2cX1BuzQ+72V9RgYvXXiTc8tW+c9uqoqj3c1N0RCGg1PGI8h/yMwNfgS4qx97dBkyb02X7Z6aSq/GM3RXVKntOsHsl68xzHqrT8FgTqbB0xxX0BlVR01U45wCzUHmTwTc7tDSFfNjlnz9VXqS37BnV+Ip2rimjm3rVYv2c2EpPx3UGIXIiI3/tYJjBnHToQ== X-MS-TrafficTypeDiagnostic: CY4PR03MB2694: X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 31:xdnXmS/ebpV3OP2uoVFvfqEHULBi8JNlRNq4CrxvIKCk0ZBReUJjDF8P/UHUUZd8vBmghSEHmH1VZQ6mlXuWVupa9/gtP7lyfwOwELZ7/UqSXJe3HSJBMGW0V5rI8r4+jrqYwrKNA/S+KeEUuzUTfqjH7jAWxrIAJfDRDFHw+2Q31gwA/QkRr+m8oy5ks4Knfu/hu46z3CXTfszTAb+MAxyC7/HVeK3f1RwfnlORyFk=; 4:+ynXv1EjpgKmZDIEFlqcor9K8ZvxSgYHId4ipf22HdXwALl+we3HHaZ18z46ek6CDKjL6wPbjEpanK+58FmbOkyV0r0I0jOQQ7oQvh0xLb/HuuTui7ixsco/Uc4bzIATM7XBAlL02yTdL2OaMETMO3FttV4zpQXmmxeMBE609zBO5bbw9DupGp1BNNA7i2+eykMKlaJqY4iR7NI9T4dd+LNfdD8pM4ySvVguD5Hqi5Q5T961WHcjeU66T6P9m0j+A3DC+wap8x4w/1OLRUZkAbcoDm56ZWtmT0fNPubMVzkyUKwl+3F9H2hO6NOG4F1i X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095135)(2401047)(8121501046)(5005006)(3231023)(10201501046)(93006095)(93001095)(3002001)(6055026)(6096035)(20161123561025)(20161123565025)(20161123559100)(20161123556025)(20161123563025)(201703131430075)(201703131441075)(201703131448075)(201703131433075)(201703161259150)(201708071742011); SRVR:CY4PR03MB2694; BCL:0; PCL:0; RULEID:(100000803101)(100110400095)(400006); SRVR:CY4PR03MB2694; X-Forefront-PRVS: 052017CAF1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY4PR03MB2694; 23:pWUarzTHqiuzv3oCmJPJdu+G54qZnTH1hU5j/exHL?= 0/thWhCj7Yv4xAeL4r4UcohxnDTDJzeX7hK8y7GSvfAyo8MJo+sJ9/Bz6nwbG4aQWwlet58v5iQdM1cZrGiRz6k54Vg4dDR0OrL5N70OTkRnvVSBEC6SbBvrbB8SZ87+rLOsjjH6eiBwYg7EXKh7hn7sXAeswTFVvOn/pWPwFigKf7eNwpJn0a60Jw4RjD7GXuJWRdYWdMic+WH/FWYe5YNkyX4lSiIO0zQJkCg8hj2Yb0r+J/Ze1/Gbqlr6upY/VEU6DfsGfV0GwC6NANenHR4fxlbdTHpGx5N/PZEcgrWTsDYWtwbFt9FvYFO/1x/RFv3hyWGU9eAqWobVcHtWC+TUiumCiWM1UsE6PP5Wht3KsbfGFMDawt0FWdTM7c1wf/V59QxnC+XZkGXpqAjEvof+3Qb8qQE5vvHWjbhfHfpBkYTBUeSN0p/mW0hcf3MN/0tkPnIlXSHQ1SExURpB/qRRiweLvSOPUycugZdq5auR/fcwHx+J91ZsOw4x0SiZvtL6n+WPJ5w10VcxiimuPlDqsoA0guu5qxBGqOMjdkndzO/D8IizJ3eTiYAIjugOvegmFW4fQUoO9mT6Qsv8u8vSx7qsM8RWP0cDqtPInWvTwFuP3tWDbp2CvxHTPglB+uhfMgb2es4fr+c8/m2sfgfPDm5aGLJ+tl6pMO49nsjEbynM9LS7eLGeaIf5VAsZxcRo+BLLhgGBt8eoinWW9ngtwruZF+o01RRkSfXaT2cWPv+xvudeP7mefNfvPsQI/rNa9xnnS81nWMeFlOOOmCU6nfDV2SBlGoJh2yVO2Yf31yX8tZYC71v3UPssHipcIjmb5PYW+uAYVVjh5BsHe4gTkOMVvJgxfoUabKht7mPLx9oQYs/C5GvjCu+AB7nOe6go6s4RqNhvAV4NrcOl1VLnwBXQUhhrpn+BmTk3m2EES7VL5j1outr0wjH7u6mWVNaYKGSy9PZjmDzex1SNYQ+LWdLQzqtGJw5qbred9HGdFCUcdLqRrSHNNCiI8lE4Y6TPheEOztuKwO4Dvelcveh X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2694; 6:GXQ3FVHAGwi/lBXByjWgaVwVEz+TViMIBCKxIoNGznBW2IxV5x5YzE23qydH9foRkQCUD1dmuobSQCwWxn6rLOqkm7jFBa2nePj4hWQmNC9NmmNdvYClVTNlyZmTw1deuMnsmQqkBuI7G7lBJju/CzAoxgyQ4NcKr5/SmwkOmKkkkD9CrUah3UUfGOO2zlFz5/KISt18oEB3aE7/L9cRf7w1egGqmy2w9qgVD3Pjrrm3oM2GHs3Du0h//q4TBJeMSgFDc5hi+lHDcbVO7W3ReJ5/gL/0ukMkTTMmEWYQtVsciR5Tz2HxZevjT6OH4GX4Yx1TYBIRHcXNPgXDGecPYWBg36sWkhxTVqqElKebi2E=; 5:58peri/wBsJliqPcaHDd2zP/cL//RdDdECs0ABAuDOmaTB2LqPJux34MYE3eIKZqktojsOkfHlBRj/FReCNHi76sJQKz3vRW3vO5gnaF6rJn7oP6XOQaFmpuK0VSUJxL831rYtkryxQbpPiUnjlAxRr27Wk36VEI+1R9S0EdOvs=; 24:8Nfam9pR5XdKLYzRbt6KgDoc9yKhXH3jm1b9rfnQmUxV7L2el2YWQJFnhq3I6M8DxHJYPONW2HeBTc/OAiVlWD+KM1WOyyp34781WVKEOOo=; 7:QeS8bKeFxoj/jdJRKuXWcuJRS3zzHLmGAP2AbgS3ZrMtW0jTtq3ZD6jUrOhi+N9oxSARsuQgJiYApPTvrdkxjODJ7tCOh5xdyOHNlMilKUZ2j4nc/OM21fd/KqBKbW8ys2IRB5bvlxWK2Ith7G7yru15zOPO0KVzdpp2PASU7XcLP9Dnyrh4XOSu9f571/aO9QY28Ok1h12V0APUsJ1e5rdIpu5D8RQgLS2FYb3lG5PJVX+ApPs57DpcHqVl1Roa SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2017 12:06:52.5673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40bef9e2-b075-49aa-3c30-08d54221ff54 X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2694 Subject: [dpdk-dev] [PATCH 01/18] net/dpaa: fix coverity reported issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 05ba55bc2b1a ("net/dpaa: add packet dump for debugging") Fixes: 37f9b54bd3cf ("net/dpaa: support Tx and Rx queue setup") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 6 +++--- drivers/net/dpaa/dpaa_rxtx.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.7.4 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index cf5a2ec..3023302 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -723,7 +723,7 @@ static int dpaa_fc_set_default(struct dpaa_if *dpaa_intf) static int dpaa_rx_queue_init(struct qman_fq *fq, uint32_t fqid) { - struct qm_mcc_initfq opts; + struct qm_mcc_initfq opts = {0}; int ret; PMD_INIT_FUNC_TRACE(); @@ -769,7 +769,7 @@ static int dpaa_rx_queue_init(struct qman_fq *fq, static int dpaa_tx_queue_init(struct qman_fq *fq, struct fman_if *fman_intf) { - struct qm_mcc_initfq opts; + struct qm_mcc_initfq opts = {0}; int ret; PMD_INIT_FUNC_TRACE(); @@ -800,7 +800,7 @@ static int dpaa_tx_queue_init(struct qman_fq *fq, /* Initialise a DEBUG FQ ([rt]x_error, rx_default). */ static int dpaa_debug_queue_init(struct qman_fq *fq, uint32_t fqid) { - struct qm_mcc_initfq opts; + struct qm_mcc_initfq opts = {0}; int ret; PMD_INIT_FUNC_TRACE(); diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 41e57f2..771e141 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -665,7 +665,7 @@ tx_on_external_pool(struct qman_fq *txq, struct rte_mbuf *mbuf, return 1; } - DPAA_MBUF_TO_CONTIG_FD(mbuf, fd_arr, dpaa_intf->bp_info->bpid); + DPAA_MBUF_TO_CONTIG_FD(dmable_mbuf, fd_arr, dpaa_intf->bp_info->bpid); return 0; }