From patchwork Thu Apr 5 08:54:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 132849 Delivered-To: patch@linaro.org Received: by 10.46.84.29 with SMTP id i29csp6031766ljb; Thu, 5 Apr 2018 01:56:38 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/UQiosERMrPr8lIzPJyk7JkN88aBqhJ3tj2fKZeb8ijRbOG2DTbc5vWawAQJgDNilPdGdt X-Received: by 10.223.195.116 with SMTP id e49mr14963041wrg.5.1522918598185; Thu, 05 Apr 2018 01:56:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1522918598; cv=none; d=google.com; s=arc-20160816; b=mvThVEoawLcdxk6rpKY8+XBWsj4i7/J2A/OloCLpYKGGTvq/+UH+Idmn/UxVIE6smk ll+AQ8xbASDZOkNgz8kftLVnxizTq3EM8nZa8COViwsmhFrYfdM+StD1etFXMDNAXzWe bthLFIKSdSNTMzXGDtyz3cVOlzcNUXiPIE4bRPh8J9A75FOcDyCRRMCDdXhYr3LsM6N8 yBNrz7yWQIaplRWv+1JileCCtwVYH33Pz8uXCuXThBi1xJVLmZ37S4noHu13x1cOKv5/ HEK5TTeqKY/oaYCNeQR9iyLMnDzaGPS2+rrKI/3JGsBMi2L5XvejtnUtlqfWmx+vAfk4 tGZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:spamdiagnosticmetadata :spamdiagnosticoutput:mime-version:references:in-reply-to:message-id :date:cc:to:from:dkim-signature:arc-authentication-results; bh=KRbXvhcQO25eTD5S4lV6cE8T5ZG88oEiYUuEFpkrVL0=; b=eUunjjh/6FG05HnySEfiMRJ4H1oe+JwTlCKcALdwZZEgKyDzXR3BhidDZ8wIaXRukV Ruuv7uWYVq2Ewv1M83aMNg/gtkMY/+wVc0lA6IjB5X6K4ghL7vQr7uYZU0W6YPCCnAYk NQeC5h/PEKPSgfdP8r8w2WE9PxgKqygiIBlR9uP1LCKifLovXwI6GfPDgCtIupKTgst6 q4yJP+EHc2nWXU/f8i5Ki2x2+dn1dlY+wZcigX+ww1QmhKOqeBZWjX85+KYEF+O3nBoI W+7/V+ExPWj16T9VGwVO0DoZaaxjyxYX5zdYNyNGdEinvrEiHvlwUrBjjWfYYk5rxtN9 wKzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=V/jYB1xR; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id b5si5376139wrf.362.2018.04.05.01.56.37; Thu, 05 Apr 2018 01:56:38 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=V/jYB1xR; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 14ECE1CA09; Thu, 5 Apr 2018 10:56:27 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0064.outbound.protection.outlook.com [104.47.0.64]) by dpdk.org (Postfix) with ESMTP id 413AF1C9E5 for ; Thu, 5 Apr 2018 10:56:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=KRbXvhcQO25eTD5S4lV6cE8T5ZG88oEiYUuEFpkrVL0=; b=V/jYB1xR/xXRbUdUjZDS8T55NoUG7Nx0ZoTPx0zO/ssP5khhKr9CdoNMscYJZ/WGvvGWqojFmJjmIDBjLSevozlYzssJKGseVjIDxQzfMJzubxS+OfUryrwlZbDysu1q3Uk2m6SRT3YVzhDsNk6SupRzSZiRV9rZCA4vX4vbhBc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; Received: from bf-netperf1.ap.freescale.net (14.142.187.166) by DB3PR04MB0762.eurprd04.prod.outlook.com (2a01:111:e400:9440::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.631.10; Thu, 5 Apr 2018 08:56:20 +0000 From: Hemant Agrawal To: ferruh.yigit@intel.com Cc: dev@dpdk.org, shreyansh.jain@nxp.com Date: Thu, 5 Apr 2018 14:24:19 +0530 Message-Id: <1522918464-4586-3-git-send-email-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1522918464-4586-1-git-send-email-hemant.agrawal@nxp.com> References: <1522918464-4586-1-git-send-email-hemant.agrawal@nxp.com> MIME-Version: 1.0 X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: MA1PR0101CA0043.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:22::29) To DB3PR04MB0762.eurprd04.prod.outlook.com (2a01:111:e400:9440::25) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b1b7bd94-34e4-4671-f6c3-08d59ad31a3a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:DB3PR04MB0762; X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 3:NWsb+ZYkCIiQhPupLkkjOZMpMBnpq413B/D1QHZ23b5x8gMO1KKSGkALEpZDD/vzYxUKuwgW8eTN3q1/pFhUbR0ROMqobynGpM1ShB4BvufzSRGr76kkpejVn6xSe+HzZgqy590eedS9xqloif0LTw4iCNEljiDYxs3ycZmdidEpdPBWHbMmSK6nS1W66w9bcCSxZeDxsg8PAOHSk5VZgUDhY8DOA4Y/pOuPOl5CR1mri+/HMn5TF9DvykgFC+sP; 25:5+tbEEg/Xkd/uwduXfABRgZR9TK3V9ItIr9qT/z1obObdttH49hjAoDo3iKrYNA+qdxZNybBB5wLOfUQy7AV/faAH3shvFv8WpdLdWY3EMfX3lUJOGTBmPwQBJsm7MhH8Rthfmrm11qVv/gmTm+zNaCvPb5FTdrr7mXL5pxer0RD68i2iVSB/Bb779R7np1fJQUu72rfe/i7bT4kMIThqR65QsZE4AyL1BkJDY4m6X+i7Vb9azSlcVvtM7RlXkEXsmUvjE61jwNhLFfsCV9Rpne6Nka6KiqXWHqmQffnohZreWhVUSzxsXYsDaaFrAI6FLpfsSV9U9LLWPP1EqUnKw==; 31:HQ18hyWu5Ky8Fd/mugcjPz8YsudWaKWUk/wCovS6+kgIWcd7lkZW9vXQZeivtyJZMtVSLFMN3pDJ/hj1gV1UqqiszZh147iCKlyywIcfArN+LN8+KrRk0A4ksf+lDtKOJ6ESnYfFIL/b5DvN1JakMs0feDafOMLOVJQlwlN95GeUnxYEFXWtvE3N4V9sVXXGopZO6Qn7KX0IFBMFrQQOdY+TCUS9fcIvUkx88pGPe98= X-MS-TrafficTypeDiagnostic: DB3PR04MB0762: X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 20:5VsWGo3d3gNKaLpv1dQRuUucmPbmvCYf1RXzJgxK57TEDnmIVl40SDw7aF7L3Ql8SWbx93gHhy/lJq0/w52hOBdm0KLqVkSmPAgjgX7fug8AkWx2vxCghQ3qsK+OBnfl+TnBAz5RrToW8tYlatc85Smka6yLip45dnCeBmda6Wvqk7H3iU2bgE6WwFDpjhFLMjPxpVJTY+iRURhpvJ2C/iO/4BozcxcKhdIVwUdVP5O1FlcTpZGbg2cxU+gmguSUnAxZLkwA+4jm4xOpOfeJ9vXKzDTmlJRoU8x+lymPkkV5TURDEoNKMmbzVF3HlfXLumYZIQyvH6eqWN1rsu4S+cR6ED9fW7v3G7WX1b+nzHARaDhp+PZIz9S962RP8wb/uOteKDt6vcZNdd+gPQBy59/vF6VaEPEVZeUPNT6ciPCB9dpGEmPRcPEQjeHNcpWjWNENT9UsoLuiaryCw7Pmhs8JReUkDy2Ah0xmh+vm2Xq50GMp8XJSQZdmWpzRrxHS; 4:gPd+3jrbGNiI6lyZs0ogcUYVU+ypAgAL4JXn8zTbqmrDINk5HcFTMKpr7XwZX60F2Yh+zktrhJeA8BAnyr7qayr5zQrVkkCsMzj8m9POMy9i44wpRFtONAga2Nd+7ihCGVQfQ47uLKf3xBIb4iXJ+k7uy3bjKXl89gzqiKNTo7jnJrTyerUOAoKajJeEaNu2EM9UXUqgixzN2fR3j7D89oVHpFoS8aRktTHbiNV5RqXLRox12cIyIqStxQH8OkYrFm9cr+ogdzQi+73Zu+phqIaIQHJdb2LYN6XulqYPdU5NZ9jQRKBQIb+bj0P/nlXE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231221)(944501327)(52105095)(93006095)(93001095)(10201501046)(6055026)(6041310)(20161123558120)(20161123564045)(20161123562045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:DB3PR04MB0762; BCL:0; PCL:0; RULEID:; SRVR:DB3PR04MB0762; X-Forefront-PRVS: 06339BAE63 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(366004)(376002)(346002)(39860400002)(39380400002)(189003)(199004)(76176011)(81166006)(53936002)(2361001)(2351001)(6916009)(25786009)(7736002)(476003)(50226002)(86362001)(81156014)(486006)(97736004)(105586002)(26005)(6512007)(52116002)(3846002)(11346002)(8936002)(446003)(16526019)(106356001)(51416003)(8676002)(386003)(48376002)(6486002)(47776003)(66066001)(68736007)(5660300001)(956004)(55236004)(478600001)(36756003)(6506007)(2906002)(2616005)(5009440100003)(305945005)(4326008)(6116002)(50466002)(186003)(316002)(16586007)(110426004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR04MB0762; H:bf-netperf1.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR04MB0762; 23:AwJjMrNYbI7q7B76bWP9wryG2XPFVCh2g2pHXESI/?= WQTdlbqfmRalne/4xa69LomZk+B4RGRUZ0EDzg0Aa7TYmwYor+2G7SHRH5Rb7zN/ZSo1VKhq0hbFJ029gknoNYHlSVfD6DGnYotteWLPYAVV4DEtMvdaeZHXQmidXhZXdEwXpwz0z2l7SvrZWAqDPKxJj/02DEGSafHCQLP0yfSmrs2wwjRtmPrHumXAiDqEqtgj35MkzhaU911bGX/GgZUdpRAGXEjqRCZ2NHD3ZZFVSIRbrXAugVtwqQo3ksHb2BdohX6R4a/zbHk1H28kzOsYgxva4rmDe1w6mTQsqzCEBzoryvUjh6QBUqrjLIBsOs9lngdwtLtEr2PB8k14oY742nckJ4rSpDs0jhHKq84K6OO/GiuEdnEuQACWKu0pOPOo0VJcguDe+/U0TWJ86wTDrV5kVDQjA6AXhBMmYPWPHbpJPNMSr61OWlm1zGQkQWxtGv8wecPimq14z0nNzq4YngRFC7E8lrQQBBgB+TDw6Ck/47gGNF7VHxQSfukpWgVxg+aEqfQan6utK8WKEwnWCyoFTxsUbwJ49xiSKlectpKq00I1tkikWRBOLV2GoccD+SMvOf4mE1SZs2OfRBN+6HxQ8dqxyF/glRzNMPfRq99Upq31xVA0JOy1xuCZU0P/2Q9STL6b0t+01BLEjsL+LPx2FZa3QkExHjwHltaJsfPNfGm7s8hesHFuxt+Yd/jagBZsKMA8AjFCxtS5xWXzQleRXz1QbUkuo6nvnopIBzyChfYNl/XYx5JeTCcTlcTElkF3dGIizrkZjgQbKebYN1WrtkMwTIiX5UT0DevhlmVCtEQ3xy29FSWSda/XCuoXWAp5wd2FVfF8F/EJusVHgqtCo75+/Q3IyU1eb1gqY6fyQM0czwAX07eaEY2BX8hBSvXaiNiipYrXaA2Un/qEy9kTkJalWfU30KV7zvPzfnTi6W/5UVg19WmxmyISLq6fi32OIjP4y2nxVjeVoDTfOsrci/wUgHwxDYoH/hvtTvbE2HvK/wYLTqH0JiK2EHIbSoztLYcUfiqKt1MiQBtLCqi3JiGQ6DjvKdiDzuZjePxQkQTQgvnB4fJfssLisRl7Def/Ad5FUYQVQUz4RhhA5tjwySs1Ajofh7L59C55kU2PrEX/4dVjtSgPnFkfTs5qDUDSsT9tpfRcWgLVKsHgo4/z1uIIVW0vDIgG43AqLd6Fw0S6T/wcu7UvK8ho7AOCJbJgjQoUvEG1rdpsvRH X-Microsoft-Antispam-Message-Info: mwQ7oQDPtG1jJJTYmAqUjSOOapUkGW6oJflmUovLvZnRY0C3cXoZM0Pr2DZoymGhD8edgViBsFabN/FBzGIrAOXKIdDInplEWORt7acaTWfWOF0Ol3CmZ/WopbU+sap3YRiNb731DWpmn6Ee8ahlbxf9ONgGsVOoIbN+jH3NznmrVuR5w3tTySjCHoyla5qK X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 6:9OXZPP6oevuBIKPMQUhUx21YogjYzfCGsrAFXK93uRHtkD1FzfWA6Gs7n9+4Qye1OHgdNN1woW5S3rZ9Fm8OwA95uKt/3SW1AoCB4FQzUGGiIC9yj6f/ni4KvO8XrEE/4wDiySw044Lgff2apxelidlGbvXw2xc7NbNmw3eeoemMqu8nRu++9hNL0vLd5av9wkK6XL//yxEu14xqumLxCqj8Za5fmOrjQPpnH9S+A/B/Lg5JTs8lrVjyEGxhVuX/py7tSDwDUddPcA+XePt1P+GLpvzrcQgO4eDLRP2S54s2KK7XZCLUUPz13QZ2ZEBjzbsU0ygOTa5zCg1ghN8j4T9Tg5JDKWR+CiIKCRtAgeffddB+yCBLo9fofhDgU0pn/V8v0Qk2I2a4DJyFZFh7SA5d83pZP3xDeaS51YkVx68JK8AR/+ASWnKmuAI0pr9DqCMaUoPSukmadYPWwd8J+A==; 5:Km4oyHF5nTKdtgTV0IFDsA95LFhdkTAi02fdJjjQp0iHrYMBHPvwWTsvbdc4mEY4wLPfvYLU9dTrpyaWjLiuXThUw+dA9hWFNkYVw+MzsZK4yIt9S899243Nm5oyhuMwyybE5GDEeu/fE/digv+IdKZmImpM10zd1U9G/UT3y/w=; 24:ZG55Gdn//GHthgpEWQ+V2na1bEkI2p47LYqqHtjS0l252TR+7zSXnf7ZkQba7NcZC+oL5msFZfDWvRCVAFW4gfAD5BLaTQA1cVz2PwKmai4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DB3PR04MB0762; 7:pLRo5/h184qxMfSkUtiNzbKalmYf5uaXUKcXBO82ym7xjega9XdbmuhJX7pGA8ajUkSNITaM/rSMuyZGwulHh3zrUjp9ytjdKP0UlK4pTUGMioQbPDRa58APcqAZOxBaP7SZqwR7PUjmg0ObM3UnZI6MAXRk0o3N7+v0H3GuWV0Aj8NllpVBU07Mwlx1ZRmTeEssV9v39JZFc/MPyIPlC3TPNooqUvLtt2DnKPHqdFm3HkxCN+B97TEGSQAf3C03 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Apr 2018 08:56:20.1954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1b7bd94-34e4-4671-f6c3-08d59ad31a3a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR04MB0762 Subject: [dpdk-dev] [PATCH 3/8] net/dpaa: fix the array overrun X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: 62f53995caaf ("net/dpaa: add frame count based tail drop with CGR") Coverity issue: 268342 Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 Acked-By: Shreyansh Jain diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index db49364..0aad111 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -1105,10 +1105,10 @@ dpaa_dev_init(struct rte_eth_dev *eth_dev) dpaa_push_mode_max_queue = DPAA_MAX_PUSH_MODE_QUEUE; } - /* Each device can not have more than DPAA_PCD_FQID_MULTIPLIER RX + /* Each device can not have more than DPAA_MAX_NUM_PCD_QUEUES RX * queues. */ - if (num_rx_fqs <= 0 || num_rx_fqs > DPAA_PCD_FQID_MULTIPLIER) { + if (num_rx_fqs <= 0 || num_rx_fqs > DPAA_MAX_NUM_PCD_QUEUES) { DPAA_PMD_ERR("Invalid number of RX queues\n"); return -EINVAL; }