From patchwork Mon Sep 17 08:11:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Gavin Hu \(Arm Technology China\)" X-Patchwork-Id: 146840 Delivered-To: patch@linaro.org Received: by 2002:a2e:1648:0:0:0:0:0 with SMTP id 8-v6csp3481427ljw; Mon, 17 Sep 2018 01:11:33 -0700 (PDT) X-Google-Smtp-Source: ANB0VdaWkDBYzNcDz6QJ4ZtI56SRnOMGh4uwQcNc0Mig93YuazsyrI7q4v/QfLD5Tsm529p4+87k X-Received: by 2002:a05:6000:181:: with SMTP id p1mr15619246wrx.146.1537171893221; Mon, 17 Sep 2018 01:11:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1537171893; cv=none; d=google.com; s=arc-20160816; b=Yay6XgcsTA0Wgy8tJMW/YbkiFbbw2XEWuvAW1JkY7sN9gQBS5OnzNcNFfTaFMrQ+Ht j7sNHKiGiHLBHUCrFeUkkW0fupIH8WfE/D8l+Lw2f9C4h367yeDHamfrPeDiTrjlTu0K jgS7cCQWP78VlK9YROcvwVwiuA0Ltxh11ETQodKR4c36gTBqHguTTfbeeJ8hK79nY2qe 27ZtHVYYMgy/k315cruikrNBKIFv+gLe1MHvNNk5iR5VilZ73H2/pZd6LXqXqNBBPDzi 7JR1zgX63LudmntWYkaeWg41PcZq+8pvHsubiEqsztMUgMetdNEDdwsdJLxcMD5aq/ca alWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=W08cbb0Afk1Ox1VYtB2QNZnOUyUBaIj4aAzQUuurA1A=; b=Qn4FRoDflD2B5pmZURXbka8wl6NaBIv9yB3TlbD0KY0CrleeSU6Z0xYtZb2L0sO1bX xDxX22UytqKaHmjnpishuLIly1CbbHVDckTFNr6zjZCkEzk/VaJr0HHDeHZTU1pWjlf5 V7JJfBlvJIYb9tw2EJxAvXNbyMEpIJdJ4ixtgO8rRSiN1oxxFhhpglZcWjhJN6emHVxI Z+2pOFebNQiB19iePf2E/oBMXz/ApkO+XdO9q+pH4fT9XIKXs/vy5+yhzQ02busxXtV2 HxWfAHsrwL9GWxsvECVmKXGm7yE3kN+ozMoFwlAyalNGpPNV1Zv3dXEBc1ZT9apXqWMK R/SQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id r82-v6si5973472wme.104.2018.09.17.01.11.32; Mon, 17 Sep 2018 01:11:33 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C98A92B92; Mon, 17 Sep 2018 10:11:31 +0200 (CEST) Received: from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by dpdk.org (Postfix) with ESMTP id F21F11041; Mon, 17 Sep 2018 10:11:30 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E79C780D; Mon, 17 Sep 2018 01:11:29 -0700 (PDT) Received: from net-arm-thunderx2.shanghai.arm.com (net-arm-thunderx2.shanghai.arm.com [10.169.40.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5F4793F5C0; Mon, 17 Sep 2018 01:11:28 -0700 (PDT) From: Gavin Hu To: dev@dpdk.org Cc: gavin.hu@arm.com, Honnappa.Nagarahalli@arm.com, steve.capper@arm.com, Ola.Liljedahl@arm.com, jerin.jacob@caviumnetworks.com, nd@arm.com, Hemant Agrawal , stable@dpdk.org Date: Mon, 17 Sep 2018 16:11:16 +0800 Message-Id: <1537171879-64390-1-git-send-email-gavin.hu@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20180917074735.28161-1-gavin.hu@arm.com> References: <20180917074735.28161-1-gavin.hu@arm.com> Subject: [dpdk-dev] [PATCH v4 1/4] bus/fslmc: fix undefined reference of memsegs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Hemant Agrawal This patch fix the undefined reference issue with rte_dpaa2_memsegs when compiled in shared lib mode with EXTRA_CFLAGS="-g -O0" Bugzilla ID: 61 Fixes: 365fb925d3b3 ("bus/fslmc: optimize physical to virtual address search") Cc: stable@dpdk.org Reported-by: Keith Wiles Signed-off-by: Hemant Agrawal Acked-by: Shreyansh Jain --- drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c | 7 +++++++ drivers/bus/fslmc/rte_bus_fslmc_version.map | 1 + drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 7 ------- drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map | 1 - 4 files changed, 8 insertions(+), 8 deletions(-) -- 2.7.4 diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c index 39c5adf..db49d63 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c +++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpbp.c @@ -28,6 +28,13 @@ #include "portal/dpaa2_hw_pvt.h" #include "portal/dpaa2_hw_dpio.h" +/* List of all the memseg information locally maintained in dpaa2 driver. This + * is to optimize the PA_to_VA searches until a better mechanism (algo) is + * available. + */ +struct dpaa2_memseg_list rte_dpaa2_memsegs + = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs); + TAILQ_HEAD(dpbp_dev_list, dpaa2_dpbp_dev); static struct dpbp_dev_list dpbp_dev_list = TAILQ_HEAD_INITIALIZER(dpbp_dev_list); /*!< DPBP device list */ diff --git a/drivers/bus/fslmc/rte_bus_fslmc_version.map b/drivers/bus/fslmc/rte_bus_fslmc_version.map index fe45a11..b4a8817 100644 --- a/drivers/bus/fslmc/rte_bus_fslmc_version.map +++ b/drivers/bus/fslmc/rte_bus_fslmc_version.map @@ -114,5 +114,6 @@ DPDK_18.05 { dpdmai_open; dpdmai_set_rx_queue; rte_dpaa2_free_dpci_dev; + rte_dpaa2_memsegs; } DPDK_18.02; diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c index 7d0435f..84ff128 100644 --- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c +++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c @@ -33,13 +33,6 @@ struct dpaa2_bp_info rte_dpaa2_bpid_info[MAX_BPID]; static struct dpaa2_bp_list *h_bp_list; -/* List of all the memseg information locally maintained in dpaa2 driver. This - * is to optimize the PA_to_VA searches until a better mechanism (algo) is - * available. - */ -struct dpaa2_memseg_list rte_dpaa2_memsegs - = TAILQ_HEAD_INITIALIZER(rte_dpaa2_memsegs); - /* Dynamic logging identified for mempool */ int dpaa2_logtype_mempool; diff --git a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map index b9d996a..b45e7a9 100644 --- a/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map +++ b/drivers/mempool/dpaa2/rte_mempool_dpaa2_version.map @@ -3,7 +3,6 @@ DPDK_17.05 { rte_dpaa2_bpid_info; rte_dpaa2_mbuf_alloc_bulk; - rte_dpaa2_memsegs; local: *; };