From patchwork Fri May 8 12:59:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 186325 Delivered-To: patch@linaro.org Received: by 2002:a92:8d81:0:0:0:0:0 with SMTP id w1csp4154610ill; Fri, 8 May 2020 06:01:59 -0700 (PDT) X-Google-Smtp-Source: APiQypI5iSp/bftl7WopVOMpzZLBr0jA6M/7viYQRJe95Ir3xu1Dd0xNCS9UHV6QKK4a/gVbm4aZ X-Received: by 2002:a17:907:42d6:: with SMTP id ng6mr1720252ejb.265.1588942919189; Fri, 08 May 2020 06:01:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588942919; cv=none; d=google.com; s=arc-20160816; b=hAqVXls6+041pBGwtkAVju4NkkbdnzGgJNn1BDCVuEIMphwIIiDv36CLEREL3u5TZR vY/0Z2EcrBeKm4v5QWKQx2YS3Ijbn0aH5VCeSvh2gKZTn5zQ5o30kmek2XZyYH8BeY78 mmVZXyCHw7RfMm0n7JUEiIP5wKMxUSMT+uTQlUyYbMznzEzud1A/JFaImbkwK7QHpigq Zu0pDc8ZdPkxFCYYrjwU61GqGPWgWyobkOnqqMzFF+hFNX1LNyGbfBUjimpDeLSjgUPr 18n9fuY4lQbnHbrVuJ+pscHR6vlGvlQ1gs20QRQjh3o7S+bT8c672DVyc7gtu+1dbasf mCBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=xYdBpebDXG5p7OatYIKDc5NMhbUi7AJTu3fyxRc/ras=; b=sD7rTVcygbs2IGao7UULMmmI7bQh3YFunPzcKcxWNjuSE19zTQCkFpR7mejWLIb1mm MbC2iN8570nwGw/LSsFLQ/lC4xKqm3NjbHjOVRHtMjYwnIM+wV2iHw4BUU1bXI+T/lg7 ohW4ybV4CR7RQi5mRC4bQaqmYsto3hRu0hSdc7x7yoeqNE1bzc7yf0Z0P/50+pGxadR7 ZSEoXtF9H2dTTKR+CqZ0MjLW/yILLOUWQ1hi2OaQ44q7tjqF71bBExLifH4buqpMWuCN nBkrW1kYRQdW+9ocB393w9v7tllHO6HNPffrjNFU1tmmxhiZGA9XjfIfor2r12LZusjs c5aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id p24si849101eju.406.2020.05.08.06.01.58; Fri, 08 May 2020 06:01:59 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49DDA1DAD9; Fri, 8 May 2020 15:01:53 +0200 (CEST) Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by dpdk.org (Postfix) with ESMTP id 756741DACA; Fri, 8 May 2020 15:01:51 +0200 (CEST) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id DB3E11A1532; Fri, 8 May 2020 15:01:50 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id D3F2C1A02F9; Fri, 8 May 2020 15:01:48 +0200 (CEST) Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.133.63]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id DF2734028B; Fri, 8 May 2020 21:01:45 +0800 (SGT) From: Hemant Agrawal To: dev@dpdk.org, ferruh.yigit@intel.com Cc: stable@dpdk.org, Rohit Raj Date: Fri, 8 May 2020 18:29:26 +0530 Message-Id: <20200508125934.14255-2-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200508125934.14255-1-hemant.agrawal@nxp.com> References: <20200507104645.31990-1-hemant.agrawal@nxp.com> <20200508125934.14255-1-hemant.agrawal@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH v5 1/9] net/dpaa2: fix 10G port negotiation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Rohit Raj Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface on LS2088ARDB, the ports were showing link as down. This was identified to be caused by the setting of link as down during config. Also, the line rate was not being updated in device link params, thus having the incorrect link speed in status (as 0). Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") Cc: stable@dpdk.org Signed-off-by: Rohit Raj --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.17.1 diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index 2cde55e7cc..4fc550a885 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -553,9 +553,6 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER) dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK); - /* update the current status */ - dpaa2_dev_link_update(dev, 0); - return 0; } @@ -1757,6 +1754,7 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev) /* changing tx burst function to start enqueues */ dev->tx_pkt_burst = dpaa2_dev_tx; dev->data->dev_link.link_status = state.up; + dev->data->dev_link.link_speed = state.rate; if (state.up) DPAA2_PMD_INFO("Port %d Link is Up", dev->data->port_id);