From patchwork Fri May 3 12:29:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 163316 Delivered-To: patch@linaro.org Received: by 2002:a92:7e86:0:0:0:0:0 with SMTP id q6csp546970ill; Fri, 3 May 2019 05:31:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqzEA01gfJtnM5XqKeg+lSMxKDS2F27Gc5530gxx1hb+U2Ke4VTPSoWsqxkDTu10ovH7HeJy X-Received: by 2002:aa7:93a7:: with SMTP id x7mr10437731pff.196.1556886687470; Fri, 03 May 2019 05:31:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556886687; cv=none; d=google.com; s=arc-20160816; b=o+jKY8M4GODjiIP+ke6jv9uHUe1uWZTGJ7rhMGlkPfUbvO7P6vjqS1H6H6Njsbf5Fw 4daoKs276xAQ+FrxtNWj+thUMmUK6KEc2bKO1p7J00VB0F+0BoJQlWltW7MRYlhqFZWN 51WnoQDv9hNSkrFRkzyIr/BouPJbAbfZNC1eMmSft+UfsDUUoRjAcwrGaDiFKlQ3ECVU bfFPQh+A+Ba2wo1vxq4j//C/4vweckkjl6W/H7A4s0jQOgTDMApcih1QS9QTV9lAtYX9 /DNPxpph9PyMv4trenKzd0jdcSrOEk4pJnkRLKS+Q4XzO9VfRhKk3JCmYgeWgN3sEDfb 3Psg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=f/NjdW/qmJZ2bgIKDwJbBWZMsyG+X3ZZgB7WGGPgfWQ=; b=XwnI3dBYggfa6Pt/UbLaPKiOynH9Ffpzk7BWcq/DaId+dy4mHvI88D0X2tw6jHywYa xV9jhAmD4X7fo0MBYSz25cNSzsPjH9bOR98p1O/gdIKjqdy+u3G1CDMOtKMc0F6SMdKb K6ZgHKnaospyCaehT85ogAjtVsPYzqnNYB73G6SQz0Cx78FFtT5G+xTRZgwt0nw+wWyj HozuC0ZgCKCteD8fD0HQDVEeBFO8F6xY3vXBri7spH97OM6jHa+BnsFhKa6DDtuEe2XD mdavMDYwOPh/k7T49zmWD04t1sXhmEfVJlprWEipM1ddJyRReFpI70M9KzafbevqcI4u 9dpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id h15si1961644pgv.169.2019.05.03.05.31.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 05:31:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A42DE89F2E; Fri, 3 May 2019 12:31:25 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id F1B7289F27 for ; Fri, 3 May 2019 12:31:23 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x43CVLT3032439; Fri, 3 May 2019 07:31:21 -0500 Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x43CVL6X129129 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 3 May 2019 07:31:21 -0500 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 3 May 2019 07:31:20 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Fri, 3 May 2019 07:31:20 -0500 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x43CUYu1002029; Fri, 3 May 2019 07:31:18 -0500 From: Tomi Valkeinen To: Andrzej Hajda , Laurent Pinchart , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Peter Ujfalusi , Jyri Sarha , Benoit Parrot , Subject: [PATCHv3 17/23] drm/bridge: tc358767: remove check for video mode in link enable Date: Fri, 3 May 2019 15:29:43 +0300 Message-ID: <20190503122949.12266-18-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190503122949.12266-1-tomi.valkeinen@ti.com> References: <20190503122949.12266-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1556886681; bh=RHGs8qGQHJ82kep0L+Fdg3YefO6ZG1qAfVf81bx6JIY=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=h/lkFr8ztJutn4IhyEhEVD887DQws/NMjiaccYPeVE+09vw7NmPCYSj/8HYuOL10n LwFmmWu3EP3K+PkePwbojnBANVGMdvC21HrTsLj7DHILuS1wcSyT3fpbWExuWktqD6 Ry6Ncyxh0eYtoBx01tBDSkPZUo5LXWcJ5rFfjeco= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" tc_main_link_enable() checks if videomode has been set, and fails if there's no videomode. As tc_main_link_enable() no longer depends on the videomode, we can drop the check. Also, while tc_stream_enable() does depend on the videomode, we can expect that a mode has been set before drm_bridge_funcs.enable is called, so we don't need the check there either. Signed-off-by: Tomi Valkeinen Reviewed-by: Andrzej Hajda --- drivers/gpu/drm/bridge/tc358767.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 86175e8d01b3..81e12f17b162 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -773,10 +773,6 @@ static int tc_main_link_enable(struct tc_data *tc) int ret; u8 tmp[8]; - /* display mode should be set at this point */ - if (!tc->mode) - return -EINVAL; - dev_dbg(tc->dev, "link enable\n"); tc_read(DP0CTL, &value);