From patchwork Mon Sep 30 10:38:40 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 174732 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp6943068ill; Mon, 30 Sep 2019 03:39:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwICwiobBEWSzJLol4M4bWGHva3paLNBzQ672ivZEwdzrM36QVXsuZEbFbkSSwEKPC552FA X-Received: by 2002:a17:90a:258c:: with SMTP id k12mr26579067pje.11.1569839948025; Mon, 30 Sep 2019 03:39:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569839948; cv=none; d=google.com; s=arc-20160816; b=TjF3tZetmqU3LAT4B284ai+WHTtL/6O3rI5nYcUAp9qw+EDdx47sjMeR46D3UGYPGP W/NdktSQVwXenka4UXpdL8FqMrDVKCIBBG/k2m56rTu8QYQKcnsZozIaBI2Mh+5frbTy iPwc5z2A4y946Eys1H3RmK/CjYobo67ZPLTC5nX4+urUzLeygfCwUOVAN8JLp1thU0jr k4Sz3/bBNBYrNE0nl3QrfnHDXOYD/cTVvbJrjG2jT4Mycl3p+/PISDx9EaRSMr+IVaq4 4Xd7odqXts8+/Fk/arAvps0UE5zKgxvGAVxOPpy0F/oXs7xakjbg7bceia/h2kLQhUcd SkLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=aTofOYXuRL/llOOBz+pYi0chFoU3SejL2dZIVJfMKc0=; b=cyxlCflHCl3G+4VWUPjr5PJCY4BRHce/zgBVXJ2tmP4RzsGpx99S+kHJ60j+A9x/xt GP9vNYiTjG1oVjj3XbJlY7CfbgNo96R9ACODjIV5iiAXliArAJUBQe5xHFgN/TBJRKcm 0RgFeGt9boFxWOG03KYIA5Job0QZmqmkw9EC1BNdL8+JTPWdKy9u0ClQK6lP2ka+zEsu vXUvYFw6S2l4wPKSOAihH5+r7nlAX4ZfA06Jigl77DWL6SoOA1oG555djq1RcEaHppys ZVv8o4gPYklaxjei4vMZYdWFfZjaoZAXRbrVtFnkTlZC+ewrZWPHxEgpWFsH7hX8DZEN LGSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id a192si14471433pge.309.2019.09.30.03.39.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Sep 2019 03:39:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41F686E25A; Mon, 30 Sep 2019 10:39:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 916006E24B for ; Mon, 30 Sep 2019 10:39:01 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x8UAcxEA100925; Mon, 30 Sep 2019 05:38:59 -0500 Received: from DFLE111.ent.ti.com (dfle111.ent.ti.com [10.64.6.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8UAcxHK016965; Mon, 30 Sep 2019 05:38:59 -0500 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE111.ent.ti.com (10.64.6.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 30 Sep 2019 05:38:59 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Mon, 30 Sep 2019 05:38:49 -0500 Received: from deskari.lan (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x8UAck23011864; Mon, 30 Sep 2019 05:38:58 -0500 From: Tomi Valkeinen To: , Laurent Pinchart Subject: [PATCHv2 7/7] drm/omap: hdmi4: fix use of uninitialized var Date: Mon, 30 Sep 2019 13:38:40 +0300 Message-ID: <20190930103840.18970-8-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190930103840.18970-1-tomi.valkeinen@ti.com> References: <20190930103840.18970-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1569839939; bh=DtW0L6HyQo6uDdSd8XmxCvBOVsGLA+IZZDnLj7Wxxb0=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=sYxEbJi/SX9ECw+XTzKfq0zM4WZj11tlnh1vu4JSfKJKTfBvCIMlLmvuH2/N/xedq x7utzeHMoGNoSROvgX93jKoaiaY0YfRC6oJp3SDdvQ0kV09GVYOUOqoEsYaSPyMWBa TGKVnetKREb3kUrWuiWM6jSP9e0Y9Ff1eSh/Xcvc= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen , Jyri Sarha Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" If use_mclk is false, mclk_mode is written to a register without initialization. This doesn't cause any ill effects as the written value is not used when use_mclk is false. To fix this, write use_mclk only when use_mclk is true. Signed-off-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/hdmi4_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c index 5d5d5588ebc1..c4ffe96e28bc 100644 --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_core.c @@ -542,8 +542,9 @@ static void hdmi_core_audio_config(struct hdmi_core_data *core, } /* Set ACR clock divisor */ - REG_FLD_MOD(av_base, - HDMI_CORE_AV_FREQ_SVAL, cfg->mclk_mode, 2, 0); + if (cfg->use_mclk) + REG_FLD_MOD(av_base, HDMI_CORE_AV_FREQ_SVAL, + cfg->mclk_mode, 2, 0); r = hdmi_read_reg(av_base, HDMI_CORE_AV_ACR_CTRL); /*