From patchwork Mon Nov 9 21:18:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 320987 Delivered-To: patch@linaro.org Received: by 2002:a17:906:d156:0:0:0:0 with SMTP id br22csp3000486ejb; Mon, 9 Nov 2020 13:19:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJxG+Sxd+m4xciNHnq4uArVFMXsStlXgb4PeZZbrixLs1grg70IBtoexblvy9/R+PROfMx3g X-Received: by 2002:a65:5c43:: with SMTP id v3mr14838542pgr.271.1604956778560; Mon, 09 Nov 2020 13:19:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604956778; cv=none; d=google.com; s=arc-20160816; b=N8Y+QNc0Pdweloc8fMVLCuUMorcI10uMFY1yfdKFdZbn6uNbdDmImr0eyIlE/04Pgt 1GIpJKGqi5w3ruavaOHvuA67crQBswf2h5zBnxSnflW0tkjMyTHJ4TqLU876uGXoLR96 kZ1P4TjKbSNk7BMSxYU3aUS+0ht/+x1LkwE2VDFVAzSGWWLbmf5BvInngzJyp+216U6a P6bI+OlScGuOKHtioLVPdK6DHjK+TJA8odlfIT3WXYBIuygIxCzjW7739LcgIaEfOLKQ KQVc6Wwb4ShBvloSOruoec8p+6g9UzqwMifZjx4M8ypNkyhm9ekSrWd6L/nFcDkw1de9 h3QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=/Eqp6y1U6oV3l2da1RgVXnZb8ac4lrHEDzyZU9KgpXw=; b=T/HbdL/aiL0jHrd/e1oAtmRZDMOe1gigP1hZ5T7X550rnSTtj9Gud5SL04mcrif1nT /mGWzTKbEMD2Qu0aWtJO47+NDiur7ioEW8D/IBdabOzBT2WpzDN7HWsYTflmH1T+0f+W uV7ayjOBrikJGXHRF3FXSGmTDFUyiHSPxyl0GCWyLY3N3zuY9tazlMKs/hmqp/OPkMet ybKfv9QDOLIZUkPlOQC56x1O07qdoRQNGuOiQOyuG+DWp+D4C04P+6kMVscWRGKFuCSj o/0x0WW5FerPBYgGDvxazBZhfSBlUZTQqiGljY8T1D0fx0L+DDWGQY45paDWDzOtwoRx xqQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b5h89XM0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id d15si6859306plj.361.2020.11.09.13.19.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=b5h89XM0; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 962D2895C8; Mon, 9 Nov 2020 21:19:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 908F989598 for ; Mon, 9 Nov 2020 21:19:33 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id c9so935590wml.5 for ; Mon, 09 Nov 2020 13:19:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=b5h89XM0bSAA01H9VI7YC0WubiXdlYohWOGdakYwfbQeM0MifG/HJ7RiJjyS8bNAqv Yq0xrDdJ/NdDCYnAvDV+Gz94LXJqrl3Y9rQ1xU5cQVElcN9MRBYPt7zShja/Bk9UKiY+ WqQGtf5m5oHpwx0PpT6vx6sx0WU+595ypt6m//MfqLkRGLEVbmlBXKkjvjc4+0QCw5SY 32zJqgbybJVw0CEE2G/rBftR+lVzzS50Z19Gnxv32vnSAyV0pO+I/ApDOOXfswqPnmLU rAqt+Z5FRuuTuszclEWd6FGcuvBK9Rvt+6Q2ubDA7I6UNZGYzp4HdqjtuyoOZzsm2oeB Q+Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e/mxdauGCfin4P1unK7sTKqBRJWd95ferwSgYprlXsM=; b=tszxkgsV1HJ//YftaQpl91T4bIC70t27RBcp+ZJo93gwYYShXj8JMVpdXSQmebAdvd x0rQkEATdpR/QSOAmYIlbkTX7jdVR1X3Lgovgk+v/Vxdwj4CZveLeWMSwnBva4n71zij QysbPj5s/OwQqhiM9tHQFvyWdXrOQU1OIh4tK3/1b6JgkWyBTFXDPHtdYHVCVQ9MhDAc GKaW8hKPWJFJlHhlwOTmiaZwnHRrWupMFedB9R9n7boAjTo+NLC4aHOf5JV3NI4YA22r 6X7uU59oFRf/BLGgr4IieT6MCmeBAw4zmt8ZXK/wmfX6JAHeDNvh2S3KMJCV6IXc0xw/ 6bEQ== X-Gm-Message-State: AOAM531k8lkbJmnmHHNnWRE9V5GnsF8noMVp9lk3xUfT9frQr3gjRSni S/7EWGBSVA51Y0PhuEbhHSCybA== X-Received: by 2002:a1c:6545:: with SMTP id z66mr1082675wmb.157.1604956772232; Mon, 09 Nov 2020 13:19:32 -0800 (PST) Received: from dell.default ([91.110.221.139]) by smtp.gmail.com with ESMTPSA id 71sm15170630wrm.20.2020.11.09.13.19.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 13:19:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/20] drm/radeon/radeon_cs: Fix a bunch of doc-rot issues Date: Mon, 9 Nov 2020 21:18:47 +0000 Message-Id: <20201109211855.3340030-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201109211855.3340030-1-lee.jones@linaro.org> References: <20201109211855.3340030-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, Jerome Glisse , dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_cs.c:416: warning: Function parameter or member 'backoff' not described in 'radeon_cs_parser_fini' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function parameter or member 'p' not described in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Function parameter or member 'idx' not described in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:735: warning: Excess function parameter 'parser' description in 'radeon_cs_packet_parse' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'p' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'cs_reloc' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Function parameter or member 'nomm' not described in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'parser' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'data' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'offset_start' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'offset_mask' description in 'radeon_cs_packet_next_reloc' drivers/gpu/drm/radeon/radeon_cs.c:844: warning: Excess function parameter 'reloc' description in 'radeon_cs_packet_next_reloc' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_cs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c index 21ce2f9502c09..729939df29cc5 100644 --- a/drivers/gpu/drm/radeon/radeon_cs.c +++ b/drivers/gpu/drm/radeon/radeon_cs.c @@ -408,6 +408,7 @@ static int cmp_size_smaller_first(void *priv, struct list_head *a, * cs_parser_fini() - clean parser states * @parser: parser structure holding parsing context. * @error: error number + * @backoff: indicator to backoff the reservation * * If error is set than unvalidate buffer, otherwise just free memory * used by parsing context. @@ -723,8 +724,9 @@ int radeon_cs_ioctl(struct drm_device *dev, void *data, struct drm_file *filp) /** * radeon_cs_packet_parse() - parse cp packet and point ib index to next packet - * @parser: parser structure holding parsing context. + * @p: parser structure holding parsing context. * @pkt: where to store packet information + * @idx: packet index * * Assume that chunk_ib_index is properly set. Will return -EINVAL * if packet is bigger than remaining ib size. or if packets is unknown. @@ -829,11 +831,9 @@ void radeon_cs_dump_packet(struct radeon_cs_parser *p, /** * radeon_cs_packet_next_reloc() - parse next (should be reloc) packet - * @parser: parser structure holding parsing context. - * @data: pointer to relocation data - * @offset_start: starting offset - * @offset_mask: offset mask (to align start offset on) - * @reloc: reloc informations + * @p: parser structure holding parsing context. + * @cs_reloc: reloc informations + * @nomm: never actually used * * Check if next packet is relocation packet3, do bo validation and compute * GPU offset using the provided start.