| Message ID | 20201116173700.1830487-27-lee.jones@linaro.org |
|---|---|
| State | Accepted |
| Commit | 8ab1a48ef6f9f0a7719ac65d8cc393809b872896 |
| Headers | show |
| Series | Rid W=1 warnings from GPU | expand |
On Mon, Nov 16, 2020 at 12:38 PM Lee Jones <lee.jones@linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/atombios_encoders.c:2721:1: warning: no previous prototype for ‘radeon_add_atom_encoder’ [-Wmissing-prototypes] > 2721 | radeon_add_atom_encoder(struct drm_device *dev, > | ^~~~~~~~~~~~~~~~~~~~~~~ > > Cc: Alex Deucher <alexander.deucher@amd.com> > Cc: "Christian König" <christian.koenig@amd.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_atombios.c | 4 ---- > drivers/gpu/drm/radeon/radeon_atombios.h | 4 ++++ > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c > index cc80651b25773..be96d9b64e43b 100644 > --- a/drivers/gpu/drm/radeon/radeon_atombios.c > +++ b/drivers/gpu/drm/radeon/radeon_atombios.c > @@ -37,10 +37,6 @@ > #include "radeon_atombios.h" > #include "radeon_legacy_encoders.h" > > -extern void > -radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, > - uint32_t supported_device, u16 caps); > - > union atom_supported_devices { > struct _ATOM_SUPPORTED_DEVICES_INFO info; > struct _ATOM_SUPPORTED_DEVICES_INFO_2 info_2; > diff --git a/drivers/gpu/drm/radeon/radeon_atombios.h b/drivers/gpu/drm/radeon/radeon_atombios.h > index b7c76920feb7d..a895a7002c3d3 100644 > --- a/drivers/gpu/drm/radeon/radeon_atombios.h > +++ b/drivers/gpu/drm/radeon/radeon_atombios.h > @@ -28,10 +28,14 @@ > #ifndef __RADEON_ATOMBIOS_H__ > #define __RADEON_ATOMBIOS_H__ > > +struct drm_device; > struct drm_display_mode; > struct radeon_device; > > bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, > struct drm_display_mode *mode); > +void radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, > + uint32_t supported_device, u16 caps); > + > > #endif /* __RADEON_ATOMBIOS_H__ */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c index cc80651b25773..be96d9b64e43b 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.c +++ b/drivers/gpu/drm/radeon/radeon_atombios.c @@ -37,10 +37,6 @@ #include "radeon_atombios.h" #include "radeon_legacy_encoders.h" -extern void -radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, - uint32_t supported_device, u16 caps); - union atom_supported_devices { struct _ATOM_SUPPORTED_DEVICES_INFO info; struct _ATOM_SUPPORTED_DEVICES_INFO_2 info_2; diff --git a/drivers/gpu/drm/radeon/radeon_atombios.h b/drivers/gpu/drm/radeon/radeon_atombios.h index b7c76920feb7d..a895a7002c3d3 100644 --- a/drivers/gpu/drm/radeon/radeon_atombios.h +++ b/drivers/gpu/drm/radeon/radeon_atombios.h @@ -28,10 +28,14 @@ #ifndef __RADEON_ATOMBIOS_H__ #define __RADEON_ATOMBIOS_H__ +struct drm_device; struct drm_display_mode; struct radeon_device; bool radeon_atom_get_tv_timings(struct radeon_device *rdev, int index, struct drm_display_mode *mode); +void radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum, + uint32_t supported_device, u16 caps); + #endif /* __RADEON_ATOMBIOS_H__ */
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/atombios_encoders.c:2721:1: warning: no previous prototype for ‘radeon_add_atom_encoder’ [-Wmissing-prototypes] 2721 | radeon_add_atom_encoder(struct drm_device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~ Cc: Alex Deucher <alexander.deucher@amd.com> Cc: "Christian König" <christian.koenig@amd.com> Cc: David Airlie <airlied@linux.ie> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/gpu/drm/radeon/radeon_atombios.c | 4 ---- drivers/gpu/drm/radeon/radeon_atombios.h | 4 ++++ 2 files changed, 4 insertions(+), 4 deletions(-)