From patchwork Tue Nov 24 19:38:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 331431 Delivered-To: patch@linaro.org Received: by 2002:a92:5e16:0:0:0:0:0 with SMTP id s22csp795916ilb; Tue, 24 Nov 2020 11:45:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdpSunATBXzbRrcn6uSs79qhhViao+UiMqcDBq8zGA84MGJ4gyBNc0uPsc/x2cuFoG2o3U X-Received: by 2002:aa7:8744:0:b029:18b:a9e1:803d with SMTP id g4-20020aa787440000b029018ba9e1803dmr337417pfo.50.1606247107290; Tue, 24 Nov 2020 11:45:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606247107; cv=none; d=google.com; s=arc-20160816; b=k2b2ietkIB/VLV0q7WgNlL+wHu7X3HQ1A76vXtjkOSuHnaEHpGIlaRRLxp3+Keh3YU ctkC4Ms/pbWiIL11tBaSHOAXM3bKe7MHdo9Z31iKeMhPcBpzYFhPJB6GSqwUXRUTnwMl dWQEesQM7gjOd0wILVGURc/JzB34awcBnsUNfMOma2lwrIgh2i/hC/Q+e0iGbeZorJoS 4nWFhBR/LiASlWWOUMycwbOUnjAGsGfz6WjQyJU428FgLCsjIl6qMv+FuxVITobtXvqO CL8m6rKuTCVrmv4UW6H8M9S5X3LBaoFbQVglH3rNTXwnJ30aPfZyKsBovzPIj/kTFEIA e18g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=foJJgptZHLi3xSupSBptSIEUGTfY+IzGCXZsJ8YFTb8=; b=q1WjB0iGPNI1LsS2jPyK6Y9Ddq/6wkDtsSgZBXp4xuVZIFIMDA8wdklI/gbzmhfZ8m /eaGUnNsbEJfZakWYAojppe3WA/NFtfxpZwcfOegWW4sQ7vlwDRxXuZa5N62R9nC8BUn NObrzfh7eQqweLLY1X3ak1ML9/CE5cf5G0RvFDijbGZvAKBD7a+sbmEIJ/JqIaUwttj8 yrDyvzEFCUlN9v0o3jYLZlmsA0thmh4PlbghGmpkdBx8wTn9YYYqwImANl5p2bjJPUfJ 7E6kfsKJIZ14Cv0+BETaOCgH8/Xkm4BcJMPmEdWOdFwZ8TKivLCQSOIg9rjFD5F1pCf+ Txpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CrS3VLKK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id v1si98440pjj.65.2020.11.24.11.45.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:45:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=CrS3VLKK; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E06456E58B; Tue, 24 Nov 2020 19:44:48 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 279146E529 for ; Tue, 24 Nov 2020 19:44:38 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id s13so87487wmh.4 for ; Tue, 24 Nov 2020 11:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fzhA0w/k4kTJP8KS6ZWIOoU4RVum3eSvqAYOY6/W8wg=; b=CrS3VLKK9D1gUkCIA06uIjuxPlrWUCRwMEZOWxFbRV7fIAbtAAc/to7IXQeBff+VeI h0PjFmPQRxNRUwSruKjdKt4GFbQalr0csKiQsdY22z9hKPZZYSs1cA18dNWskDnWS44Z wMxwqfOMs6ujI/T/ZFnO/uUVEDzrorssQyIbqoGn+MIe6oeoRurZaEiXmb4kJOtwbyEP ryyDf+Q11Rpg/uk5lXWWFQKZgIMOydzVZyEuitEJh2BdPdwfxdKnfmb6n/bRqYCgR9TI jWlSwFHkmQeuviVAJ2SLH5jbKuAQAbxjt5ytBB5B/n7F34njf/oY59uCRF8oIllIOnYw wgqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fzhA0w/k4kTJP8KS6ZWIOoU4RVum3eSvqAYOY6/W8wg=; b=g3krC+k+SdvWbATbbgZCf54tzhBQaM50Fn1OtxjGqSvF3nJSPqA65hEBLU5muPL7PA z6i48H0F123PLB1BQjgUDHc27sh5j+3YJKPs+S+JEJTbjEYMV4/flvFu2dHJBHr5lH8T wEx1x1wFPUoLKPkxKMiHr/qFP6LRG/kZOXYORRxX1gKR8vRdgq0GYy6lnev/q2rpQR6P q1bvG8dljXgxW12f/wVKwsFpceK8bUzOs90YwTjGwo3fvalYgsG9EQf8EJQF/S+Ddvei QnmChGLt8TgBSxlhZtwx8c3LJh5OSYaGHedjJTIfJH0i9KPVbJs7StD9eusZst/pyvPv JLDw== X-Gm-Message-State: AOAM531aKKnwbznAAL8H9HTNSJjr8dvjpGu3/i5vWhlMpVoJNOhmtfUO XFvW6FKkTCUEkgNRUAIB/ULRPQ== X-Received: by 2002:a05:600c:414b:: with SMTP id h11mr63586wmm.89.1606247076873; Tue, 24 Nov 2020 11:44:36 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id d134sm200511wmd.8.2020.11.24.11.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Nov 2020 11:44:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 30/40] drm/amd/amdgpu/jpeg_v1_0: Add some missing function param descriptions Date: Tue, 24 Nov 2020 19:38:14 +0000 Message-Id: <20201124193824.1118741-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201124193824.1118741-1-lee.jones@linaro.org> References: <20201124193824.1118741-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Veerabadhran G , amd-gfx@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or member 'addr' not described in 'jpeg_v1_0_decode_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or member 'seq' not described in 'jpeg_v1_0_decode_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Function parameter or member 'flags' not described in 'jpeg_v1_0_decode_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:219: warning: Excess function parameter 'fence' description in 'jpeg_v1_0_decode_ring_emit_fence' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:293: warning: Function parameter or member 'job' not described in 'jpeg_v1_0_decode_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:293: warning: Function parameter or member 'flags' not described in 'jpeg_v1_0_decode_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c:518: warning: Function parameter or member 'mode' not described in 'jpeg_v1_0_start' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Veerabadhran G Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c index c600b61b5f45d..c87102b238e48 100644 --- a/drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c +++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v1_0.c @@ -210,7 +210,9 @@ static void jpeg_v1_0_decode_ring_insert_end(struct amdgpu_ring *ring) * jpeg_v1_0_decode_ring_emit_fence - emit an fence & trap command * * @ring: amdgpu_ring pointer - * @fence: fence to emit + * @addr: address + * @seq: sequence number + * @flags: fence related flags * * Write a fence and a trap command to the ring. */ @@ -282,7 +284,9 @@ static void jpeg_v1_0_decode_ring_emit_fence(struct amdgpu_ring *ring, u64 addr, * jpeg_v1_0_decode_ring_emit_ib - execute indirect buffer * * @ring: amdgpu_ring pointer + * @job: job to retrive vmid from * @ib: indirect buffer to execute + * @flags: unused * * Write ring commands to execute the indirect buffer. */ @@ -511,6 +515,7 @@ void jpeg_v1_0_sw_fini(void *handle) * jpeg_v1_0_start - start JPEG block * * @adev: amdgpu_device pointer + * @mode: SPG or DPG mode * * Setup and start the JPEG block */