From patchwork Fri Jan 8 20:14:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 359031 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp855549jai; Fri, 8 Jan 2021 12:15:22 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxqKU768WrtgLX9HSh+UbB+oYSBae2zeszqCaSxbXoqCtSiBQaz72sXWPRaYP4HUrQAJqr X-Received: by 2002:a17:902:ac98:b029:da:cd0f:b6a4 with SMTP id h24-20020a170902ac98b02900dacd0fb6a4mr5544951plr.71.1610136922491; Fri, 08 Jan 2021 12:15:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610136922; cv=none; d=google.com; s=arc-20160816; b=A1D0u8fF8FSs0FsrJd3oMpbUjCzGwn9aLacMGhD2X/BZ0woWySxYvStSvtlMih0BoH X0cgWASHgOEEtIc0xTfsxUi04j8VJB+sUtocq6Ud/42suzVEBewl4Snf36wGYNRxgmFr wxmTA9bxJLQTsmuJ18PQOvlb2XyOsslQ0FO0ssDUQ9NAiwuiPzdVCpkBA1kT4Ejfy9Rf 36l29y0bW86/+EZRtsJ9J9xYSK1TbKV9BHsgCdOejrfYPPAT73CUYAEOO4jFpv+4605L YY02ZCXMpaW8O7Kwdqi6zXlmGoQzHuQdX22ij1I1yGTefJyAUTGLPlqNtmRWssdkktyd kv0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:dkim-signature:delivered-to; bh=ZIgYkTuO6ZU7hBSErUWBD0lQtW1Nv1pnOX0s3dv/ZR8=; b=fmscW2My1REvJdrhR0kEro3GDiuFAga2dyPEOWubPiFyOTUNbc+QxF8XNszDaM1VPn WAzrKKWX0yKMAPumJoezOOEEhljP3I1TUdc1INbiEwgu6Jy0LkztyZQy867YCkpiFX36 3t8V+VEKOiUH7wyL0iqM2OvaxZ65GPuRGQzJ6gWvExBqkJUBYGfqxMgs4kgR48PW/OIY vI4js0BhD+9HrQY9QEh+2IJ+eDM9MtM0EdXV3TKH86TYw5/qyKzGFsFIXp/7XsCK7IGQ ebhbVeO/UYB2bXeREI3NDmj2mc86ESmkc2CcqTjPZjc6XFuaZjF+HT8zdEgDUgGhjiiG FW9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=nPDEIclv; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [2610:10:20:722:a800:ff:fe36:1795]) by mx.google.com with ESMTPS id y8si10229055pfe.319.2021.01.08.12.15.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) client-ip=2610:10:20:722:a800:ff:fe36:1795; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=nPDEIclv; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 2610:10:20:722:a800:ff:fe36:1795 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C2C916E8CB; Fri, 8 Jan 2021 20:15:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC0986E8C7 for ; Fri, 8 Jan 2021 20:15:12 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id e25so9468842wme.0 for ; Fri, 08 Jan 2021 12:15:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/ToVqtfELMjein9lDL+03lGe+1Pl1kI6Nuvl2V02OQw=; b=nPDEIclvcchArGWcIIvap7p0tV/Rf2lx9TgJnp2hWX/nn04pew9eH1DzQvuV0oY5dO uYlPu7t+/BwZmmgpIRvGBX6xDjVNdvmLl+T2XbI2y544GNEB6poJK2wXefPMvuaFj0LP 1bCfmVawsAnd5iffgC8cCaUk23jdkFMPX+hldzpdztsaQnGn2D8TM1pnYc4PdJ6sTXk3 P1sqHnU5kzx2HnlGpQuZsYJ+pxTCkn5kn6mPH3fPIPc1QO5y/Xrw6NNIr/Q1c7Xnw8aQ r9Pdv/WXBOoNMt3BNY+r7SM95gZeSzHHPx7Kev1iki8AutO6xe2Cz9US+Kdjr5TXZeoz MdEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/ToVqtfELMjein9lDL+03lGe+1Pl1kI6Nuvl2V02OQw=; b=QjojQ/h0yAmvxdzjAcbWqpTwoNpyo4OanaskwBVezYudyxXBvC99DVBC6Xq3lOcfKN 0vwNajiIahj4MIVds9c3ohN0NHPn0G7Iy5o+sxtkfxp040eXc0VV0XjO3f4YV5nih+SF xRTxhoG/HQQrm/VNDJmhh4z8JJ6+UFE2pbfUVBEvV3jBEgLkjxxrpXnW7IqQDxzi53SA Q/jxhdd6Pd9vN23O/5sxjmtH67relu/k3Wjexo8wzR2IpNyFtc734OSGSkz6zVnyjH6D D0xF7Ds08OebY/gQpWAGTSn9lqoCOTLEWRn7/yQvH9nDEOA4lnVaopOnn+y1L9+IzYU2 4gQA== X-Gm-Message-State: AOAM531PUuTevKunSSv5KNnMM/ZVo+ikASLUa/8YuB9t7xoGv/xapKQq TQcYFoLqsbM08e/R/95Ex9gePw== X-Received: by 2002:a1c:1d08:: with SMTP id d8mr4586040wmd.159.1610136911373; Fri, 08 Jan 2021 12:15:11 -0800 (PST) Received: from dell.default ([91.110.221.229]) by smtp.gmail.com with ESMTPSA id l8sm15598671wrb.73.2021.01.08.12.15.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 12:15:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/40] drm/amd/amdgpu/vega20_ih: Add missing descriptions for 'ih' and fix spelling error Date: Fri, 8 Jan 2021 20:14:22 +0000 Message-Id: <20210108201457.3078600-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108201457.3078600-1-lee.jones@linaro.org> References: <20210108201457.3078600-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Feifei Xu , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6?= =?utf-8?q?nig?= , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/vega20_ih.c:378: warning: Function parameter or member 'ih' not described in 'vega20_ih_get_wptr' drivers/gpu/drm/amd/amdgpu/vega20_ih.c:421: warning: Function parameter or member 'ih' not described in 'vega20_ih_irq_rearm' drivers/gpu/drm/amd/amdgpu/vega20_ih.c:447: warning: Function parameter or member 'ih' not described in 'vega20_ih_set_rptr' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Hawking Zhang Cc: Feifei Xu Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/vega20_ih.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c index 42032ca380ccf..5a3c867d58811 100644 --- a/drivers/gpu/drm/amd/amdgpu/vega20_ih.c +++ b/drivers/gpu/drm/amd/amdgpu/vega20_ih.c @@ -88,7 +88,7 @@ static void vega20_ih_init_register_offset(struct amdgpu_device *adev) * vega20_ih_toggle_ring_interrupts - toggle the interrupt ring buffer * * @adev: amdgpu_device pointer - * @ih: amdgpu_ih_ring pointet + * @ih: amdgpu_ih_ring pointer * @enable: true - enable the interrupts, false - disable the interrupts * * Toggle the interrupt ring buffer (VEGA20) @@ -367,6 +367,7 @@ static void vega20_ih_irq_disable(struct amdgpu_device *adev) * vega20_ih_get_wptr - get the IH ring buffer wptr * * @adev: amdgpu_device pointer + * @ih: amdgpu_ih_ring pointer * * Get the IH ring buffer wptr from either the register * or the writeback memory buffer (VEGA20). Also check for @@ -414,6 +415,7 @@ static u32 vega20_ih_get_wptr(struct amdgpu_device *adev, * vega20_ih_irq_rearm - rearm IRQ if lost * * @adev: amdgpu_device pointer + * @ih: amdgpu_ih_ring pointer * */ static void vega20_ih_irq_rearm(struct amdgpu_device *adev, @@ -439,6 +441,7 @@ static void vega20_ih_irq_rearm(struct amdgpu_device *adev, * vega20_ih_set_rptr - set the IH ring buffer rptr * * @adev: amdgpu_device pointer + * @ih: amdgpu_ih_ring pointer * * Set the IH ring buffer rptr. */